1 From 511840e82116662aa825088fb8a52a9f799f7767 Mon Sep 17 00:00:00 2001
2 From: Nathan Rajlich <nathan@tootallnate.net>
3 Date: Wed, 14 Nov 2012 16:54:04 -0800
4 Subject: [PATCH 2/3] gyp: apply https://codereview.chromium.org/11361103/
7 gyp/pylib/gyp/generator/msvs.py | 6 ++++++
8 1 file changed, 6 insertions(+)
10 diff --git a/gyp/pylib/gyp/generator/msvs.py b/gyp/pylib/gyp/generator/msvs.py
11 index d8e0872..c59aea1 100644
12 --- a/gyp/pylib/gyp/generator/msvs.py
13 +++ b/gyp/pylib/gyp/generator/msvs.py
14 @@ -2720,6 +2720,9 @@ def _GetMSBuildAttributes(spec, config, build_file):
15 product_name = spec.get('product_name', '$(ProjectName)')
16 target_name = prefix + product_name
17 msbuild_attributes['TargetName'] = target_name
18 + if 'TargetExt' not in msbuild_attributes and 'product_extension' in spec:
19 + ext = spec.get('product_extension')
20 + msbuild_attributes['TargetExt'] = '.' + ext
22 if spec.get('msvs_external_builder'):
23 external_out_dir = spec.get('msvs_external_builder_out_dir', '.')
24 @@ -2773,6 +2776,9 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
25 attributes['OutputDirectory'])
26 _AddConditionalProperty(properties, condition, 'TargetName',
27 attributes['TargetName'])
28 + if 'TargetExt' in attributes:
29 + _AddConditionalProperty(properties, condition, 'TargetExt',
30 + attributes['TargetExt'])
32 if attributes.get('TargetPath'):
33 _AddConditionalProperty(properties, condition, 'TargetPath',