Filter conflicting changes (deleted + added at the same time)

[simantics/3d.git] / org.simantics.g3d.vtk / src / org / simantics / g3d / vtk / common / AbstractVTKNodeMap.java

diff --git a/org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/common/AbstractVTKNodeMap.java b/org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/common/AbstractVTKNodeMap.java
index d9b754b45e115bb0f7be78fc6c3f56c327abae37..b762200786217a0434515a068a8d0f89cbe222e6 100644 (file)
--- a/org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/common/AbstractVTKNodeMap.java
+++ b/org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/common/AbstractVTKNodeMap.java
@@ -50,7 +50,7 @@ import vtk.vtkProp;
 
 public abstract class AbstractVTKNodeMap<E extends INode> implements VTKNodeMap<E>, IMappingListener, RenderListener, NodeListener, UndoRedoSupport.ChangeListener{
 
-       private static final boolean DEBUG = false;
+       private static final boolean DEBUG = true;
        
        protected Session session;
        protected IMapping<Object,E> mapping;
@@ -428,6 +428,16 @@ public abstract class AbstractVTKNodeMap<E extends INode> implements VTKNodeMap<
                return n + "@" + Integer.toHexString(n.hashCode());
        }
        
+       protected boolean filterChange(List<Pair<E,String>> list,E n) {
+           for (int i = list.size()-1; i >= 0; i--) {
+            if (list.get(i).first == n) {
+                list.remove(i);
+                return true;
+            }
+        }
+           return false;
+       }
+       
        @SuppressWarnings("unchecked")
        protected void updateCycle() {
                rem.clear();
@@ -437,18 +447,16 @@ public abstract class AbstractVTKNodeMap<E extends INode> implements VTKNodeMap<
                
                
                synchronized (syncMutex) {
-                   // Check for overlapping additions and deletions, prevent deleting objects that are also added.
+                   // Check for overlapping additions and deletions, prevent deleting objects that are also added and vice versa.
                    Deque<E> stack = new ArrayDeque<E>();
                for (Pair<E, String> n : added) {
                    stack.add(n.first);
                }
                while (!stack.isEmpty()) {
                    E n = stack.pop();
-                   for (int i = removed.size()-1; i >= 0; i--) {
-                       if (removed.get(i).first == n) {
-                           removed.remove(i);
-                           break;
-                       }
+                   boolean conflict = filterChange(removed, n);
+                   if (conflict) {
+                       filterChange(added, n);   
                    }
                    if (n instanceof ParentNode) {
                        ParentNode<INode> pn = (ParentNode<INode>)n;