]> gerrit.simantics Code Review - simantics/interop.git/blobdiff - org.simantics.interop/src/org/simantics/interop/test/GraphComparator.java
Allow defining matching resources (Comparing models with structural components)
[simantics/interop.git] / org.simantics.interop / src / org / simantics / interop / test / GraphComparator.java
index dff6672b86820924f52f0906e6c658498916abb2..1ae5ed2450b45e469cd57135140f37bb306bf211 100644 (file)
@@ -25,8 +25,8 @@ import org.simantics.db.ReadGraph;
 import org.simantics.db.Resource;\r
 import org.simantics.db.Statement;\r
 import org.simantics.db.common.utils.NameUtils;\r
+import org.simantics.db.exception.DatabaseException;\r
 import org.simantics.db.exception.DoesNotContainValueException;\r
-import org.simantics.db.exception.ManyObjectsForFunctionalRelationException;\r
 import org.simantics.db.exception.ServiceException;\r
 import org.simantics.db.exception.ValidationException;\r
 import org.simantics.layer0.Layer0;\r
@@ -48,10 +48,12 @@ import org.simantics.utils.datastructures.Pair;
  */\r
 public class GraphComparator {\r
 \r
-       \r
+       private Resource r1;\r
+       private Resource r2;\r
        private List<Resource> traversed = new ArrayList<Resource>(); // list of relations that are traversed (and tested)\r
        private List<Resource> tested = new ArrayList<Resource>();    // list of relations that are tested, but not traversed\r
        private List<Resource> nonTraversed = new ArrayList<Resource>(); // list of relations that are not traversed\r
+       private List<Resource> nonTested = new ArrayList<Resource>(); // list of relations that are not tested\r
        \r
        private List<Statement> changes1 = new ArrayList<Statement>();\r
        private List<Statement> changes2 = new ArrayList<Statement>();\r
@@ -60,21 +62,51 @@ public class GraphComparator {
        private Set<Statement> changes2Set = new HashSet<Statement>();\r
        private Set<Pair<Statement,Statement>> modificationsSet = new HashSet<Pair<Statement,Statement>>();\r
 \r
-       private BijectionMap<Statement, Statement> comparable = new BijectionMap<Statement, Statement>();\r
+       private BijectionMap<Statement, Statement> comparableStatements = new BijectionMap<Statement, Statement>();\r
+       private BijectionMap<Resource, Resource> comparableResources = new BijectionMap<Resource, Resource>();\r
+       \r
        \r
+       private ObjectComparator comparator;\r
+       \r
+       private Comparator<Statement> scomp = new PredicateComparator();\r
+       private Comparator<Resource> rcomp = new ResourceComparator();\r
        \r
        // runtime attributes\r
        \r
        private ReadGraph g;\r
        private Layer0 b;\r
        \r
-       ArrayList<Resource> rs1 = new ArrayList<Resource>();\r
-       ArrayList<Resource> rs2 = new ArrayList<Resource>();\r
+       public GraphComparator(Resource r1, Resource r2) {\r
+               this.r1 = r1;\r
+               this.r2 = r2;\r
+               comparator = new TypeComparator();\r
+       }\r
+       \r
+       public GraphComparator(Resource r1, Resource r2, ObjectComparator comparator) {\r
+               this.r1 = r1;\r
+               this.r2 = r2;\r
+               this.comparator = comparator;\r
+       }\r
+       \r
        ArrayList<Statement> ss1 = new ArrayList<Statement>();\r
        ArrayList<Statement> ss2 = new ArrayList<Statement>();\r
-       Comparator<Statement> scomp = new PredicateComparator();\r
-       Comparator<Resource> rcomp = new ResourceComparator();\r
-\r
+       \r
+       \r
+       public Comparator<Resource> getResourceComparator() {\r
+               return rcomp;\r
+       }\r
+       \r
+       public Comparator<Statement> getStatementComparator() {\r
+               return scomp;\r
+       }\r
+       \r
+       public Resource getR1() {\r
+               return r1;\r
+       }\r
+       \r
+       public Resource getR2() {\r
+               return r2;\r
+       }\r
        \r
        public void addTraversed(Resource rel) {\r
                traversed.add(rel);\r
@@ -100,33 +132,52 @@ public class GraphComparator {
                tested.addAll(rels);\r
        }\r
        \r
+       public void addNonTested(Resource rel) {\r
+               nonTested.add(rel);\r
+       }\r
+       \r
+       public void addNonTested(Collection<Resource> rels) {\r
+               nonTested.addAll(rels);\r
+       }\r
+       \r
+       public void addComparableResources(Resource r1, Resource r2) {\r
+               comparableResources.map(r1, r2);\r
+       }\r
+       \r
+       public void addComparableResources(BijectionMap<Resource, Resource> matching) {\r
+               comparableResources.addAll(matching);\r
+       }\r
+       \r
        public void clearRels() {\r
                traversed.clear();\r
                tested.clear();\r
+               nonTraversed.clear();\r
+               nonTested.clear();\r
        }\r
        \r
-       public void test(ReadGraph g, Resource r1, Resource r2) throws ServiceException, DoesNotContainValueException, ValidationException {\r
+       public void test(ReadGraph g) throws DatabaseException {\r
                this.g = g;\r
                this.b = Layer0.getInstance(g);\r
-               \r
-               changes1Set.clear();\r
-               changes2Set.clear();\r
-               modificationsSet.clear();\r
-               changes1.clear();\r
-               changes2.clear();\r
-               modifications.clear();\r
+               comparator.setComparator(this);\r
                \r
                Stack<Resource> stack1 = new Stack<Resource>();\r
                Stack<Resource> stack2 = new Stack<Resource>();\r
                stack1.push(r1);\r
                stack2.push(r2);\r
                \r
+               \r
                List<Statement> ss1 = new ArrayList<Statement>();\r
                List<Statement> ss2 = new ArrayList<Statement>();\r
                \r
                while (!stack1.isEmpty()) {\r
-                       r1 = stack1.pop();\r
-                       r2 = stack2.pop();\r
+                       Resource r1 = stack1.pop();\r
+                       Resource r2 = stack2.pop();\r
+               \r
+                       if (comparableResources.contains(r1, r2)) {\r
+                               System.out.println("already tested " + NameUtils.getSafeName(g, r1) + " " + NameUtils.getSafeName(g, r2));\r
+                               continue;\r
+                       }\r
+                       comparableResources.map(r1, r2);\r
                        \r
                        System.out.println("test " + NameUtils.getSafeName(g, r1) + " " + NameUtils.getSafeName(g, r2));\r
                        compareProps(r1, r2);\r
@@ -138,8 +189,10 @@ public class GraphComparator {
                                ss2 = filterAsserted(r2, ss2);\r
                                ss1 = filterTraversed(ss1);\r
                                ss2 = filterTraversed(ss2);\r
+                               ss1 = filterNonTested(ss1);\r
+                               ss2 = filterNonTested(ss2);\r
                                \r
-                               compareStatement(ss1, ss2, null, null);\r
+                               compareStatements(ss1, ss2, null, null);\r
                                ss1.clear();\r
                                ss2.clear();\r
                        }\r
@@ -149,7 +202,7 @@ public class GraphComparator {
                                ss2.addAll(g.getStatements(r2, rel));\r
                                ss1 = filterAsserted(r1, ss1);\r
                                ss2 = filterAsserted(r2, ss2);\r
-                               compareStatement(ss1, ss2, stack1, stack2);\r
+                               compareStatements(ss1, ss2, stack1, stack2);\r
                                ss1.clear();\r
                                ss2.clear();\r
                        }\r
@@ -158,19 +211,12 @@ public class GraphComparator {
        \r
        \r
        \r
-       public BijectionMap<Statement, Statement> getComparable() {\r
-               return comparable;\r
+       public BijectionMap<Statement, Statement> getComparableStatements() {\r
+               return comparableStatements;\r
        }\r
        \r
        public GraphChanges getChanges() {\r
-//             List<Statement> deletions = new ArrayList<Statement>();\r
-//             List<Statement> additions = new ArrayList<Statement>();\r
-//             deletions.addAll(changes1);\r
-//             additions.addAll(changes2);\r
-//             Collections.sort(deletions, new FullStatementComparator());\r
-//             Collections.sort(additions, new FullStatementComparator());\r
-//             return new GraphChanges(deletions, additions, modifications);\r
-               return new GraphChanges(changes1,changes2,modifications);\r
+               return new GraphChanges(r1,r2,changes1,changes2,modifications,comparableResources);\r
        }\r
        \r
        private List<Statement> filterAsserted(Resource r, Collection<Statement> in) throws ServiceException {\r
@@ -187,11 +233,21 @@ public class GraphComparator {
                return NameUtils.getSafeName(graph, s.getSubject()) + " " + NameUtils.getSafeName(graph, s.getPredicate()) + " " + NameUtils.getSafeName(graph, s.getObject());\r
        }\r
        \r
-       private List<Statement> filterTraversed(Collection<Statement> in) throws ServiceException {\r
+       private List<Statement> filterTraversed(List<Statement> in) throws ServiceException {\r
+               return filter(traversed, in);\r
+       }\r
+       \r
+       private List<Statement> filterNonTested(List<Statement> in) throws ServiceException {\r
+               return filter(nonTested, in);\r
+       }\r
+       \r
+       private List<Statement> filter(Collection<Resource> toFilter, List<Statement> in) throws ServiceException {\r
+               if (toFilter.size() == 0)\r
+                       return in;\r
                List<Statement> out = new ArrayList<Statement>();\r
                for (Statement s : in) {\r
                        boolean usable = true;\r
-                       for (Resource r : traversed) {\r
+                       for (Resource r : toFilter) {\r
                                if (g.isSubrelationOf(s.getPredicate(),r)) {\r
                                        usable = false;\r
                                        break;\r
@@ -228,9 +284,81 @@ public class GraphComparator {
                }\r
        }\r
        \r
-       private void compareStatement(List<Statement> ss1, List<Statement> ss2, Stack<Resource> stack1, Stack<Resource> stack2) throws ServiceException, DoesNotContainValueException, ValidationException {\r
-               Collections.sort(ss1, scomp);\r
-               Collections.sort(ss2, scomp);\r
+       public void sortStatement(List<Statement> list1, List<Statement> list2) {\r
+               Collections.sort(list1,scomp);\r
+               Collections.sort(list2,scomp);\r
+               \r
+               List<Statement> sorted1 = new ArrayList<Statement>(list1.size());\r
+               List<Statement> sorted2 = new ArrayList<Statement>(list2.size());\r
+               sorted1.addAll(list1);\r
+               sorted2.addAll(list2);\r
+               \r
+               int ss1 = 0;\r
+               int ss2 = 0;\r
+               for (int i = 0; i < list1.size(); ) {\r
+                       Statement s1 = list1.get(i);\r
+                       int same1 = sameRel(list1, i);  \r
+                       for (int j = 0; j < list2.size(); j++) {\r
+                               Statement s2 = list2.get(j);\r
+                               if (scomp.compare(s1, s2) == 0) {\r
+                                       int same2 = sameRel(list2, j);\r
+                                       copy(sorted1,ss1,list1,i,same1);\r
+                                       ss1 += same1;\r
+                                       copy(sorted2,ss2,list2,j,same2);\r
+                                       ss2 += same2;\r
+                                       break;\r
+                               }\r
+                       }\r
+                       i+= same1;\r
+               }\r
+               if (ss1 < sorted1.size()) {\r
+                       for (Statement s : list1) {\r
+                               if (!sorted1.contains(s))\r
+                                       sorted1.add(s);\r
+                       }\r
+               }\r
+               if (ss2 < sorted2.size()) {\r
+                       for (Statement s : list2) {\r
+                               if (!sorted2.contains(s))\r
+                                       sorted2.add(s);\r
+                       }\r
+               }\r
+               \r
+               list1.clear();\r
+               list2.clear();\r
+               list1.addAll(sorted1);\r
+               list2.addAll(sorted2);\r
+       }\r
+       \r
+       public <T> void copy(List<T> to, int toIndex, List<T> from, int fromIndex, int amount) {\r
+               for (int i = 0; i <  amount; i++) {\r
+                       to.set(toIndex + i, from.get(fromIndex+ i));\r
+               }\r
+       }\r
+       \r
+       public void sortResource(List<Resource> list1, List<Resource> list2) {\r
+               Collections.sort(list1,rcomp);\r
+               int js = 0;\r
+               for (int i = 0; i < list1.size(); i++) {\r
+                       Resource s1 = list1.get(i);\r
+                       for (int j = js; j < list2.size(); j++) {\r
+                               Resource s2 = list2.get(j);\r
+                               if (rcomp.compare(s1, s2) == 0) {\r
+                                       Resource t = list2.get(js);\r
+                                       list2.set(js, s2);\r
+                                       list2.set(j, t);\r
+                                       break;\r
+                               }\r
+                       }\r
+                       js++;\r
+                       \r
+               }\r
+       }\r
+       \r
+       private void compareStatements(List<Statement> ss1, List<Statement> ss2, Stack<Resource> stack1, Stack<Resource> stack2) throws DatabaseException {\r
+               sortStatement(ss1, ss2);\r
+//             Collections.sort(ss1, scomp);\r
+//             Collections.sort(ss2, scomp);\r
                \r
                int i1 = 0;\r
                int i2 = 0;\r
@@ -241,7 +369,7 @@ public class GraphComparator {
                                        break;\r
                                } else {\r
                                        while (i2 < ss2.size()) {\r
-                                               System.out.println("Compare Statement diff2 " + printStatement(g,ss2.get(i2)));\r
+                                               System.out.println("Compare Statements diff2 " + printStatement(g,ss2.get(i2)));\r
                                                \r
                                                addAddition(ss2.get(i2));\r
                                                i2++;\r
@@ -250,7 +378,7 @@ public class GraphComparator {
                                }\r
                        } else if (i2 >= ss2.size()) {\r
                                while (i1 < ss1.size()) {\r
-                                       System.out.println("Compare Statement diff1 " + printStatement(g,ss1.get(i1)));\r
+                                       System.out.println("Compare Statements diff1 " + printStatement(g,ss1.get(i1)));\r
                                        addDeletion(ss1.get(i1));\r
                                        i1++;\r
                                }\r
@@ -260,18 +388,18 @@ public class GraphComparator {
                        int same2 = sameRel(ss2, i2);\r
                        int c = rcomp.compare(ss1.get(i1).getPredicate(),ss2.get(i2).getPredicate());\r
                        if (c == 0) {\r
-                               compareObject(ss1, i1, same1, ss2, i2, same2,stack1,stack2);\r
+                               compareStatements(ss1, i1, same1, ss2, i2, same2,stack1,stack2);\r
                                i1+=same1;\r
                                i2+=same2;\r
                        } else if (c < 0) {\r
                                for (int i = 0; i < same1; i++) {\r
-                                       System.out.println("Compare Statement diff1 " + printStatement(g,ss1.get(i+i1)));\r
+                                       System.out.println("Compare Statements diff1 " + printStatement(g,ss1.get(i+i1)));\r
                                        addDeletion(ss1.get(i+i1));\r
                                }\r
                                i1 += same1;\r
                        } else {\r
                                for (int i = 0; i < same2; i++) {\r
-                                       System.out.println("Compare Statement diff2 " + printStatement(g,ss2.get(i+i2)));\r
+                                       System.out.println("Compare Statements diff2 " + printStatement(g,ss2.get(i+i2)));\r
                                        addAddition(ss2.get(i+i2));\r
                                }\r
                                \r
@@ -296,8 +424,13 @@ public class GraphComparator {
                \r
        }\r
 \r
+       private int compareObject(Resource o1, Resource o2) throws DatabaseException {\r
+               if (comparableResources.contains(o1, o2))\r
+                       return (-1);\r
+               return comparator.compare(g, o1, o2);\r
+       }\r
        \r
-       private void compareObject(List<Statement> ss1, int off1, int len1, List<Statement> ss2, int off2, int len2, Stack<Resource> stack1, Stack<Resource> stack2) throws ServiceException, DoesNotContainValueException, ValidationException {\r
+       private void compareStatements(List<Statement> ss1, int off1, int len1, List<Statement> ss2, int off2, int len2, Stack<Resource> stack1, Stack<Resource> stack2) throws DatabaseException {\r
                boolean[] used1 = new boolean[len1];\r
                for (int i = 0; i < used1.length; i++) {\r
                        used1[i] = false;\r
@@ -312,15 +445,10 @@ public class GraphComparator {
                List<List<Integer>> differences = new ArrayList<List<Integer>>();\r
                for (int i1 = off1; i1 < off1 + len1; i1++) {\r
                        Statement s1 = ss1.get(i1);\r
-                       //Map<Integer,Integer> differences = new HashMap<Integer, Integer>();\r
                        List<Integer> diff = new ArrayList<Integer>();\r
                        for (int i2 = off2; i2 < off2 + len2; i2++) {\r
                                Statement s2 = ss2.get(i2);\r
-                               if (!compareType(s1.getObject(), s2.getObject())) {\r
-                                       diff.add(Integer.MAX_VALUE);\r
-                                       continue;\r
-                               }\r
-                               diff.add(propsDiffCount(s1.getObject(), s2.getObject()));\r
+                               diff.add(compareObject(s1.getObject(), s2.getObject()));\r
                        }\r
                        differences.add(diff);\r
                }\r
@@ -350,9 +478,14 @@ public class GraphComparator {
                                                        continue;\r
                                                used1[i1] = true;\r
                                                used2[i2] = true;\r
+                                               Statement s1  = ss1.get(i1+off1);\r
+                                               Statement s2  = ss2.get(i2+off2);\r
+                                               \r
                                                if (stack1 != null) {\r
-                                                       stack1.add(ss1.get(i1+off1).getObject());\r
-                                                       stack2.add(ss2.get(i2+off2).getObject());\r
+                                                       \r
+                                                               stack1.add(s1.getObject());\r
+                                                               stack2.add(s2.getObject());\r
+                                                       \r
                                                } else {\r
                                                        // TODO : how should we report non traversed differences\r
                                                        // using compareProps assumes that referenced objects are the same (references are not different)\r
@@ -366,6 +499,8 @@ public class GraphComparator {
 //                                                             modifies.add(new Pair<Statement, Statement>(ss1.get(i1+off1), ss2.get(i2+off2)));\r
 //                                                     }\r
                                                }\r
+                                               comparableStatements.map(s1, s2);\r
+                                               //comparableResources.map(s1.getObject(), s2.getObject());\r
                                                break;\r
                                        }\r
                                }\r
@@ -385,30 +520,7 @@ public class GraphComparator {
                }\r
        }\r
        \r
-       private boolean compareType(Resource r1, Resource r2) throws ServiceException, ManyObjectsForFunctionalRelationException {\r
-               rs1.addAll(g.getObjects(r1, b.InstanceOf));\r
-               rs2.addAll(g.getObjects(r2, b.InstanceOf));\r
-               if (rs1.size() != rs2.size()) {\r
-                       rs1.clear();\r
-                       rs2.clear();\r
-                       return false;\r
-               }\r
-               Collections.sort(rs1, rcomp);\r
-               Collections.sort(rs2, rcomp);\r
-               for (int i = 0; i < rs1.size(); i++) {\r
-                       int c = rcomp.compare(rs1.get(i), rs2.get(i));\r
-                       if (c != 0) {\r
-                               rs1.clear();\r
-                               rs2.clear();\r
-                               return false;\r
-                       }\r
-               }\r
-               \r
-               rs1.clear();\r
-               rs2.clear();\r
-               \r
-               return true;\r
-       }\r
+       \r
        \r
        /**\r
         * compares properties, assumes functional relations\r
@@ -423,8 +535,9 @@ public class GraphComparator {
                ArrayList<Statement> ss2 = new ArrayList<Statement>();\r
                ss1.addAll(g.getStatements(r1, b.HasProperty));\r
                ss2.addAll(g.getStatements(r2, b.HasProperty));\r
-               Collections.sort(ss1, scomp);\r
-               Collections.sort(ss2, scomp);\r
+               sortStatement(ss1, ss2);\r
+//             Collections.sort(ss1, scomp);\r
+//             Collections.sort(ss2, scomp);\r
                \r
                int i1 = 0; \r
                int i2 = 0;\r
@@ -460,37 +573,19 @@ public class GraphComparator {
                                        if (b1) {\r
                                                Object v1 = g.getValue(s1.getObject());\r
                                                Object v2 = g.getValue(s2.getObject());\r
-                                               boolean eq = false;\r
-                                               if (v1 instanceof Object[] && v2 instanceof Object[])\r
-                                                       eq = Arrays.deepEquals((Object[])v1, (Object[])v2);\r
-                                               else if (v1 instanceof int[] && v2 instanceof int[]) \r
-                                                       eq = Arrays.equals((int[])v1, (int[])v2);\r
-                                               else if (v1 instanceof float[] && v2 instanceof float[]) \r
-                                                       eq = Arrays.equals((float[])v1, (float[])v2);\r
-                                               else if (v1 instanceof double[] && v2 instanceof double[]) \r
-                                                       eq = Arrays.equals((double[])v1, (double[])v2);\r
-                                               else if (v1 instanceof long[] && v2 instanceof long[]) \r
-                                                       eq = Arrays.equals((long[])v1, (long[])v2);\r
-                                               else if (v1 instanceof byte[] && v2 instanceof byte[]) \r
-                                                       eq = Arrays.equals((byte[])v1, (byte[])v2);\r
-                                               else if (v1 instanceof boolean[] && v2 instanceof boolean[]) \r
-                                                       eq = Arrays.equals((boolean[])v1, (boolean[])v2);\r
-                                               else\r
-                                                       eq = v1.equals(v2);\r
+                                               boolean eq = compareValue(v1, v2);\r
                                                if (!eq) {\r
-                                                       //changes1.add(s1);\r
-                                                       //changes2.add(s2);\r
                                                        addModification(s1, s2);\r
-                                                       comparable.map(s1, s2);\r
+                                                       comparableStatements.map(s1, s2);\r
+                                                       comparableResources.map(s1.getObject(),s2.getObject());\r
                                                }\r
                                        } else {\r
                                                compareProps(s1.getObject(), s2.getObject());\r
                                        }\r
                                } else {\r
-                                       //changes1.add(s1);\r
-                                       //changes2.add(s2);\r
                                        addModification(s1, s2);\r
-                                       comparable.map(s1, s2);\r
+                                       comparableStatements.map(s1, s2);\r
+                                       comparableResources.map(s1.getObject(),s2.getObject());\r
                                }\r
                                i1++;\r
                                i2++;\r
@@ -519,99 +614,24 @@ public class GraphComparator {
                \r
        }\r
        \r
-       private int propsDiffCount(Resource r1, Resource r2) throws ServiceException, DoesNotContainValueException, ValidationException {\r
-               ArrayList<Statement> ss1 = new ArrayList<Statement>();\r
-               ArrayList<Statement> ss2 = new ArrayList<Statement>();\r
-               ss1.addAll(g.getStatements(r1, b.HasProperty));\r
-               ss2.addAll(g.getStatements(r2, b.HasProperty));\r
-               //System.out.println("Props count " + GraphUtils.getReadableName(g, r1) + " " + GraphUtils.getReadableName(g, r2));\r
-               Collections.sort(ss1, scomp);\r
-               Collections.sort(ss2, scomp);\r
-               \r
-               int count = 0;\r
-               \r
-               int i1 = 0; \r
-               int i2 = 0;\r
-               \r
-               while (true) {\r
-                       if (i1 >= ss1.size()) {\r
-                               if (i2 >= ss2.size())\r
-                                       break;\r
-                               else {\r
-                                       while (i2 < ss2.size()) {\r
-                                               count++;\r
-                                               i2++;\r
-                                       }\r
-                                       break;\r
-                               }\r
-                       } else if (i2 >= ss2.size()) {\r
-                               while (i1 < ss1.size()) {\r
-                                       count++;\r
-                                       i1++;\r
-                               }\r
-                               break;\r
-                       }\r
-                       Statement s1 = ss1.get(i1);\r
-                       Statement s2 = ss2.get(i2);\r
-                       int c = scomp.compare(s1, s2);\r
-                       switch (c) {\r
-                               case 0:{\r
-                                       boolean b1 = g.hasValue(s1.getObject());\r
-                                       boolean b2 = g.hasValue(s2.getObject());\r
-                                       if (b1 == b2) {\r
-                                               if (b1) {\r
-                                                       Object v1 = g.getValue(s1.getObject());\r
-                                                       Object v2 = g.getValue(s2.getObject());\r
-                                                       boolean eq = false;\r
-                                                       if (v1 instanceof Object[] && v2 instanceof Object[])\r
-                                                               eq = Arrays.deepEquals((Object[])v1, (Object[])v2);\r
-                                                       else if (v1 instanceof int[] && v2 instanceof int[]) \r
-                                                               eq = Arrays.equals((int[])v1, (int[])v2);\r
-                                                       else if (v1 instanceof float[] && v2 instanceof float[]) \r
-                                                               eq = Arrays.equals((float[])v1, (float[])v2);\r
-                                                       else if (v1 instanceof double[] && v2 instanceof double[]) \r
-                                                               eq = Arrays.equals((double[])v1, (double[])v2);\r
-                                                       else if (v1 instanceof long[] && v2 instanceof long[]) \r
-                                                               eq = Arrays.equals((long[])v1, (long[])v2);\r
-                                                       else if (v1 instanceof byte[] && v2 instanceof byte[]) \r
-                                                               eq = Arrays.equals((byte[])v1, (byte[])v2);\r
-                                                       else if (v1 instanceof boolean[] && v2 instanceof boolean[]) \r
-                                                               eq = Arrays.equals((boolean[])v1, (boolean[])v2);\r
-                                                       else\r
-                                                               eq = v1.equals(v2);\r
-                                                       if (!eq) {\r
-                                                               count++;\r
-                                                       }\r
-                                                       //System.out.println("Prop count values " + v1 + " " + v2);\r
-                                               } else {\r
-                                                       count += propsDiffCount(s1.getObject(), s2.getObject());\r
-                                               }\r
-                                       } else {\r
-                                               //System.out.println("Props count structural vs literal");\r
-                                               count++;\r
-                                       }\r
-                                       i1++;\r
-                                       i2++;\r
-                                       break;\r
-                               }\r
-                               case -1:{\r
-                                       count++;\r
-                                       i1++;\r
-                                       break;\r
-                               }\r
-                                       \r
-                               case 1:{\r
-                                       count++;\r
-                                       i2++;\r
-                                       break;\r
-                               }\r
-                       }\r
-\r
-               }\r
-               \r
-               ss1.clear();\r
-               ss2.clear();\r
-               return count;\r
+       \r
+       public static boolean compareValue(Object v1, Object v2) {\r
+               if (v1 instanceof Object[] && v2 instanceof Object[])\r
+                       return Arrays.deepEquals((Object[])v1, (Object[])v2);\r
+               else if (v1 instanceof int[] && v2 instanceof int[]) \r
+                       return Arrays.equals((int[])v1, (int[])v2);\r
+               else if (v1 instanceof float[] && v2 instanceof float[]) \r
+                       return Arrays.equals((float[])v1, (float[])v2);\r
+               else if (v1 instanceof double[] && v2 instanceof double[]) \r
+                       return Arrays.equals((double[])v1, (double[])v2);\r
+               else if (v1 instanceof long[] && v2 instanceof long[]) \r
+                       return  Arrays.equals((long[])v1, (long[])v2);\r
+               else if (v1 instanceof byte[] && v2 instanceof byte[]) \r
+                       return Arrays.equals((byte[])v1, (byte[])v2);\r
+               else if (v1 instanceof boolean[] && v2 instanceof boolean[]) \r
+                       return Arrays.equals((boolean[])v1, (boolean[])v2);\r
+               else\r
+                       return v1.equals(v2);\r
        }\r
 \r
        \r
@@ -619,6 +639,8 @@ public class GraphComparator {
        public class PredicateComparator implements Comparator<Statement> {\r
                @Override\r
                public int compare(Statement o1, Statement o2) {\r
+                       if (comparableResources.contains(o1.getPredicate(), o2.getPredicate()))\r
+                               return 0;\r
                        if (o1.getPredicate().getResourceId() < o2.getPredicate().getResourceId())\r
                                return -1;\r
                        if (o1.getPredicate().getResourceId() > o2.getPredicate().getResourceId())\r
@@ -627,7 +649,7 @@ public class GraphComparator {
                }\r
        }\r
        \r
-       public class FullStatementComparator implements Comparator<Statement> {\r
+       public static class FullStatementComparator implements Comparator<Statement> {\r
                @Override\r
                public int compare(Statement o1, Statement o2) {\r
                        if (o1.getSubject().getResourceId() < o2.getSubject().getResourceId())\r
@@ -651,6 +673,8 @@ public class GraphComparator {
        public class ResourceComparator implements Comparator<Resource> {\r
                @Override\r
                public int compare(Resource o1, Resource o2) {\r
+                       if (comparableResources.contains(o1, o2))\r
+                               return 0;\r
                        if (o1.getResourceId() < o2.getResourceId())\r
                                return -1;\r
                        if (o1.getResourceId() > o2.getResourceId())\r
@@ -658,4 +682,6 @@ public class GraphComparator {
                        return 0;\r
                }\r
        }\r
+       \r
+       \r
 }\r