]> gerrit.simantics Code Review - simantics/3d.git/blobdiff - org.simantics.plant3d/src/org/simantics/plant3d/dialog/ComponentSelectionDialog.java
Expand by default when only one group exists in the Add Component dialog
[simantics/3d.git] / org.simantics.plant3d / src / org / simantics / plant3d / dialog / ComponentSelectionDialog.java
index df00bc39f468804efcde3b91afa6d133087c1000..cfd8c861dbc7d578f9f7e7ee39eaad13a9014e63 100644 (file)
@@ -3,6 +3,7 @@ package org.simantics.plant3d.dialog;
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.List;
+import java.util.ListIterator;
 import java.util.Set;
 
 import org.eclipse.jface.dialogs.Dialog;
@@ -42,6 +43,7 @@ import org.simantics.plant3d.ontology.Plant3D;
 import org.simantics.plant3d.scenegraph.EndComponent;
 import org.simantics.plant3d.scenegraph.InlineComponent;
 import org.simantics.plant3d.scenegraph.Nozzle;
+import org.simantics.plant3d.scenegraph.PipeRun;
 import org.simantics.plant3d.scenegraph.PipelineComponent;
 import org.simantics.plant3d.scenegraph.TurnComponent;
 import org.simantics.plant3d.scenegraph.controlpoint.PipeControlPoint.PositionType;
@@ -139,6 +141,23 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                        insertPosition = PositionType.PREVIOUS;
        }
        
+       private void copyPipeRunParameters() {
+               PipeRun run = component.getPipeRun();
+               if (component.getNext() == null && component.getAlternativePipeRun() != null)
+                       run = component.getAlternativePipeRun();
+               
+               if (run == null)
+                       return;
+               
+               diameter = run.getPipeDiameter();
+               thickness = run.getPipeThickness();
+               turnRadius = run.getTurnRadius();
+               
+               diameterText.setText(Double.toString(diameter * lengthFactor));
+               thicknessText.setText(Double.toString(thickness * lengthFactor));
+               turnRadiusText.setText(Double.toString(turnRadius * lengthFactor));
+       }
+
        public void setLengthFactor(double lengthFactor) {
                this.lengthFactor = lengthFactor;
        }
@@ -215,43 +234,41 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
 
                ExpandBar expandBar = new ExpandBar(composite, SWT.V_SCROLL);
 
-               ExpandItem inlineItem = new ExpandItem(expandBar, SWT.NONE);
-               inlineItem.setText("Inline");
-               inlineViewer = new ListViewer(expandBar);
-               inlineViewer.setLabelProvider(new ComponentLabelProvider());
-               inlineViewer.setContentProvider(new ComponentContentProvider());
-
-               ExpandItem turnItem = new ExpandItem(expandBar, SWT.NONE);
-               turnItem.setText("Turn");
-               turnViewer = new ListViewer(expandBar);
-               turnViewer.setLabelProvider(new ComponentLabelProvider());
-               turnViewer.setContentProvider(new ComponentContentProvider());
-
-               ExpandItem endItem = new ExpandItem(expandBar, SWT.NONE);
-               endItem.setText("End");
-               endViewer = new ListViewer(expandBar);
-               endViewer.setLabelProvider(new ComponentLabelProvider());
-               endViewer.setContentProvider(new ComponentContentProvider());
-
-               inlineItem.setControl(inlineViewer.getList());
-               turnItem.setControl(turnViewer.getList());
-               endItem.setControl(endViewer.getList());
-
-               inlineViewer.setInput(inlines);
-               turnViewer.setInput(turns);
-               endViewer.setInput(ends);
-
-               inlineItem.setHeight(inlineViewer.getList().computeSize(SWT.DEFAULT, SWT.DEFAULT).y);
-               turnItem.setHeight(turnViewer.getList().computeSize(SWT.DEFAULT, SWT.DEFAULT).y);
-               endItem.setHeight(endViewer.getList().computeSize(SWT.DEFAULT, SWT.DEFAULT).y);
+               boolean isOpen = component.getNext() == null || component.getPrevious() == null;
+               if (!inlines.isEmpty()) {
+                       if (!isOpen) {
+                               // Remove variable length pipe from options
+                               ListIterator<Item> it = inlines.listIterator();
+                               while (it.hasNext()) {
+                                       Item item = it.next();
+                                       if (item.isVariable())
+                                               it.remove();
+                               }
+                       }
+                       
+                       inlineViewer = createItemList(expandBar, inlines, "Inline");
+               }
 
-               inlineViewer.addSelectionChangedListener(this);
-               turnViewer.addSelectionChangedListener(this);
-               endViewer.addSelectionChangedListener(this);
+               // Only allow elbows and ends to be added to open ends of the pipelines
+               if (isOpen) {
+                       if (!turns.isEmpty()) {
+                               turnViewer = createItemList(expandBar, turns, "Elbow");
+                       }
+                       
+                       if (!ends.isEmpty()) {
+                               turnViewer = createItemList(expandBar, ends, "End");
+                       }
+               }
 
                GridDataFactory.fillDefaults().grab(true, true).align(SWT.FILL, SWT.FILL).span(2, 1).applyTo(expandBar);
                GridDataFactory.fillDefaults().grab(true, true).minSize(500, 500).hint(500, 500).applyTo(composite);
 
+               // If there is only one item in the ExpandBar, expand it by default to avoid unnecessary clicks
+               ExpandItem[] expandBarItems = expandBar.getItems();
+               if (expandBarItems.length == 1) {
+                       expandBarItems[0].setExpanded(true);
+               }
+
                Label label = new Label(composite, SWT.NONE);
                label.setText("Position");
                Composite buttonComposite = new Composite(composite, SWT.NONE);
@@ -297,6 +314,11 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                                updateInsertPosition(PositionType.NEXT);
                        }
                });
+               
+               if (!hasInsertPosition()) {
+                       label.setVisible(false);
+                       buttonComposite.setVisible(false);
+               }
 
                label = new Label(composite, SWT.NONE);
                label.setText("Name");
@@ -319,7 +341,7 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                label.setText("Wall thickness");
                thicknessText = new Text(composite, SWT.SINGLE | SWT.BORDER);
                label = new Label(composite, SWT.NONE);
-               label.setText("Turn radius");
+               label.setText("Elbow radius");
                turnRadiusText = new Text(composite, SWT.SINGLE | SWT.BORDER);
                
                validationLabel = new Label(composite, SWT.NONE);
@@ -332,6 +354,8 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                diameterText.setEnabled(false);
                thicknessText.setEnabled(false);
 
+               copyPipeRunParameters();
+
                nameText.addKeyListener(new KeyAdapter() {
                        @Override
                        public void keyReleased(KeyEvent e) {
@@ -431,6 +455,24 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                return composite;
        }
 
+       private ListViewer createItemList(ExpandBar expandBar, List<Item> items, String name) {
+               ExpandItem expandItem = new ExpandItem(expandBar, SWT.NONE);
+               expandItem.setText(name);
+               ListViewer viewer = new ListViewer(expandBar);
+               viewer.setLabelProvider(new ComponentLabelProvider());
+               viewer.setContentProvider(new ComponentContentProvider());
+               
+               expandItem.setControl(viewer.getList());
+               viewer.setInput(items);
+               expandItem.setHeight(viewer.getList().computeSize(SWT.DEFAULT, SWT.DEFAULT).y);
+               viewer.addSelectionChangedListener(this);
+               return viewer;
+       }
+
+       private boolean hasInsertPosition() {
+               return component.getNext() == null || component.getPrevious() == null;
+       }
+
        private void updateInsertPosition(PositionType type) {
                if (insertPosition == type)
                        return;
@@ -446,15 +488,15 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                Item i = (Item) sel.getFirstElement();
                if (i != null) {
                        selected = i;
-                       if (event.getSource() == inlineViewer) {
-                               turnViewer.setSelection(new StructuredSelection());
-                               endViewer.setSelection(new StructuredSelection());
-                       } else if (event.getSource() == turnViewer) {
-                               inlineViewer.setSelection(new StructuredSelection());
-                               endViewer.setSelection(new StructuredSelection());
-                       } else if (event.getSource() == endViewer) {
-                               inlineViewer.setSelection(new StructuredSelection());
-                               turnViewer.setSelection(new StructuredSelection());
+                       if (inlineViewer != null && event.getSource() == inlineViewer) {
+                               clearSelection(turnViewer);
+                               clearSelection(endViewer);
+                       } else if (turnViewer != null && event.getSource() == turnViewer) {
+                               clearSelection(inlineViewer);
+                               clearSelection(endViewer);
+                       } else if (endViewer != null && event.getSource() == endViewer) {
+                               clearSelection(inlineViewer);
+                               clearSelection(turnViewer);
                        }
                        
                        name = generateUniqueName(selected.getName());
@@ -464,6 +506,11 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                }
        }
 
+       private void clearSelection(ListViewer possibleListViewer) {
+               if (possibleListViewer != null)
+                       possibleListViewer.setSelection(new StructuredSelection());
+       }
+
        private void validate() {
                filterAllowed.clear();
                Set<PositionType> filterAllowed = new HashSet<PositionType>();
@@ -488,7 +535,7 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                        lenghtAdjustable = ((selected.getType() == Type.INLINE)
                                        && (selected.isVariable() || selected.isModifiable()));
                        
-                       if (component.getNext() != null && component.getPrevious() != null) {
+                       if (!hasInsertPosition()) {
                                // We are inserting to a fully connected variable length component
                                // only allow insertion within the component
                                startButton.setEnabled(false);
@@ -615,6 +662,7 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
                        } else {
                                turnRadiusText.setEnabled(false);
                                diameterText.setEnabled(false);
+                               thicknessText.setEnabled(false);
                        }
 
                        if (!selected.isVariable()) {