]> gerrit.simantics Code Review - simantics/3d.git/blobdiff - org.simantics.plant3d/src/org/simantics/plant3d/scenegraph/controlpoint/PipingRules.java
Piping rules seemed to be executed while editor was loading data
[simantics/3d.git] / org.simantics.plant3d / src / org / simantics / plant3d / scenegraph / controlpoint / PipingRules.java
index 386cc56a211d3245d6bb07137550d538d31a50f6..6c121d80857da7b7c920c37f73d774b14d191b62 100644 (file)
@@ -51,32 +51,37 @@ public class PipingRules {
        private static Object ruleMutex = new Object();
        
        public static void requestUpdate(PipeControlPoint pcp) {
+           if (!PipingRules.enabled)
+               return;
                if (DEBUG) System.out.println("PipingRules request " + pcp);
                synchronized (updateMutex) {
-                   if (!requestUpdates.contains(pcp))
-                       requestUpdates.add(pcp);
+                       if (!requestUpdates.contains(pcp))
+                               requestUpdates.add(pcp);
                }
        }
        
        public static boolean update() throws Exception {
+           if (!PipingRules.enabled)
+               return false;
+           
                if (requestUpdates.size() == 0)
                        return false;
                
                List<PipeControlPoint> temp = new ArrayList<PipeControlPoint>(requestUpdates.size());
                synchronized(updateMutex) {
-                   temp.addAll(requestUpdates);
-               requestUpdates.clear();
+                       temp.addAll(requestUpdates);
+                       requestUpdates.clear();
                }
                synchronized (ruleMutex) {
-                   currentUpdates.clear();
-                   currentUpdates.addAll(temp);
-                   // TODO : we should remove already processed control points from currentUpdates after each _positionUpdate call.
-                   for (PipeControlPoint pcp : currentUpdates)
-                   _positionUpdate(pcp, true);
-                   currentUpdates.clear();
-        }
+                       currentUpdates.clear();
+                       currentUpdates.addAll(temp);
+                       // TODO : we should remove already processed control points from currentUpdates after each _positionUpdate call.
+                       for (PipeControlPoint pcp : currentUpdates)
+                               _positionUpdate(pcp, true);
+                       currentUpdates.clear();
+               }
                synchronized(updateMutex) {
-                   requestUpdates.removeAll(temp);
+                       requestUpdates.removeAll(temp);
                }
                
                return true;
@@ -88,13 +93,13 @@ public class PipingRules {
        }
        
        public static boolean positionUpdate(PipeControlPoint pcp, boolean allowIR) throws Exception {
-           synchronized (ruleMutex) {
-           currentUpdates.add(pcp);
-           boolean b = _positionUpdate(pcp, allowIR);
-           currentUpdates.clear();
-           return b;
-           }
-           
+               synchronized (ruleMutex) {
+                       currentUpdates.add(pcp);
+                       boolean b = _positionUpdate(pcp, allowIR);
+                       currentUpdates.clear();
+                       return b;
+               }
+               
        }
        
        private static boolean _positionUpdate(PipeControlPoint pcp, boolean allowIR) throws Exception {
@@ -296,41 +301,35 @@ public class PipingRules {
        }
 
        private static void updatePathLegNext(PipeControlPoint start, PipeControlPoint updated, PathLegUpdateType lengthChange) throws Exception {
-               ArrayList<PipeControlPoint> list = new ArrayList<PipeControlPoint>();
-               PipeControlPoint end = start.findNextEnd(list);
-               // this is for inline cp that is also path leg end
+
+               UpdateStruct2 us = createUS(start, Direction.NEXT, 0, new ArrayList<ExpandIterInfo>(), updated);
                if (lengthChange == PathLegUpdateType.NONE) {
                        if (start.equals(updated))
                                lengthChange = PathLegUpdateType.NEXT;
-                       else if (end.equals(updated))
+                       else if (us.end.equals(updated))
                                lengthChange = PathLegUpdateType.PREV;
                }
-               updatePathLegNext(start, list, end, updated, lengthChange);
-       }
-
-       private static void updatePathLegNext(PipeControlPoint start, ArrayList<PipeControlPoint> list, PipeControlPoint end, PipeControlPoint updated, PathLegUpdateType lengthChange) throws Exception {
-               updatePathLeg(start, list, end, false, 0, new ArrayList<ExpandIterInfo>(), updated, lengthChange);
+               if (us == null) {
+                   System.out.println("Null update struct " + start);
+                   return; 
+               }
+               updatePathLeg(us, lengthChange);
        }
        
        private static void updatePathLegPrev(PipeControlPoint start, PipeControlPoint updated, PathLegUpdateType lengthChange) throws Exception {
-               ArrayList<PipeControlPoint> list = new ArrayList<PipeControlPoint>();
-               PipeControlPoint end = start.findPreviousEnd(list);
                // TODO: this method is not symmetric with updatePathLegNext, which may alter lengthChange parameter?
-               updatePathLegPrev(start, list, end, updated, lengthChange);
-       }
-
-       private static void updatePathLegPrev(PipeControlPoint start, ArrayList<PipeControlPoint> list, PipeControlPoint end, PipeControlPoint updated, PathLegUpdateType lengthChange) throws Exception {
-               // reverses the list
-               ArrayList<PipeControlPoint> nextList = new ArrayList<PipeControlPoint>();
-               for (PipeControlPoint icp : list) {
-                       if (icp.isDualSub()) {
-                               nextList.add(0, icp.getParentPoint());
-                       } else {
-                               nextList.add(0, icp);
-                       }
-               }
-               updatePathLeg(end, nextList, start, true, 0, new ArrayList<ExpandIterInfo>(), updated, lengthChange);
-
+               UpdateStruct2 us = createUS(start, Direction.PREVIOUS, 0, new ArrayList<ExpandIterInfo>(), updated);
+//        if (lengthChange == PathLegUpdateType.NONE) {
+//            if (start.equals(updated))
+//                lengthChange = PathLegUpdateType.NEXT;
+//            else if (us.end.equals(updated))
+//                lengthChange = PathLegUpdateType.PREV;
+//        }
+               if (us == null) {
+            System.out.println("Null update struct " + start);
+            return; 
+        }
+               updatePathLeg(us, lengthChange);
        }
 
        private static class UpdateStruct2 {
@@ -425,60 +424,54 @@ public class PipingRules {
                        hasOffsets = true;
                }
                
-//             for (PipeControlPoint icp : list) {
-//                     if (icp.isOffset()) {
-//                             icp.setOffset(((InlineComponent)icp.getPipelineComponent()).getOffset());
-//                             hasOffsets = true;
-//                             Vector3d v = icp.getSizeChangeOffsetVector(dir);
-//                             offset.add(v);
-//                     } else if (icp.isDualSub())
-//                             ErrorLogger.defaultLogError("Updating pipe run, found offset controlpoint " + icp, new Exception("ASSERT!"));
-//             }
                if (DEBUG && hasOffsets)
                        System.out.println("calcOffset s:"+ startPoint + " e:" + endPoint + " d:" + dir + " o:"+offset) ;
                return hasOffsets;
        }
-
-       /**
-        * @param start
-        *            starting point of the pipe run
-        * @param list
-        *            list of inline control points in the pipe run
-        * @param end
-        *            ending point of the pipe run
-        * @param reversed
-        *            boolean flag indicating wether start or end control point was
-        *            modified (if true then end point was modified)
-        * @throws TransactionException
-        */
-       private static void updatePathLeg(PipeControlPoint start, ArrayList<PipeControlPoint> list, PipeControlPoint end, boolean reversed, int iter, ArrayList<ExpandIterInfo> toRemove, PipeControlPoint updated, PathLegUpdateType lengthChange) throws Exception {
+       
+       private static UpdateStruct2 createUS(PipeControlPoint start, Direction direction, int iter, ArrayList<ExpandIterInfo> toRemove, PipeControlPoint updated) {
+               ArrayList<PipeControlPoint> list = new ArrayList<PipeControlPoint>();
+               PipeControlPoint end = null;
+               if (direction == Direction.NEXT) {
+                       end = start.findNextEnd(list);
+               } else {
+                       ArrayList<PipeControlPoint> prevList = new ArrayList<PipeControlPoint>();
+                       PipeControlPoint tend = start.findPreviousEnd(prevList);
+                       for (PipeControlPoint icp : prevList) {
+                               if (icp.isDualSub()) {
+                                       list.add(0, icp.getParentPoint());
+                               } else {
+                                       list.add(0, icp);
+                               }
+                       }  
+                       end = start;
+                       start = tend;
+               }
                if (start == end)
-                       return;
-               // FIXME: direction is calculated wrong way!
+                       return null;
                boolean hasOffsets = false;
                Vector3d offset = new Vector3d();
                Vector3d startPoint = start.getWorldPosition();
                Vector3d endPoint = end.getWorldPosition();
                Vector3d dir = new Vector3d();
                hasOffsets = calculateOffset(startPoint, endPoint, list, dir, offset);
-               updatePathLeg(new UpdateStruct2(start, startPoint, list, end, endPoint, dir, offset, hasOffsets, iter, reversed, toRemove, updated), lengthChange);
-
+               return new UpdateStruct2(start, startPoint, list, end, endPoint, dir, offset, hasOffsets, iter, direction == Direction.PREVIOUS, toRemove, updated);
        }
        
        private static boolean asDirected(PipeControlPoint pcp, Direction direction) {
-           if (pcp.isDirected())
-               return true;
-           if (pcp.isTurn() && pcp.isFixed()) {
-              if (!pcp._getReversed())
-                  return direction == Direction.NEXT;
-              else
-                  return direction == Direction.PREVIOUS;
-           }
-           return false;
+               if (pcp.isDirected())
+                       return true;
+               if (pcp.isTurn() && pcp.isFixed()) {
+                       if (!pcp._getReversed())
+                               return direction == Direction.NEXT;
+                       else
+                               return direction == Direction.PREVIOUS;
+               }
+               return false;
        }
        
        private static Vector3d direction(PipeControlPoint pcp, Direction direction) {
-           return pcp.getDirection(direction);
+               return pcp.getDirection(direction);
        }
  
        private static void updatePathLeg(UpdateStruct2 u, PathLegUpdateType lengthChange) throws Exception {
@@ -613,8 +606,8 @@ public class PipingRules {
                                PipeControlPoint icp = pathLegPoints.get(i);
 
                                PipeControlPoint prev = i > 0 ? pathLegPoints.get(i - 1) : null;
-                PipeControlPoint next = i < pathLegPoints.size() - 1 ? pathLegPoints.get(i + 1) : null;
-                
+                               PipeControlPoint next = i < pathLegPoints.size() - 1 ? pathLegPoints.get(i + 1) : null;
+                               
                                if (prev != null && prev.isDualInline())
                                        prev = prev.getSubPoint().get(0);
                                
@@ -730,49 +723,49 @@ public class PipingRules {
        }
        
        private static void updateVariableLengthEnd(PipeControlPoint icp,  PipeControlPoint prev) {
-           Vector3d currentPos = icp.getWorldPosition();
-        Vector3d prevPos = prev.getWorldPosition();
-        
-        Vector3d dir = new Vector3d();
-        dir.sub(currentPos, prevPos);
-        
-           boolean simple = currentUpdates.contains(icp);
-           if (simple) {
-               // Update based on position -> adjust length
-               double currentLength = (dir.length() - prev.getInlineLength()) * 2.0;
-               icp.setLength(currentLength);
-           } else {
-               // Update based on neighbour movement -> adjust length and position, so that free end stays in place.
-               double currentLength = icp.getLength();
-               if (currentLength < MathTools.NEAR_ZERO) {
-                       currentLength = (dir.length() - prev.getInlineLength()) * 2.0;
-               }
-               
-               if (dir.lengthSquared() > MathTools.NEAR_ZERO)
-                       dir.normalize();
-               Point3d endPos = new Point3d(dir);
-               endPos.scale(currentLength * 0.5);
-               endPos.add(currentPos); // this is the free end of the component
-    
-               double offset = prev.getInlineLength();
-               Point3d beginPos = new Point3d(dir);
-               beginPos.scale(offset);
-               beginPos.add(prevPos); // this is the connected end of the component
-    
-               double l = beginPos.distance(endPos);
-               
-               if (Double.isNaN(l))
-                       System.out.println("Length for " + icp + " is NaN");
-    
-               dir.scale(l * 0.5);
-               beginPos.add(dir); // center position
-    
-               if (DEBUG)
-                       System.out.println("PipingRules.updateInlineControlPoints() setting variable length to " + l);
-               icp.setLength(l);
-    
-               icp.setWorldPosition(new Vector3d(beginPos));
-           }
+               Vector3d currentPos = icp.getWorldPosition();
+               Vector3d prevPos = prev.getWorldPosition();
+               
+               Vector3d dir = new Vector3d();
+               dir.sub(currentPos, prevPos);
+               
+               boolean simple = currentUpdates.contains(icp);
+               if (simple) {
+                       // Update based on position -> adjust length
+                       double currentLength = (dir.length() - prev.getInlineLength()) * 2.0;
+                       icp.setLength(currentLength);
+               } else {
+                       // Update based on neighbour movement -> adjust length and position, so that free end stays in place.
+                       double currentLength = icp.getLength();
+                       if (currentLength < MathTools.NEAR_ZERO) {
+                               currentLength = (dir.length() - prev.getInlineLength()) * 2.0;
+                       }
+                       
+                       if (dir.lengthSquared() > MathTools.NEAR_ZERO)
+                               dir.normalize();
+                       Point3d endPos = new Point3d(dir);
+                       endPos.scale(currentLength * 0.5);
+                       endPos.add(currentPos); // this is the free end of the component
+       
+                       double offset = prev.getInlineLength();
+                       Point3d beginPos = new Point3d(dir);
+                       beginPos.scale(offset);
+                       beginPos.add(prevPos); // this is the connected end of the component
+       
+                       double l = beginPos.distance(endPos);
+                       
+                       if (Double.isNaN(l))
+                               System.out.println("Length for " + icp + " is NaN");
+       
+                       dir.scale(l * 0.5);
+                       beginPos.add(dir); // center position
+       
+                       if (DEBUG)
+                               System.out.println("PipingRules.updateInlineControlPoints() setting variable length to " + l);
+                       icp.setLength(l);
+       
+                       icp.setWorldPosition(new Vector3d(beginPos));
+               }
        }
 
        private static void ppNoOffset(UpdateStruct2 u) throws Exception {
@@ -853,11 +846,12 @@ public class PipingRules {
 
                Vector3d directedDirection = direction(dcp, dcpStart ? Direction.NEXT : Direction.PREVIOUS);
                if (directedDirection == null) {
-                   updateTurnControlPointTurn(dcp, dcp.getPrevious(), dcp.getNext());
-                   directedDirection = direction(dcp, dcpStart ? Direction.NEXT : Direction.PREVIOUS);
-                   if (directedDirection == null) {
-                       return;
-                   }
+                       //updateTurnControlPointTurn(dcp, dcp.getPrevious(), dcp.getNext());
+                       updateTurnControlPointTurn(dcp, null, null);
+                       directedDirection = direction(dcp, dcpStart ? Direction.NEXT : Direction.PREVIOUS);
+                       if (directedDirection == null) {
+                               return;
+                       }
                }
                Point3d directedEndPoint = new Point3d(u.endPoint);
                if (u.hasOffsets)
@@ -879,8 +873,8 @@ public class PipingRules {
                double distance = t.length();
                boolean aligned = (distance < ALLOWED_OFFSET);
                if (aligned) {
-                   if (u.start.isInline() || u.end.isInline() || u.start.isFixed() || u.end.isFixed())
-                   processPathLeg(u, true, false);
+                       if (u.start.isInline() || u.end.isInline() || u.start.isFixed() || u.end.isFixed())
+                               processPathLeg(u, true, false);
                        checkExpandPathLeg(u, lengthChange, inlineEnd);
                        
                } else {
@@ -901,14 +895,15 @@ public class PipingRules {
                                if (other.isVariableAngle()) {
 
                                        // TODO calculate needed space from next run end.
-                                       if (mu[0] < 1.0) {
+                                   double space = spaceForTurn(other);
+                                       if (mu[0] < space) {
                                                if (dcpStart) {
                                                        closest.set(u.startPoint);
                                                } else {
                                                        closest.set(u.endPoint);
                                                }
                                                Vector3d v = new Vector3d(directedDirection);
-                                               v.scale(spaceForTurn(other));
+                                               v.scale(space);
                                                closest.add(v);
                                        }
 
@@ -1030,7 +1025,7 @@ public class PipingRules {
                                p1 = dcp.getWorldPosition();
                                Vector3d v = new Vector3d();
                                if (!u.reversed)
-                                   v.set(dir1);
+                                       v.set(dir1);
                                else
                                        v.set(dir2);
                                
@@ -1047,7 +1042,7 @@ public class PipingRules {
                                // By default, the elbows are placed next to each other, by using 90 deg angles.
                                // If the distance between elbows is not enough, we must move the other elbow (and create more shallow angle elbows)
                                if (MathTools.distance(p1, p2) < off*2.05) {
-                                   p2.add(v);
+                                       p2.add(v);
                                }
                                
                                PipeControlPoint tcp1 = insertElbow(dcp, next, p1);
@@ -1148,15 +1143,7 @@ public class PipingRules {
                        // this won't work properly if inline control points are not updated
                        PipeControlPoint startPrev = u.start.getPrevious();
                        if (startPrev != null) {
-                               double a;
-                               if (!u.hasOffsets) {
-                                       a = updateTurnControlPointTurn(u.start, startPrev, u.end);
-                               } else {
-                                       Vector3d ep = new Vector3d(u.endPoint);
-                                       ep.sub(u.offset);
-                                       a = updateTurnControlPointTurn(u.start, u.startPoint, startPrev.getPosition(), ep);
-
-                               }
+                               double a = updateTurnControlPointTurn(u.start, null, u.dir);
                                if (a < MIN_TURN_ANGLE && u.start.isDeletable())
                                        startRemoved = true;
                                else if (lengthChange == PathLegUpdateType.PREV || lengthChange == PathLegUpdateType.PREV_S) {
@@ -1173,14 +1160,8 @@ public class PipingRules {
 
                        PipeControlPoint endNext = u.end.getNext();
                        if (endNext != null) {
-                               double a;
-                               if (!u.hasOffsets) {
-                                       a = updateTurnControlPointTurn(u.end, u.start, endNext);
-                               } else {
-                                       Vector3d sp = new Vector3d(u.startPoint);
-                                       sp.add(u.offset);
-                                       a = updateTurnControlPointTurn(u.end, u.endPoint, sp, endNext.getPosition());
-                               }
+                               // TODO: u.end, u.dir, null
+                               double a = updateTurnControlPointTurn(u.end, null, null);
                                if (a < MIN_TURN_ANGLE && u.end.isDeletable())
                                        endRemoved = true;
                                else if (lengthChange == PathLegUpdateType.NEXT || lengthChange == PathLegUpdateType.NEXT_S) {
@@ -1347,7 +1328,8 @@ public class PipingRules {
                
                if (updateEnds) {
                        if (u.start.isTurn()) {
-                               updateTurnControlPointTurn(u.start, u.start.getPrevious(), u.start.getNext());
+                               //updateTurnControlPointTurn(u.start, u.start.getPrevious(), u.start.getNext());
+                               updateTurnControlPointTurn(u.start, null, null);
 //                             updatePathLegPrev(u.start, u.start, PathLegUpdateType.NONE);
                        } else if (u.start.isEnd()) {
                                updateEndComponentControlPoint(u.start, u.startPoint, u.endPoint);
@@ -1355,7 +1337,8 @@ public class PipingRules {
                                updateControlPointOrientation(u.start);
                        }
                        if (u.end.isTurn()) {
-                               updateTurnControlPointTurn(u.end, u.end.getPrevious(), u.end.getNext());
+                               //updateTurnControlPointTurn(u.end, u.end.getPrevious(), u.end.getNext());
+                               updateTurnControlPointTurn(u.end, null, null);
 //                             updatePathLegNext(u.end, u.end, PathLegUpdateType.NONE);
                        } else if (u.end.isEnd()) {
                                updateEndComponentControlPoint(u.end, u.startPoint, u.endPoint);
@@ -1568,113 +1551,88 @@ public class PipingRules {
                }
        }
 
-       /**
-        * Recalculates turn control point's internal data (turn angle and offset)
-        * 
-        * @param tcp
-        * @param prev
-        * @param next
-        */
-       private static double updateTurnControlPointTurn(PipeControlPoint tcp, PipeControlPoint prev, PipeControlPoint next) {
-               if (DEBUG)
-                       System.out.println("PipingTools.updateTurnControlPointTurn()" + tcp);
+       private static double updateTurnControlPointTurn(PipeControlPoint tcp, Vector3d prev, Vector3d next) {
+               if (next == null) {
+                       UpdateStruct2 us = createUS(tcp, Direction.NEXT, 0, new ArrayList<PipingRules.ExpandIterInfo>(), tcp);
+                       if (us != null)
+                               next = us.dir;
+               }
+               if (prev == null) {
+                       UpdateStruct2 us = createUS(tcp, Direction.PREVIOUS, 0, new ArrayList<PipingRules.ExpandIterInfo>(), tcp);
+                       if (us != null) {
+                               prev = us.dir;
+                       }
+               }
                
                if (!tcp.isFixed()) {
-                   if (next == null || prev == null)
-                   return tcp.getTurnAngle();
-               Vector3d middlePoint = tcp.getWorldPosition();
-               Vector3d nextPoint = next.getWorldPosition();
-               Vector3d prevPoint = prev.getWorldPosition();
-               return updateTurnControlPointTurn(tcp, middlePoint, prevPoint, nextPoint);
-               } else {
-                   // Verify that fixed turn is properly defined.
-                   // TODO : when reversed flag is changed, rotation angle should be recalculated, otherwise the orientation will change.
-                   // TODO : should reverse flag toggle to be done already when we are removing defining side?
-                   if (prev != null && next != null) {
-                       // Nothing to do
-                   } else if (prev == null) {
-                       if (!tcp._getReversed())
-                           tcp.setReversed(true);
-                   } else if (next == null) {
-                       if (tcp._getReversed())
-                           tcp.setReversed(false);
-                   }
-                   
-                   Vector3d dir;
-                   if (!tcp._getReversed()) {
-                   if (prev == null)
-                   return Math.PI; // FIXME : argh
-                   
-                   Vector3d middlePoint = tcp.getWorldPosition();
-                   Vector3d prevPoint = prev.getWorldPosition();
-                   dir = new Vector3d();
-                   dir.sub(middlePoint, prevPoint);        
-                  
-                   } else {
-                       if (next == null)
-                    return Math.PI; // FIXME : argh
-                
-                Vector3d middlePoint = tcp.getWorldPosition();
-                Vector3d nextPoint = next.getWorldPosition();
-                dir = new Vector3d();
-                dir.sub(middlePoint, nextPoint);
-                   }
-                   dir.normalize();
-            
-            Quat4d q = PipeControlPoint.getControlPointOrientationQuat(dir, tcp.getRotationAngle() != null ? tcp.getRotationAngle() : 0.0);
-            Vector3d v = new Vector3d();
-            MathTools.rotate(q, MathTools.Y_AXIS,v);
-            tcp.setTurnAxis(v);
-            tcp.setWorldOrientation(q);
-            return tcp.getTurnAngle();
-               }
-       }
-
-       /**
-        * Recalculates turn control point's internal data (turn angle and offset)
-        * 
-        * @param tcp
-        * @param middlePoint
-        * @param nextPoint
-        * @param prevPoint
-        */
-       private static double updateTurnControlPointTurn(PipeControlPoint tcp, Vector3d middlePoint, Vector3d prevPoint, Vector3d nextPoint) {
-
-               Vector3d dir1 = new Vector3d(middlePoint);
-               dir1.sub(prevPoint);
-               Vector3d dir2 = new Vector3d(nextPoint);
-               dir2.sub(middlePoint);
-               if (DEBUG)
-                       System.out.println("PipingTools.updateTurnControlPointTurn " + tcp + " " + prevPoint + " " + middlePoint + " " + nextPoint);
-               return updateTurnControlPointTurn(tcp, dir1, dir2);
-       }
-
-       private static double updateTurnControlPointTurn(PipeControlPoint tcp, Vector3d dir1, Vector3d dir2) {
-               double turnAngle = dir1.angle(dir2);
-
-               double angle = Math.PI - turnAngle;
-
-               Vector3d turnAxis = new Vector3d();
-               turnAxis.cross(dir1, dir2);
-               if (turnAxis.lengthSquared() > MathTools.NEAR_ZERO) {
-                       double elbowRadius = tcp.getPipelineComponent().getPipeRun().getTurnRadius();
-                       double R = elbowRadius / Math.tan(angle * 0.5);
                        
-                       turnAxis.normalize();
-                       tcp.setTurnAngle(turnAngle);
-                       tcp.setLength(R);// setComponentOffsetValue(R);
-                       tcp.setTurnAxis(turnAxis);
-//                     tcp.setPosition(tcp.getPosition());
+                       
+                       if (next == null || prev == null) {
+                               if (tcp.getTurnAngle() != null)
+                                       return tcp.getTurnAngle();
+                               return Math.PI; // FIXME : argh
+                       }
+                       double turnAngle = prev.angle(next);
+       
+                       double angle = Math.PI - turnAngle;
+       
+                       Vector3d turnAxis = new Vector3d();
+                       turnAxis.cross(prev, next);
+                       if (turnAxis.lengthSquared() > MathTools.NEAR_ZERO) {
+                               double elbowRadius = tcp.getPipelineComponent().getPipeRun().getTurnRadius();
+                               double R = elbowRadius / Math.tan(angle * 0.5);
+                               
+                               turnAxis.normalize();
+                               tcp.setTurnAngle(turnAngle);
+                               tcp.setLength(R);// setComponentOffsetValue(R);
+                               tcp.setTurnAxis(turnAxis);
+       //                      tcp.setPosition(tcp.getPosition());
+                       } else {
+                               turnAngle = 0.0;
+                               tcp.setTurnAngle(0.0);
+                               tcp.setLength(0.0);
+                               tcp.setTurnAxis(new Vector3d(MathTools.Y_AXIS));
+                       }
+                       
+                       updateControlPointOrientation(tcp);
+                       
+                       if (DEBUG)
+                               System.out.println("PipingTools.updateTurnControlPointTurn " + prev + " " + next + " " + turnAngle + " " + turnAxis);
+                       return turnAngle;
                } else {
-                       turnAngle = 0.0;
-                       tcp.setTurnAngle(0.0);
-                       tcp.setLength(0.0);
-                       tcp.setTurnAxis(new Vector3d(MathTools.Y_AXIS));
+                       
+                       if (prev != null && next != null) {
+                               // Nothing to do
+                       } else if (prev == null) {
+                               if (!tcp._getReversed())
+                                       tcp.setReversed(true);
+                       } else if (next == null) {
+                               if (tcp._getReversed())
+                                       tcp.setReversed(false);
+                       }
+                       
+                       Vector3d dir = null;
+                       if (!tcp._getReversed()) {
+                               dir = prev;
+                       } else {
+                               dir = next;
+                               dir.negate();
+                       }
+                       if (dir == null) {
+                               return Math.PI; // FIXME : argh
+                       }
+                       
+                       Quat4d q = PipeControlPoint.getControlPointOrientationQuat(dir, tcp.getRotationAngle() != null ? tcp.getRotationAngle() : 0.0);
+                       Vector3d v = new Vector3d();
+                       MathTools.rotate(q, MathTools.Y_AXIS,v);
+                       tcp.setTurnAxis(v);
+                       tcp.setWorldOrientation(q);
+                       if (tcp.getTurnAngle() != null)
+                               return tcp.getTurnAngle();
+                       return Math.PI; // FIXME : argh
                }
-               updateControlPointOrientation(tcp);
-               if (DEBUG)
-                       System.out.println("PipingTools.updateTurnControlPointTurn " + dir1 + " " + dir2 + " " + turnAngle + " " + turnAxis);
-               return turnAngle;
+               
+               
        }
        
        public static List<PipeControlPoint> getControlPoints(PipeRun pipeRun) {
@@ -1684,8 +1642,9 @@ public class PipingRules {
                PipeControlPoint pcp = pipeRun.getControlPoints().iterator().next();
                while (pcp.getPrevious() != null) {
                        PipeControlPoint prev = pcp.getPrevious();
-                       if (prev.getPipeRun() != pipeRun)
-                               break;
+                       if (prev.getPipeRun() != pipeRun && prev.getPipeRun() != null) { // bypass possible corruption
+                           break;
+                       }
                        pcp = prev;
                }
                if (pcp.isDualSub()) {
@@ -1702,7 +1661,63 @@ public class PipingRules {
        }
        
        public static void reverse(PipeRun pipeRun) {
-               List<PipeControlPoint> list = getControlPoints(pipeRun);
+               
+               while (true) {
+                       List<PipeControlPoint> points = getControlPoints(pipeRun);
+                       PipeControlPoint pcp = points.get(0);
+                       if (pcp.isSizeChange() && pcp.getSubPoint().size() > 0) {
+                               pipeRun = pcp.getPipeRun();
+                       } else {
+                               break;
+                       }
+               }
+               List<PipeRun> all = new ArrayList<PipeRun>();
+               List<List<PipeControlPoint>> pcps = new ArrayList<List<PipeControlPoint>>();
+               while (true) {
+                       all.add(pipeRun);
+                       List<PipeControlPoint> points = getControlPoints(pipeRun);
+                       pcps.add(points);
+                       PipeControlPoint pcp = points.get(points.size()-1);
+                       if (pcp.getSubPoint().size() > 0) {
+                               pipeRun = pcp.getSubPoint().get(0).getPipeRun();
+                       } else {
+                               break;
+                       }
+               }
+               for (int i = 0 ; i < all.size(); i++) {
+                       List<PipeControlPoint> list = pcps.get(i);
+                       _reverse(list);
+               }
+               for (int i = 0 ; i < all.size(); i++) {
+                       boolean last = i == all.size() - 1;
+                       List<PipeControlPoint> list = pcps.get(i);
+                       
+                       if (!last) {
+                               List<PipeControlPoint> list2 = pcps.get(i+1);
+                               PipeControlPoint prev = list.get(list.size()-1);
+                               PipeControlPoint next = list2.get(0);
+                               System.out.println();
+                               if (prev == next) {
+                                       // Reverse the component on the boundary.
+                                       InlineComponent ic = (InlineComponent)prev.getPipelineComponent();
+                                       PipeRun r1 = ic.getPipeRun();
+                                       PipeRun r2 = ic.getAlternativePipeRun();
+                                       if (r1 == null || r2 == null)
+                                               throw new RuntimeException("Components on PipeRun changes should refer to bot PipeRuns");
+                                       ic.deattach();
+                                       r2.addChild(ic);
+                                       ic.setPipeRun(r2);
+                                       ic.setAlternativePipeRun(r1);
+                               } else {
+                                       throw new RuntimeException("PipeRun changes should contain shared control points");
+                               }
+                               
+                       }
+               }
+                       
+       }
+       
+       private static void _reverse(List<PipeControlPoint> list) {
                if (list.size() <= 1)
                        return; // nothing to do.
                
@@ -1717,21 +1732,25 @@ public class PipingRules {
                                PipeControlPoint next = list.get(i+1);
                                if (next.isDualInline())
                                        next = next.getSubPoint().get(0);
-                               current.setNext(null);
+                               if (current.getNext() == next)
+                                       current.setNext(null);
                                current.setPrevious(next);
                                if (currentSub != null) {
-                                       currentSub.setNext(null);
-                                       currentSub.setPrevious(next);           
+                                       if (currentSub.getNext() == next)
+                                               currentSub.setNext(null);
+                                       currentSub.setPrevious(next);       
                                }
                        } else if (last) {
                                PipeControlPoint prev = list.get(i-1);
                                
-                               current.setPrevious(null);
+                               if (current.getPrevious() == prev)
+                                       current.setPrevious(null);
                                current.setNext(prev);
                                
                                if (currentSub != null) {
-                                       currentSub.setPrevious(null);
-                                       currentSub.setNext(prev);               
+                                       if (currentSub.getPrevious() == prev)
+                                               currentSub.setPrevious(null);
+                                       currentSub.setNext(prev);       
                                }
                        } else {
                                PipeControlPoint prev = list.get(i-1);
@@ -1745,15 +1764,15 @@ public class PipingRules {
                                
                                if (currentSub != null) {
                                        currentSub.setPrevious(next);
-                                       currentSub.setNext(prev);               
+                                       currentSub.setNext(prev);       
                                }
                                
                        }
                        if (current.isTurn() && current.isFixed()) {
-                           current.setReversed(!current._getReversed());
+                               current.setReversed(!current._getReversed());
                        }
                        if (current.isInline() && current.isReverse()) {
-                           current.setReversed(!current._getReversed());
+                               current.setReversed(!current._getReversed());
                        }   
                }
        }
@@ -1795,11 +1814,19 @@ public class PipingRules {
                }
                List<PipeControlPoint> runPcps = getControlPoints(pipeRun);
                if (runPcps.size() != count) {
-                       System.out.println("Run " + pipeRun.getName() + " contains unconnected control points");
+                       System.out.println("Run " + pipeRun.getName() + " contains unconnected control points, found " + runPcps.size() + " connected, " + pcps.size() + " total.");
+                       for (PipeControlPoint pcp : pcps) {
+                           if (!runPcps.contains(pcp)) {
+                               System.out.println("Unconnected " + pcp + " " + pcp.getPipelineComponent());
+                           }
+                       }
                }
                for (PipeControlPoint pcp : pcps) {
+                   if (pcp.getPipeRun() == null) {
+                       System.out.println("PipeRun ref missing " + pcp + " " + pcp.getPipelineComponent());
+                   }
                        if (!pcp.isDirected() && pcp.getNext() == null && pcp.getPrevious() == null)
-                               System.out.println("Orphan undirected " + pcp);
+                               System.out.println("Orphan undirected " + pcp + " " + pcp.getPipelineComponent());
                }
                for (PipeControlPoint pcp : pcps) {
                        if (pcp.getParentPoint() == null) {
@@ -1838,19 +1865,19 @@ public class PipingRules {
                
                /* there are many different cases to insert new component when
                   it splits existing VariableLengthinlineComponent.
-           
-              1. VariableLengthComponet is connected from both sides:
-                 - insert new component between VariableLength component and component connected to it
-                 - insert new VariableLengthComponent between inserted component and component selected in previous step
+               
+                  1. VariableLengthComponet is connected from both sides:
+                         - insert new component between VariableLength component and component connected to it
+                         - insert new VariableLengthComponent between inserted component and component selected in previous step
                
                   2. VariableLengthComponent is connected from one side
-                    - Use previous case or:
-                    - Insert new component to empty end
-                    - Insert new VariableLength component to inserted components empty end
-                    
+                        - Use previous case or:
+                        - Insert new component to empty end
+                        - Insert new VariableLength component to inserted components empty end
+                        
                   3. VariableLength is not connected to any component.
-                    - Should not be possible, at least in current implementation.
-                    - Could be done using second case
+                        - Should not be possible, at least in current implementation.
+                        - Could be done using second case
 
                */