X-Git-Url: https://gerrit.simantics.org/r/gitweb?a=blobdiff_plain;ds=inline;f=bundles%2Forg.simantics.scl.ui%2Fsrc%2Forg%2Fsimantics%2Fscl%2Fui%2Feditor2%2FOpenDeclaration.java;h=421328c164222346da2c9eb073f222afe841c601;hb=refs%2Fchanges%2F07%2F1407%2F3;hp=4b6818ab7b805587bfe6306a9f1154e48ac0e3ad;hpb=53072c542bfdb7646792fc338264f260f66b4bdf;p=simantics%2Fplatform.git diff --git a/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java b/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java index 4b6818ab7..421328c16 100644 --- a/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java +++ b/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java @@ -14,9 +14,13 @@ import org.simantics.scl.compiler.module.ModuleUtils; import org.simantics.scl.compiler.source.ModuleSource; import org.simantics.scl.osgi.SCLOsgi; import org.simantics.scl.ui.editor.completion.SCLTextEditorEnvironment; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class OpenDeclaration extends AbstractHandler { + private static final Logger LOGGER = LoggerFactory.getLogger(OpenDeclaration.class); + private static boolean isIdentifierPart(char c) { return Character.isJavaIdentifierPart(c) || c=='.'; } @@ -92,10 +96,10 @@ public class OpenDeclaration extends AbstractHandler { String moduleName = ModuleUtils.resolveAbsolutePath(input.getModuleName(), lineAtCaret.substring(p1+1, p2)); ModuleSource source = SCLOsgi.SOURCE_REPOSITORY.getModuleSource(moduleName, null); if (source != null) { - OpenSCLModule.openModule(moduleName); + OpenSCLModule.scheduleOpenModule(moduleName); } } catch (InvalidModulePathException e) { - // Nothing to do + LOGGER.error("Could not open declaration {} {}", input.getModuleName(), lineAtCaret, e); } } else { @@ -106,8 +110,9 @@ public class OpenDeclaration extends AbstractHandler { SCLTextEditorEnvironment editorEnvironment = moduleEditor.getSCLTextEditorEnvironment(); editorEnvironment.updateEnvironment(moduleEditor.getDocument()); SCLValue value = editorEnvironment.getValue(identifierAtCaret); + //System.out.println("identifierAtCaret = " + identifierAtCaret + " [" + Locations.beginOf(value.definitionLocation) + ", " + Locations.endOf(value.definitionLocation) + "]"); if(value != null) - OpenSCLDefinition.openDefinition(value); + OpenSCLDefinition.scheduleOpenDefinition(value.getName().module, value.definitionLocation); } return null; }