X-Git-Url: https://gerrit.simantics.org/r/gitweb?a=blobdiff_plain;f=bundles%2Forg.simantics.scl.ui%2Fsrc%2Forg%2Fsimantics%2Fscl%2Fui%2Feditor2%2FOpenDeclaration.java;h=421328c164222346da2c9eb073f222afe841c601;hb=refs%2Fchanges%2F88%2F1988%2F2;hp=cd59c874d61c93ab6c27825170882a34a249d704;hpb=0ae2b770234dfc3cbb18bd38f324125cf0faca07;p=simantics%2Fplatform.git diff --git a/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java b/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java index cd59c874d..421328c16 100644 --- a/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java +++ b/bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor2/OpenDeclaration.java @@ -9,10 +9,18 @@ import org.eclipse.swt.widgets.Control; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.PlatformUI; import org.simantics.scl.compiler.elaboration.modules.SCLValue; +import org.simantics.scl.compiler.module.InvalidModulePathException; +import org.simantics.scl.compiler.module.ModuleUtils; +import org.simantics.scl.compiler.source.ModuleSource; +import org.simantics.scl.osgi.SCLOsgi; import org.simantics.scl.ui.editor.completion.SCLTextEditorEnvironment; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class OpenDeclaration extends AbstractHandler { + private static final Logger LOGGER = LoggerFactory.getLogger(OpenDeclaration.class); + private static boolean isIdentifierPart(char c) { return Character.isJavaIdentifierPart(c) || c=='.'; } @@ -83,8 +91,16 @@ public class OpenDeclaration extends AbstractHandler { if(lineAtCaret.startsWith("import ") || lineAtCaret.startsWith("include ")) { int p1 = lineAtCaret.indexOf('"', 6); int p2 = lineAtCaret.indexOf('"', p1+1); - String moduleName = lineAtCaret.substring(p1+1, p2); - OpenSCLModule.openModule(moduleName); + SCLModuleEditorInput input = (SCLModuleEditorInput)moduleEditor.getEditorInput(); + try { + String moduleName = ModuleUtils.resolveAbsolutePath(input.getModuleName(), lineAtCaret.substring(p1+1, p2)); + ModuleSource source = SCLOsgi.SOURCE_REPOSITORY.getModuleSource(moduleName, null); + if (source != null) { + OpenSCLModule.scheduleOpenModule(moduleName); + } + } catch (InvalidModulePathException e) { + LOGGER.error("Could not open declaration {} {}", input.getModuleName(), lineAtCaret, e); + } } else { // Try to find an identifier at caret @@ -94,8 +110,9 @@ public class OpenDeclaration extends AbstractHandler { SCLTextEditorEnvironment editorEnvironment = moduleEditor.getSCLTextEditorEnvironment(); editorEnvironment.updateEnvironment(moduleEditor.getDocument()); SCLValue value = editorEnvironment.getValue(identifierAtCaret); + //System.out.println("identifierAtCaret = " + identifierAtCaret + " [" + Locations.beginOf(value.definitionLocation) + ", " + Locations.endOf(value.definitionLocation) + "]"); if(value != null) - OpenSCLDefinition.openDefinition(value); + OpenSCLDefinition.scheduleOpenDefinition(value.getName().module, value.definitionLocation); } return null; }