]> gerrit.simantics Code Review - simantics/platform.git/commit
Backported b75a6bbc for release/1.32.0.2 30/2030/1
authorTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Sun, 26 Aug 2018 12:28:01 +0000 (15:28 +0300)
committerTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Sun, 26 Aug 2018 12:28:01 +0000 (15:28 +0300)
commitcd47b6877cee258113eb00523701a57374becfd8
treee88fd7239b2f4bc931fc55a5d6f67b225821c289
parent939e1ad3b6a296414ca4f535076b36235cd958b1
Backported b75a6bbc for release/1.32.0.2

Previous too-optimized implementation had multiple flaws:
* Index calculation did not have enough parenthesis in it which meant
  that the value table index was sometimes calculated incorrectly.
  This lead to string literal values being read incorrectly.
* Did not take into account string literals longer than 127 characters
* Did not take into account that string literals are modified-utf-8
  encoded and simply decoded them as US-ASCII bytes. Essentially all
  resources with name containing special characters were indexed
  incorrectly up until now.

All of these flaws have been in the code for ages.

gitlab #86

Change-Id: Ibd5ecbaa1cdd1b8be759905bd8c29b9f8e012207
bundles/org.simantics.db.procore/src/fi/vtt/simantics/procore/internal/DirectQuerySupportImpl.java