]> gerrit.simantics Code Review - simantics/platform.git/commit
Backported b75a6bbc for release/1.35.0 32/2032/2
authorTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Sun, 26 Aug 2018 12:28:01 +0000 (15:28 +0300)
committerTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Sun, 26 Aug 2018 12:39:16 +0000 (12:39 +0000)
commitf7eeabfa90e5ac105c0abc192669d6d05d90fb8a
treeb6dd95d289002cc900d9360ef92c42d02921de47
parentd9d9949910e7e7b2917d41e2cd2e64d00055bd23
Backported b75a6bbc for release/1.35.0

Previous too-optimized implementation had multiple flaws:
* Index calculation did not have enough parenthesis in it which meant
  that the value table index was sometimes calculated incorrectly.
  This lead to string literal values being read incorrectly.
* Did not take into account string literals longer than 127 characters
* Did not take into account that string literals are modified-utf-8
  encoded and simply decoded them as US-ASCII bytes. Essentially all
  resources with name containing special characters were indexed
  incorrectly up until now.

All of these flaws have been in the code for ages.

gitlab #86

Change-Id: Ibd5ecbaa1cdd1b8be759905bd8c29b9f8e012207
(cherry picked from commit cd47b6877cee258113eb00523701a57374becfd8)
bundles/org.simantics.db.procore/src/fi/vtt/simantics/procore/internal/DirectQuerySupportImpl.java