summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
f537452)
Listener removal caused PipeRun splits to fail synchronization to DB.
As a precaution, now nodeAdded and nodeRemoved will synchronize both
parent and and actual node (previously only parent node was
synchronized).
gitlab #35
Change-Id: I34a105cc91b8b720a48a166288610debc10a3b84
}
if (changeTracking) {
mapping.rangeModified((E)node.getParent());
}
if (changeTracking) {
mapping.rangeModified((E)node.getParent());
+ mapping.rangeModified((E)node);
}
added.add(new Pair<E, String>(node, id));
rangeModified = true;
}
added.add(new Pair<E, String>(node, id));
rangeModified = true;
if (n.first.equals(node))
return;
}
if (n.first.equals(node))
return;
}
- if (changeTracking && !db)
+ if (changeTracking && !db) {
+ mapping.rangeModified((E)node);
mapping.rangeModified((E)node.getParent());
mapping.rangeModified((E)node.getParent());
removed.add(new Pair<E, String>(node, id));
rangeModified = true;
}
removed.add(new Pair<E, String>(node, id));
rangeModified = true;
}
for (E n : delete) {
if (DEBUG) System.out.println(debugString(n));
mapping.getRange().remove(n);
for (E n : delete) {
if (DEBUG) System.out.println(debugString(n));
mapping.getRange().remove(n);
if (DEBUG) System.out.println("Node added " + child + " parent " + node);
//receiveAdd((E)child, rel ,graphUpdates);
receiveAdd((E)child, rel ,graphModified.contains(node));
if (DEBUG) System.out.println("Node added " + child + " parent " + node);
//receiveAdd((E)child, rel ,graphUpdates);
receiveAdd((E)child, rel ,graphModified.contains(node));
}
@SuppressWarnings("unchecked")
}
@SuppressWarnings("unchecked")
//receiveRemove((E)child, rel, graphUpdates);
receiveRemove((E)child, rel, graphModified.contains(node));
//receiveRemove((E)child, rel, graphUpdates);
receiveRemove((E)child, rel, graphModified.contains(node));
- //FIXME : sometimes removed structural models cause ObjMap to add their children again.
- // removing the listener here prevents corruption of visual model, but better fix is needed.
- stopListening(child);
+ //FIXME : 1. sometimes removed structural models cause ObjMap to add their children again.
+ // removing the listener here prevents corruption of visual model, but better fix is needed.
+ // 2. detach causes nodeRemoved event, which then causes other critical events to be missed. Took out th
+ //stopListening(child);