]> gerrit.simantics Code Review - simantics/3d.git/commitdiff
Mark undo pints when committing changes to the graph 93/3093/2
authorMarko Luukkainen <marko.luukkainen@semantum.fi>
Mon, 12 Aug 2019 10:03:28 +0000 (13:03 +0300)
committerMarko Luukkainen <marko.luukkainen@semantum.fi>
Mon, 12 Aug 2019 10:03:42 +0000 (13:03 +0300)
gitlab #24

Change-Id: I7f3a3a7501acf93b5ffc6e0a92e00fbe5ba38827

17 files changed:
org.simantics.g3d.csg/src/org/simantics/g3d/csg/actions/AddBooleanOpAction2.java
org.simantics.g3d.csg/src/org/simantics/g3d/csg/actions/AddPrimitiveAction2.java
org.simantics.g3d.csg/src/org/simantics/g3d/csg/actions/SplitBooleanOpAction2.java
org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/action/RemoveAction.java
org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/awt/RotateAction.java
org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/awt/TranslateAction.java
org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/common/AbstractVTKNodeMap.java
org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/swt/RotateAction.java
org.simantics.g3d.vtk/src/org/simantics/g3d/vtk/swt/TranslateAction.java
org.simantics.g3d/src/org/simantics/g3d/property/AnnotatedPropertyTabContributorFactory.java
org.simantics.g3d/src/org/simantics/g3d/scenegraph/NodeMap.java
org.simantics.plant3d/src/org/simantics/plant3d/actions/AddComponentAction.java
org.simantics.plant3d/src/org/simantics/plant3d/actions/AddEquipmentAction.java
org.simantics.plant3d/src/org/simantics/plant3d/actions/AddNozzleAction.java
org.simantics.plant3d/src/org/simantics/plant3d/actions/RoutePipeAction.java
org.simantics.plant3d/src/org/simantics/plant3d/actions/TranslateInlineAction.java
org.simantics.plant3d/src/org/simantics/plant3d/editor/P3DNodeMap.java

index e4d824920f0094206078302261f1951de06e1729..be196042ff02c589bb53ddcc457d6cb8cbbfa576 100644 (file)
@@ -1,80 +1,80 @@
-/*******************************************************************************\r
- * Copyright (c) 2012, 2013 Association for Decentralized Information Management in\r
- * Industry THTH ry.\r
- * All rights reserved. This program and the accompanying materials\r
- * are made available under the terms of the Eclipse Public License v1.0\r
- * which accompanies this distribution, and is available at\r
- * http://www.eclipse.org/legal/epl-v10.html\r
- *\r
- * Contributors:\r
- *     VTT Technical Research Centre of Finland - initial API and implementation\r
- *******************************************************************************/\r
-package org.simantics.g3d.csg.actions;\r
-\r
-import java.util.Collection;\r
-import java.util.HashMap;\r
-import java.util.Iterator;\r
-import java.util.Map;\r
-\r
-import javax.vecmath.Quat4d;\r
-import javax.vecmath.Vector3d;\r
-\r
-import org.eclipse.jface.action.Action;\r
-import org.simantics.g3d.csg.scenegraph2.CSGparentNode;\r
-import org.simantics.g3d.csg.scenegraph2.CSGrootNode;\r
-import org.simantics.g3d.csg.scenegraph2.ICSGnode;\r
-import org.simantics.utils.ui.ExceptionUtils;\r
-\r
-public class AddBooleanOpAction2 extends Action {\r
-       CSGrootNode root;\r
-       Class<? extends CSGparentNode> booleanClass;\r
-       Collection<ICSGnode> nodes;\r
-       \r
-       public AddBooleanOpAction2(CSGrootNode root, Class<? extends CSGparentNode> booleanClass, Collection<ICSGnode> nodes) {\r
-               super();\r
-               String name = booleanClass.getSimpleName();\r
-               if (name.endsWith("Node"))\r
-                       name = name.substring(0,name.length()-4);\r
-               setText(name);\r
-               this.booleanClass = booleanClass;\r
-               this.nodes = nodes;\r
-               this.root = root;\r
-               if (nodes.size() != 2)\r
-                       setEnabled(false);\r
-               for (ICSGnode node : nodes) {\r
-                       if (!node.getParent().equals(root))\r
-                               setEnabled(false);\r
-               }\r
-       }\r
-       \r
-       @Override\r
-       public void run() {\r
-               try {\r
-                       CSGparentNode booleanNode = booleanClass.newInstance();\r
-                       Map<ICSGnode,Vector3d> positions = new HashMap<ICSGnode, Vector3d>();\r
-                       Map<ICSGnode,Quat4d> orientations = new HashMap<ICSGnode, Quat4d>();\r
-                       for (ICSGnode node : nodes) {\r
-                               positions.put(node, node.getWorldPosition());\r
-                               orientations.put(node, node.getWorldOrientation());\r
-                               //root.remChild(node);\r
-                               node.deattach();\r
-                       }\r
-                       Iterator<ICSGnode> iter = nodes.iterator();\r
-                       booleanNode.addPrimaryChild(iter.next());\r
-                       booleanNode.addSecondaryChild(iter.next());\r
-                       \r
-                       String name = root.getUniqueName(booleanNode.getClass().getSimpleName());\r
-                       booleanNode.setName(name);\r
-                       \r
-                       root.addChild(booleanNode);\r
-                       for (ICSGnode node : nodes) {\r
-                               node.setWorldPosition(positions.get(node));\r
-                               node.setWorldOrientation(orientations.get(node));\r
-                       }\r
-                       root.getNodeMap().commit();\r
-               } catch (Exception e) {\r
-                       ExceptionUtils.logAndShowError("Cannot create boolean operation.", e);\r
-               }\r
-       }\r
-\r
-}\r
+/*******************************************************************************
+ * Copyright (c) 2012, 2013 Association for Decentralized Information Management in
+ * Industry THTH ry.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     VTT Technical Research Centre of Finland - initial API and implementation
+ *******************************************************************************/
+package org.simantics.g3d.csg.actions;
+
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map;
+
+import javax.vecmath.Quat4d;
+import javax.vecmath.Vector3d;
+
+import org.eclipse.jface.action.Action;
+import org.simantics.g3d.csg.scenegraph2.CSGparentNode;
+import org.simantics.g3d.csg.scenegraph2.CSGrootNode;
+import org.simantics.g3d.csg.scenegraph2.ICSGnode;
+import org.simantics.utils.ui.ExceptionUtils;
+
+public class AddBooleanOpAction2 extends Action {
+       CSGrootNode root;
+       Class<? extends CSGparentNode> booleanClass;
+       Collection<ICSGnode> nodes;
+       
+       public AddBooleanOpAction2(CSGrootNode root, Class<? extends CSGparentNode> booleanClass, Collection<ICSGnode> nodes) {
+               super();
+               String name = booleanClass.getSimpleName();
+               if (name.endsWith("Node"))
+                       name = name.substring(0,name.length()-4);
+               setText(name);
+               this.booleanClass = booleanClass;
+               this.nodes = nodes;
+               this.root = root;
+               if (nodes.size() != 2)
+                       setEnabled(false);
+               for (ICSGnode node : nodes) {
+                       if (!node.getParent().equals(root))
+                               setEnabled(false);
+               }
+       }
+       
+       @Override
+       public void run() {
+               try {
+                       CSGparentNode booleanNode = booleanClass.newInstance();
+                       Map<ICSGnode,Vector3d> positions = new HashMap<ICSGnode, Vector3d>();
+                       Map<ICSGnode,Quat4d> orientations = new HashMap<ICSGnode, Quat4d>();
+                       for (ICSGnode node : nodes) {
+                               positions.put(node, node.getWorldPosition());
+                               orientations.put(node, node.getWorldOrientation());
+                               //root.remChild(node);
+                               node.deattach();
+                       }
+                       Iterator<ICSGnode> iter = nodes.iterator();
+                       booleanNode.addPrimaryChild(iter.next());
+                       booleanNode.addSecondaryChild(iter.next());
+                       
+                       String name = root.getUniqueName(booleanNode.getClass().getSimpleName());
+                       booleanNode.setName(name);
+                       
+                       root.addChild(booleanNode);
+                       for (ICSGnode node : nodes) {
+                               node.setWorldPosition(positions.get(node));
+                               node.setWorldOrientation(orientations.get(node));
+                       }
+                       root.getNodeMap().commit("Add Boolean Op");
+               } catch (Exception e) {
+                       ExceptionUtils.logAndShowError("Cannot create boolean operation.", e);
+               }
+       }
+
+}
index 3a16a21d35362e9f3c310158cb505030dcaa6a5e..55748e782adb1f3afd99d6ae23411d6cf1a8b223 100644 (file)
@@ -1,46 +1,46 @@
-/*******************************************************************************\r
- * Copyright (c) 2012, 2013 Association for Decentralized Information Management in\r
- * Industry THTH ry.\r
- * All rights reserved. This program and the accompanying materials\r
- * are made available under the terms of the Eclipse Public License v1.0\r
- * which accompanies this distribution, and is available at\r
- * http://www.eclipse.org/legal/epl-v10.html\r
- *\r
- * Contributors:\r
- *     VTT Technical Research Centre of Finland - initial API and implementation\r
- *******************************************************************************/\r
-package org.simantics.g3d.csg.actions;\r
-\r
-import org.eclipse.jface.action.Action;\r
-import org.simantics.g3d.csg.scenegraph2.CSGnode;\r
-import org.simantics.g3d.csg.scenegraph2.CSGrootNode;\r
-import org.simantics.utils.ui.ExceptionUtils;\r
-\r
-public class AddPrimitiveAction2 extends Action {\r
-       \r
-       CSGrootNode root;\r
-       Class<? extends CSGnode> primitiveClass;\r
-       public AddPrimitiveAction2(CSGrootNode root, Class<? extends CSGnode> primitiveClass)  {\r
-               super();\r
-               String name = primitiveClass.getSimpleName();\r
-               if (name.endsWith("Node"))\r
-                       name = name.substring(0,name.length()-4);\r
-               setText(name);\r
-               this.primitiveClass = primitiveClass;\r
-               this.root = root;\r
-       }\r
-       \r
-       @Override\r
-       public void run() {\r
-               try {\r
-                       CSGnode node = primitiveClass.newInstance();\r
-                       String name = root.getUniqueName(node.getClass().getSimpleName());\r
-                       node.setName(name);\r
-                       root.addChild(node);\r
-                       root.getNodeMap().commit();\r
-               } catch (Exception e) {\r
-                       ExceptionUtils.logAndShowError("Cannot create primitive.", e);\r
-               }\r
-       }\r
-\r
-}\r
+/*******************************************************************************
+ * Copyright (c) 2012, 2013 Association for Decentralized Information Management in
+ * Industry THTH ry.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     VTT Technical Research Centre of Finland - initial API and implementation
+ *******************************************************************************/
+package org.simantics.g3d.csg.actions;
+
+import org.eclipse.jface.action.Action;
+import org.simantics.g3d.csg.scenegraph2.CSGnode;
+import org.simantics.g3d.csg.scenegraph2.CSGrootNode;
+import org.simantics.utils.ui.ExceptionUtils;
+
+public class AddPrimitiveAction2 extends Action {
+       
+       CSGrootNode root;
+       Class<? extends CSGnode> primitiveClass;
+       public AddPrimitiveAction2(CSGrootNode root, Class<? extends CSGnode> primitiveClass)  {
+               super();
+               String name = primitiveClass.getSimpleName();
+               if (name.endsWith("Node"))
+                       name = name.substring(0,name.length()-4);
+               setText(name);
+               this.primitiveClass = primitiveClass;
+               this.root = root;
+       }
+       
+       @Override
+       public void run() {
+               try {
+                       CSGnode node = primitiveClass.newInstance();
+                       String name = root.getUniqueName(node.getClass().getSimpleName());
+                       node.setName(name);
+                       root.addChild(node);
+                       root.getNodeMap().commit("Add primitive");
+               } catch (Exception e) {
+                       ExceptionUtils.logAndShowError("Cannot create primitive.", e);
+               }
+       }
+
+}
index ace2262c6711b3cf5f1bd822bcd26e1996cfd60e..cebe1b453bef7d1391d218d6bf9f5eefd74df541 100644 (file)
@@ -1,60 +1,60 @@
-/*******************************************************************************\r
- * Copyright (c) 2012, 2013 Association for Decentralized Information Management in\r
- * Industry THTH ry.\r
- * All rights reserved. This program and the accompanying materials\r
- * are made available under the terms of the Eclipse Public License v1.0\r
- * which accompanies this distribution, and is available at\r
- * http://www.eclipse.org/legal/epl-v10.html\r
- *\r
- * Contributors:\r
- *     VTT Technical Research Centre of Finland - initial API and implementation\r
- *******************************************************************************/\r
-package org.simantics.g3d.csg.actions;\r
-\r
-import java.util.ArrayList;\r
-import java.util.Collection;\r
-import java.util.HashMap;\r
-import java.util.Map;\r
-\r
-import javax.vecmath.Quat4d;\r
-import javax.vecmath.Vector3d;\r
-\r
-import org.eclipse.jface.action.Action;\r
-import org.simantics.g3d.csg.scenegraph2.CSGparentNode;\r
-import org.simantics.g3d.csg.scenegraph2.CSGrootNode;\r
-import org.simantics.g3d.csg.scenegraph2.ICSGnode;\r
-\r
-public class SplitBooleanOpAction2 extends Action {\r
-       private CSGrootNode root;\r
-       private CSGparentNode booleanOp;\r
-       \r
-       public SplitBooleanOpAction2(CSGrootNode root, CSGparentNode booleanOp)  {\r
-               super();\r
-               setText("Split");\r
-               this.booleanOp = booleanOp;\r
-               this.root = root;\r
-       }\r
-       \r
-       @Override\r
-       public void run() {\r
-               Collection<ICSGnode> nodes = new ArrayList<ICSGnode>();\r
-               nodes.addAll(booleanOp.getPrimaryChild());\r
-               nodes.addAll(booleanOp.getSecondaryChild());\r
-               Map<ICSGnode,Vector3d> positions = new HashMap<ICSGnode, Vector3d>();\r
-               Map<ICSGnode,Quat4d> orientations = new HashMap<ICSGnode, Quat4d>();\r
-               for (ICSGnode node : nodes) {\r
-                       positions.put(node, node.getWorldPosition());\r
-                       orientations.put(node, node.getWorldOrientation());\r
-                       node.deattach();\r
-               }\r
-               for (ICSGnode node : nodes) {\r
-                       root.addChild(node);\r
-                       node.setWorldPosition(positions.get(node));\r
-                       node.setWorldOrientation(orientations.get(node));\r
-               }\r
-               root.remChild(booleanOp);\r
-               root.getNodeMap().commit();\r
-\r
-       }\r
-\r
-}\r
+/*******************************************************************************
+ * Copyright (c) 2012, 2013 Association for Decentralized Information Management in
+ * Industry THTH ry.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     VTT Technical Research Centre of Finland - initial API and implementation
+ *******************************************************************************/
+package org.simantics.g3d.csg.actions;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.vecmath.Quat4d;
+import javax.vecmath.Vector3d;
+
+import org.eclipse.jface.action.Action;
+import org.simantics.g3d.csg.scenegraph2.CSGparentNode;
+import org.simantics.g3d.csg.scenegraph2.CSGrootNode;
+import org.simantics.g3d.csg.scenegraph2.ICSGnode;
+
+public class SplitBooleanOpAction2 extends Action {
+       private CSGrootNode root;
+       private CSGparentNode booleanOp;
+       
+       public SplitBooleanOpAction2(CSGrootNode root, CSGparentNode booleanOp)  {
+               super();
+               setText("Split");
+               this.booleanOp = booleanOp;
+               this.root = root;
+       }
+       
+       @Override
+       public void run() {
+               Collection<ICSGnode> nodes = new ArrayList<ICSGnode>();
+               nodes.addAll(booleanOp.getPrimaryChild());
+               nodes.addAll(booleanOp.getSecondaryChild());
+               Map<ICSGnode,Vector3d> positions = new HashMap<ICSGnode, Vector3d>();
+               Map<ICSGnode,Quat4d> orientations = new HashMap<ICSGnode, Quat4d>();
+               for (ICSGnode node : nodes) {
+                       positions.put(node, node.getWorldPosition());
+                       orientations.put(node, node.getWorldOrientation());
+                       node.deattach();
+               }
+               for (ICSGnode node : nodes) {
+                       root.addChild(node);
+                       node.setWorldPosition(positions.get(node));
+                       node.setWorldOrientation(orientations.get(node));
+               }
+               root.remChild(booleanOp);
+               root.getNodeMap().commit("Split");
+
+       }
+
+}
index df74d2a1c897fbb5d5e63546ac2aedd234769c3e..8fcb93681bd3ea70d06e7997385220122b65b226 100644 (file)
@@ -1,53 +1,53 @@
-/*******************************************************************************\r
- * Copyright (c) 2012, 2013 Association for Decentralized Information Management in\r
- * Industry THTH ry.\r
- * All rights reserved. This program and the accompanying materials\r
- * are made available under the terms of the Eclipse Public License v1.0\r
- * which accompanies this distribution, and is available at\r
- * http://www.eclipse.org/legal/epl-v10.html\r
- *\r
- * Contributors:\r
- *     VTT Technical Research Centre of Finland - initial API and implementation\r
- *******************************************************************************/\r
-package org.simantics.g3d.vtk.action;\r
-\r
-import org.eclipse.jface.action.Action;\r
-import org.simantics.g3d.scenegraph.IG3DNode;\r
-import org.simantics.g3d.scenegraph.structural.IStructuralNode;\r
-import org.simantics.g3d.vtk.Activator;\r
-import org.simantics.g3d.vtk.common.VTKNodeMap;\r
-\r
-public class RemoveAction extends Action {\r
-\r
-       private VTKNodeMap nodeMap;\r
-       protected IG3DNode node;\r
-       \r
-       public RemoveAction(VTKNodeMap nodeMap) {\r
-               setText("Remove");\r
-               setImageDescriptor(Activator.imageDescriptorFromPlugin("com.famfamfam.silk", "icons/delete.png"));\r
-               this.nodeMap = nodeMap;\r
-       }\r
-       \r
-       public void setNode(IG3DNode node) {\r
-               this.node = node;\r
-               setEnabled(isRemovable(node));\r
-       }\r
-       \r
-       public boolean isRemovable(IG3DNode node) {\r
-               if ((node instanceof IStructuralNode) && ((IStructuralNode)node).isPartOfInstantiatedModel() && !((IStructuralNode)node).isInstantiatedModelRoot())\r
-                       return false;\r
-               return true;\r
-       }\r
-       \r
-       @Override\r
-       public void run() {\r
-               \r
-               doRemove(node);\r
-               nodeMap.commit();\r
-               node = null;\r
-       }\r
-       \r
-       protected void doRemove(IG3DNode node) {\r
-               node.remove();\r
-       }\r
-}\r
+/*******************************************************************************
+ * Copyright (c) 2012, 2013 Association for Decentralized Information Management in
+ * Industry THTH ry.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     VTT Technical Research Centre of Finland - initial API and implementation
+ *******************************************************************************/
+package org.simantics.g3d.vtk.action;
+
+import org.eclipse.jface.action.Action;
+import org.simantics.g3d.scenegraph.IG3DNode;
+import org.simantics.g3d.scenegraph.structural.IStructuralNode;
+import org.simantics.g3d.vtk.Activator;
+import org.simantics.g3d.vtk.common.VTKNodeMap;
+
+public class RemoveAction extends Action {
+
+       private VTKNodeMap nodeMap;
+       protected IG3DNode node;
+       
+       public RemoveAction(VTKNodeMap nodeMap) {
+               setText("Remove");
+               setImageDescriptor(Activator.imageDescriptorFromPlugin("com.famfamfam.silk", "icons/delete.png"));
+               this.nodeMap = nodeMap;
+       }
+       
+       public void setNode(IG3DNode node) {
+               this.node = node;
+               setEnabled(isRemovable(node));
+       }
+       
+       public boolean isRemovable(IG3DNode node) {
+               if ((node instanceof IStructuralNode) && ((IStructuralNode)node).isPartOfInstantiatedModel() && !((IStructuralNode)node).isInstantiatedModelRoot())
+                       return false;
+               return true;
+       }
+       
+       @Override
+       public void run() {
+               
+               doRemove(node);
+               nodeMap.commit("Remove");
+               node = null;
+       }
+       
+       protected void doRemove(IG3DNode node) {
+               node.remove();
+       }
+}
index f7ffc5530e2b1dc77a2ea275177070b1b93081b7..4f62533bbcf1bb8ca3abe4d22637adea4df4f7f5 100644 (file)
@@ -135,7 +135,7 @@ public class RotateAction extends vtkAwtAction{
        public void deattach() {
                
                node = null;
-               nodeMap.commit();
+               nodeMap.commit("Rotate");
                deattachUI();
                super.deattach();
                panel.repaint();
index d7d81331b7c757151f52b8532c3b4bd5aaf771f4..1b07afa80bdf35cf0bc173ec0ce766d99a519653 100644 (file)
@@ -93,7 +93,7 @@ public class TranslateAction extends vtkAwtAction{
        public void deattach() {
                
                node = null;
-               nodeMap.commit();
+               nodeMap.commit("Translate");
                deattachUI();
                super.deattach();
                panel.repaint();
index 646fbe41cdef8300e24e71ea84eba13510995e35..dab2040edde8be9947723d35a3c7528fd6825254 100644 (file)
@@ -26,6 +26,7 @@ import org.simantics.db.WriteGraph;
 import org.simantics.db.common.request.ReadRequest;
 import org.simantics.db.common.request.WriteRequest;
 import org.simantics.db.exception.DatabaseException;
+import org.simantics.db.layer0.util.Layer0Utils;
 import org.simantics.g3d.ontology.G3D;
 import org.simantics.g3d.scenegraph.RenderListener;
 import org.simantics.g3d.scenegraph.base.INode;
@@ -204,10 +205,12 @@ public abstract class AbstractVTKNodeMap<E extends INode> implements VTKNodeMap<
        private Set<E> graphModified = new HashSet<E>();
        
        private boolean requestCommit = false;
+       private String commitMessage = null;
        
        @Override
-       public void commit() {
+       public void commit(String message) {
                requestCommit = true;
+               commitMessage = message;
        }
        
        protected void doCommit() {
@@ -216,6 +219,11 @@ public abstract class AbstractVTKNodeMap<E extends INode> implements VTKNodeMap<
                        @Override
                        public void perform(WriteGraph graph) throws DatabaseException {
                                commit(graph);
+                               if (commitMessage != null) {
+                                   Layer0Utils.addCommentMetadata(graph, commitMessage);
+                                   commitMessage = null;
+                               }
+                       graph.markUndoPoint();
                        }
                        
                }, new Callback<DatabaseException>() {
@@ -267,7 +275,7 @@ public abstract class AbstractVTKNodeMap<E extends INode> implements VTKNodeMap<
                }
                
                if (mapping.isRangeModified())
-                       commit();
+                       commit("Graph sync");
        }
        
        @Override
index 1b2d791432a7c4c8037e03cc669694b51380abd1..c45316e8c10dfc68d7e9d064e4cf85bedf4ff47a 100644 (file)
@@ -141,7 +141,7 @@ public class RotateAction extends vtkSwtAction{
        public void deattach() {
                
                node = null;
-               nodeMap.commit();
+               nodeMap.commit("Rotate");
                deattachUI();
                super.deattach();
                panel.refresh();
index b6b5ca7f7dbe9175de60ac9b85b9c51591bceeb3..83c434bb6ee15bdcada1aee42e3019e62e8e8d42 100644 (file)
@@ -99,7 +99,7 @@ public class TranslateAction extends vtkSwtAction{
        public void deattach() {
                
                node = null;
-               nodeMap.commit();
+               nodeMap.commit("Translate");
                deattachUI();
                super.deattach();
                panel.refresh();
index c3d7376fd87af9af1fef64c6066b893d48671fdb..a3fca78bb4206dc18adafa617073919702042778 100644 (file)
@@ -799,7 +799,7 @@ public class AnnotatedPropertyTabContributorFactory implements PropertyTabContri
                        if (DEBUG)System.err.println("CELL SET VALUE: " + element + " " + value);
                        manipulator.setValue((String)value,index);
                        viewer.refresh(item);
-                       nodeMap.commit();
+                       nodeMap.commit("Set " + item.id + " value to " + value);
                        
                }
                
index 6324d90e9f8be9b85f50c02af69286301accc16f..36ee73a3ff98603d76a92844071a0a5f751932ff 100644 (file)
@@ -31,7 +31,7 @@ public interface NodeMap<T,E extends INode> {
        /**
         * Commit changes to the database.
         */
-       public void commit();
+       public void commit(String message);
        
        
        /**
index a4398a5455b582fab3c3192800593c9f921e5c7d..18087b68ce17387fe4394ce7010a0f439847ed68 100644 (file)
@@ -117,7 +117,7 @@ public class AddComponentAction extends vtkSwtAction {
        public void deattach() {
 //             deactivate();
                component = null;
-               nodeMap.commit();
+               nodeMap.commit("Add component");
                deattachUI();
                super.deattach();
                panel.refresh();
index 6c66909a845f6fae241885f8f14c56ea98767581..ae7603ca6ab3cda78c69d79384b56d4e22370fa3 100644 (file)
@@ -25,7 +25,7 @@ public class AddEquipmentAction extends Action {
                        String n = root.getUniqueName(item.getName());
                        equipment.setName(n);
                        root.addChild(equipment);
-                       root.getNodeMap().commit();
+                       root.getNodeMap().commit("Add equipment " + n);
                } catch (Exception e) {
                        ExceptionUtils.logAndShowError("Cannot create equipment",e);
                }
index e6b8ecd6b75ca420ad5ab9c9d7b2cc1e584ba2d0..34069d95492c54f781ee3dfdd74bcfc27b89017a 100644 (file)
@@ -41,7 +41,7 @@ public class AddNozzleAction extends Action {
                        equipment.addChild(nozzle);
                        //root.addChild(nozzle);
                        root.addChild(pipeRun);
-                       root.getNodeMap().commit();
+                       root.getNodeMap().commit("Add nozzle " + n);
                } catch (Exception e) {
                        ExceptionUtils.logAndShowError("Cannot create equipment",e);
                }
index da7beb45a2069470f6afc96af8b17e44693ebd58..17455a328b0797cef34dc296d560aff852090ea7 100644 (file)
@@ -111,7 +111,7 @@ public class RoutePipeAction extends vtkSwtAction {
        public void deattach() {
                deactivate();
                startComponent = null;
-               nodeMap.commit();
+               nodeMap.commit("Route pipe");
                deattachUI();
                super.deattach();
                panel.refresh();
index 23096f7eabfc96e40568bef31e571ffca5405d7f..7ea42d597b3365ca4b3951fbab2c8b9b47120bfd 100644 (file)
@@ -46,9 +46,9 @@ public class TranslateInlineAction extends TranslateAction{
                                        setEnabled(false);
                                        return;
                                }
-                               if (prev.getControlPoint().isInline() && !prev.getControlPoint().isFixed())
+                               if (prev.getControlPoint().isInline() && !prev.getControlPoint().isFixed() && prev.getPrevious() != null)
                                        prev = prev.getPrevious();
-                               if (next.getControlPoint().isInline() && !next.getControlPoint().isFixed()) {
+                               if (next.getControlPoint().isInline() && !next.getControlPoint().isFixed() && next.getNext() != null) {
                                        next = next.getNext();
                                }
                                Point3d ns = new Point3d();
@@ -61,8 +61,14 @@ public class TranslateInlineAction extends TranslateAction{
                                dir.normalize();
                                // We may have offsets in the path leg, hence we have to project the coordinates.
                                Vector3d wp = node.getWorldPosition();
-                               s = MathTools.closestPointOnStraight(pe, wp, dir);
-                               e = MathTools.closestPointOnStraight(ns, wp, dir);
+                               if (prev.getControlPoint().isVariableLength())
+                                   s = MathTools.closestPointOnStraight(ps, wp, dir);
+                               else
+                                   s = MathTools.closestPointOnStraight(pe, wp, dir);
+                               if (next.getControlPoint().isVariableLength())
+                                   e = MathTools.closestPointOnStraight(ne, wp, dir);
+                               else
+                                   e = MathTools.closestPointOnStraight(ns, wp, dir);
                                // Remove component's own space from end points to get actual movement range
                                double l = comp.getControlPoint().getInlineLength();
                                Vector3d ld = new Vector3d(dir);
index ea3795206ec184698c3aeb460eb1b2c2c956d4c3..46f3bf6421bd37aa27608808bf07bb3d16bd435d 100644 (file)
@@ -199,10 +199,10 @@ public class P3DNodeMap extends AbstractVTKNodeMap<INode> {
        }
        
        @Override
-       public void commit() {
+       public void commit(String commitMessage) {
                validate();
 //             System.out.println("Graph commit");
-               super.commit();
+               super.commit(commitMessage);
                
        }
        @Override