]> gerrit.simantics Code Review - simantics/platform.git/commitdiff
Fixed SCLCompletionProposal.validate to allow complete matches as well 58/2158/1
authorTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Mon, 14 May 2018 07:16:45 +0000 (10:16 +0300)
committerTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Tue, 11 Sep 2018 08:14:11 +0000 (08:14 +0000)
This fixes a case where the SCL module editor stops showing content
proposals once they fully match with the typed word, which is really
annoying.

gitlab #3

Change-Id: I7b1119bff4cb08063a838a441a628a785344220b
(cherry picked from commit 2790c2eced1ae3e229972ede7173dc6831834760)

bundles/org.simantics.scl.ui/src/org/simantics/scl/ui/editor/completion/SCLCompletionProposal.java

index 11749a4b2b24eef1c717eec74e9129731da58ce6..3734513cb6c3588b054e13a03b7cc15d9d4de1b6 100644 (file)
@@ -166,14 +166,15 @@ public class SCLCompletionProposal implements ICompletionProposal, ICompletionPr
     @Override
     public boolean validate(IDocument document, int offset, DocumentEvent event) {
         try {
-//            System.out.println("replacementOffset : " + replacementOffset);
-//            System.out.println("offset : " + offset);
+            String n = getName();
+            //System.out.println(n + " (" + n.length() + ") " + replacementOffset + " " + offset);
             boolean a = offset >= replacementOffset;
-            boolean b = offset < replacementOffset + getName().length();
+            boolean b = offset <= replacementOffset + n.length();
             String s = document.get(replacementOffset, offset - replacementOffset);
             prefix = s;
-            String d = getName();//.substring(0, offset - prefixStart);
-            boolean c = d.toLowerCase().startsWith(s.toLowerCase());
+            //System.out.println("prefix: " + s + " - " + prefix);
+            boolean c = n.toLowerCase().startsWith(s.toLowerCase());
+            //System.out.println("matches: " + a + " " + b + " " + c);
             return a && b && c;
         } catch (BadLocationException x) {
             //x.printStackTrace();