private TObjectIntHashMap<NodeContext> references = new TObjectIntHashMap<NodeContext>();
@Override
- public void incRef(NodeContext context) {
+ synchronized public void incRef(NodeContext context) {
int exist = references.get(context);
references.put(context, exist+1);
}
@Override
- public void decRef(NodeContext context) {
+ synchronized public void decRef(NodeContext context) {
int exist = references.get(context);
references.put(context, exist-1);
if(exist == 1) {
assert (request != null);
assert (procedure != null);
- processor.schedule(new SessionTask(this) {
+ processor.scheduleNow(new SessionTask(this) {
@Override
public void run0(int thread) {
assert (request != null);
assert (procedure != null);
- processor.schedule(new SessionTask(this) {
+ processor.scheduleNow(new SessionTask(this) {
@Override
public void run0(int thread) {
public boolean performPending() {
return processor.performPending(this);
}
-
+
public Set<ReadGraphImpl> ancestorSet() {
HashSet<ReadGraphImpl> result = new HashSet<>();
ReadGraphImpl g = this;
}
return result;
}
+
+ public int getLevel() {
+ return getLevelStatic(this);
+ }
+
+ private static int getLevelStatic(ReadGraphImpl impl) {
+ if(impl == null) return 0;
+ else return 1 + getLevelStatic(impl.parentGraph);
+ }
+
+ public ReadGraphImpl getTopLevelGraph() {
+ return getTopLevelGraphStatic(this);
+ }
+
+ private static ReadGraphImpl getTopLevelGraphStatic(ReadGraphImpl impl) {
+ if(impl.parentGraph == null) return impl;
+ else return getTopLevelGraphStatic(impl.parentGraph);
+ }
}
DatabaseException exception;
public AsyncTask(ReadGraphImpl graph) {
+ this(graph, 1);
+ }
+
+ public AsyncTask(ReadGraphImpl graph, int pos) {
super(graph);
+ this.position = pos;
+ if(this.position < 1024)
+ this.position *= 2;
}
@Override
}
throw new IllegalStateException("Eternal loop in queries.");
}
- graph.processor.schedule(new AsyncTask(graph));
+ graph.processor.scheduleLater(new AsyncTask(graph, position));
}
}
+ @Override
+ public boolean maybeReady() {
+ return proc.isDone();
+ }
+
}
try {
if(needsToBlock) task.run(0);
else if (proc.isDone()) task.run(0);
else {
- graph.processor.schedule(task);
+ graph.processor.scheduleLater(task);
return null;
}
}
ReadEntry entry = (ReadEntry)cache.getOrCreateReadEntry(graph, r, needsToBlock);
if(entry == null) {
- graph.processor.schedule(new SessionTask(graph) {
+ graph.processor.scheduleNow(new SessionTask(graph) {
@Override
public void run0(int thread) {
try {
}
AsyncReadEntry entry = (AsyncReadEntry)cache.getOrCreateAsyncReadEntry(graph, r, needsToBlock);
if(entry == null) {
- graph.processor.schedule(new SessionTask(graph) {
+ graph.processor.scheduleNow(new SessionTask(graph) {
@Override
public void run0(int thread) {
try {
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.Semaphore;
import org.simantics.databoard.Bindings;
private THashSet<ListenerEntry> scheduledListeners = new THashSet<ListenerEntry>();
private boolean firingListeners = false;
final THashMap<CacheEntry, ArrayList<ListenerEntry>> listeners = new THashMap<CacheEntry, ArrayList<ListenerEntry>>(10, 0.75f);
- private BlockingQueue<Runnable> tasks = new LinkedBlockingQueue<Runnable>();
+ private BlockingQueue<Runnable> tasks = new ArrayBlockingQueue<Runnable>(2048);
private Map<ListenerBase,ListenerEntry> addedEntries = new HashMap<>();
QueryListening(QueryProcessor processor) {
public void sync() {
Semaphore s = new Semaphore(0);
- tasks.add(() -> {
- s.release();
- });
try {
+ tasks.put(() -> {
+ s.release();
+ });
s.acquire();
} catch (Throwable t) {
LOGGER.error("Error while waiting for query dependency management", t);
void registerDependencies(ReadGraphImpl graph, CacheEntry child, CacheEntry parent, ListenerBase listener, Object procedure, boolean inferred) {
- tasks.offer(() -> {
+ try {
+ tasks.put(() -> {
- if (parent != null && !inferred) {
- try {
- if(!child.isImmutable(graph))
- child.addParent(parent);
- } catch (DatabaseException e) {
- LOGGER.error("Error while registering query dependencies", e);
- }
- if (Development.DEVELOPMENT) {
- if(Development.<Boolean>getProperty(DevelopmentKeys.QUERYPROCESSOR_DEPENDENCIES, Bindings.BOOLEAN)) {
- System.out.println(child + " -> " + parent);
+ if (parent != null && !inferred) {
+ try {
+ if(!child.isImmutable(graph))
+ child.addParent(parent);
+ } catch (DatabaseException e) {
+ LOGGER.error("Error while registering query dependencies", e);
+ }
+ if (Development.DEVELOPMENT) {
+ if(Development.<Boolean>getProperty(DevelopmentKeys.QUERYPROCESSOR_DEPENDENCIES, Bindings.BOOLEAN)) {
+ System.out.println(child + " -> " + parent);
+ }
}
}
- }
- if (listener != null)
- registerListener(child, listener, procedure);
+ if (listener != null)
+ registerListener(child, listener, procedure);
- });
+ });
+ } catch (InterruptedException e) {
+ LOGGER.error("Error while registering dependencies", e);
+ }
}
final public Session session;
final public ResourceSupport resourceSupport;
+ final public Semaphore requests = new Semaphore(1);
+
final public QueryListening listening = new QueryListening(this);
QueryThread[] executors;
-
-// public ArrayList<SessionTask>[] queues;
public LinkedList<SessionTask> freeScheduling = new LinkedList<SessionTask>();
}
public ThreadState[] threadStates;
-// public ReentrantLock[] threadLocks;
-// public Condition[] threadConditions;
-
- //public ArrayList<SessionTask>[] ownTasks;
-
- //public ArrayList<SessionTask>[] ownSyncTasks;
-
- //ArrayList<SessionTask>[] delayQueues;
final Object querySupportLock;
public void close() {
}
- public SessionTask getOwnTask(ReadGraphImpl impl) {
- Set<ReadGraphImpl> ancestors = impl.ancestorSet();
- synchronized(querySupportLock) {
- int index = 0;
- while(index < freeScheduling.size()) {
- SessionTask task = freeScheduling.get(index);
- if(task.hasCommonParent(ancestors)) {
- return freeScheduling.remove(index);
- }
- index++;
- }
- }
- return null;
- }
-
public SessionTask getSubTask(ReadGraphImpl impl) {
- Set<ReadGraphImpl> onlyThis = Collections.singleton(impl);
synchronized(querySupportLock) {
int index = 0;
while(index < freeScheduling.size()) {
SessionTask task = freeScheduling.get(index);
- if(task.hasCommonParent(onlyThis)) {
+ if(task.hasCommonParent(task.graph, impl) && task.maybeReady()) {
+ queueLength.decrementAndGet();
return freeScheduling.remove(index);
}
index++;
return null;
}
- public boolean performPending(ReadGraphImpl graph) {
- SessionTask task = getOwnTask(graph);
+ /*
+ * We are running errands while waiting for requests to complete.
+ * We can only run work that is part of the current root request to avoid any deadlocks
+ */
+ public boolean performPending(ReadGraphImpl graph) {
+ SessionTask task = getSubTask(graph);
if(task != null) {
task.run(QueryProcessor.thread.get());
return true;
- } else {
- return false;
}
+ return false;
}
-// final public void scheduleOwn(int caller, SessionTask request) {
-// ownTasks[caller].add(request);
-// }
-
- final public void schedule(SessionTask request) {
-
- //int performer = request.thread;
-
-// if(DebugPolicy.SCHEDULE)
-// System.out.println("schedule " + request + " " + " -> " + performer);
+ final public void scheduleNow(SessionTask request) {
+ schedule(request, false);
+ }
- //assert(performer >= 0);
+ final public void scheduleLater(SessionTask request) {
+ schedule(request, true);
+ }
+ AtomicInteger queueLength = new AtomicInteger(0);
+
+ final public void schedule(SessionTask request, boolean late) {
+
+ int queueLengthEstimate = queueLength.get();
+ if(!late && queueLengthEstimate > 80) {
+ request.run(thread.get());
+ return;
+ }
+
assert(request != null);
+
+ synchronized(querySupportLock) {
-// if(caller == performer) {
-// request.run(caller);
-// } else {
-
-// if(performer == THREADS) {
-
- synchronized(querySupportLock) {
-
- if(BarrierTracing.BOOKKEEPING) {
- Exception current = new Exception();
- Exception previous = BarrierTracing.tasks.put(request, current);
- if(previous != null) {
- previous.printStackTrace();
- current.printStackTrace();
- }
- }
-
- freeScheduling.add(request);
-
- querySupportLock.notifyAll();
+ if(BarrierTracing.BOOKKEEPING) {
+ Exception current = new Exception();
+ Exception previous = BarrierTracing.tasks.put(request, current);
+ if(previous != null) {
+ previous.printStackTrace();
+ current.printStackTrace();
+ }
+ }
- }
+ if(late) {
+ int pos = request.position - 1;
+ if(pos < freeScheduling.size()) {
+ freeScheduling.add(pos, request);
+ queueLength.incrementAndGet();
+ requests.release();
+ } else {
+ freeScheduling.addLast(request);
+ queueLength.incrementAndGet();
+ requests.release();
+ }
+ }
+ else {
+ if(request.getLevel() < 4) {
+ if(freeScheduling.size() < 100) {
+ freeScheduling.addFirst(request);
+ queueLength.incrementAndGet();
+ requests.release();
+ } else {
+ request.run(thread.get());
+ }
+ } else {
+ if(freeScheduling.size() < 20) {
+ freeScheduling.addFirst(request);
+ queueLength.incrementAndGet();
+ requests.release();
+ } else {
+ request.run(thread.get());
+ }
+ }
+ }
- return;
-
-// }
-//
-// ReentrantLock queueLock = threadLocks[performer];
-// queueLock.lock();
-// queues[performer].add(request);
-// // This thread could have been sleeping
-// if(queues[performer].size() == 1) {
-// //if(ThreadState.SLEEP == threadStates[performer]) sleepers.decrementAndGet();
-// threadConditions[performer].signalAll();
-// }
-// queueLock.unlock();
-// }
+
+ }
}
public static abstract class SessionTask {
public final ReadGraphImpl graph;
- private Set<ReadGraphImpl> ancestors;
private int counter = 0;
+ protected int position = 1;
private Exception trace;
public SessionTask(ReadGraphImpl graph) {
if(graph != null) graph.asyncBarrier.inc();
}
- public boolean hasCommonParent(Set<ReadGraphImpl> otherAncestors) {
- if(graph == null) return false;
- if(ancestors == null) ancestors = graph.ancestorSet();
- return !Collections.disjoint(ancestors, otherAncestors);
- }
+ public static boolean hasCommonParent(ReadGraphImpl r1, ReadGraphImpl r2) {
+ if(r1 == null || r2 == null) return false;
+ return r1.getTopLevelGraph() == r2.getTopLevelGraph();
+ }
- public abstract void run0(int thread);
+ public abstract void run0(int thread);
public final void run(int thread) {
if(counter++ > 0) {
run0(thread);
if(graph != null) graph.asyncBarrier.dec();
}
+
+ public boolean maybeReady() {
+ return true;
+ }
@Override
public String toString() {
- return "SessionTask[" + graph.parent + "]";
+ if(graph == null)
+ return "SessionTask[no graph]";
+ else
+ return "SessionTask[" + graph.parent + "]";
+ }
+
+ public int getLevel() {
+ if(graph == null) return 0;
+ else return graph.getLevel();
}
}
@Override
protected void doDispose() {
+ requests.release(Integer.MAX_VALUE / 2);
+
for(int index = 0; index < THREADS; index++) {
executors[index].dispose();
}
private Session session;
private QuerySupport querySupport;
private final QueryProcessor processor;
+ private final Semaphore requests;
final private ArrayList<SessionTask> tasks = new ArrayList<SessionTask>();
// final private ArrayList<SessionTask> own;
sleepers = processor.sleepers;
querySupport = processor.querySupport;
threadStates = processor.threadStates;
+ requests = processor.requests;
// delayQueues = processor.delayQueues;
// executors = processor.executors;
// threadLocks = processor.threadLocks;
private boolean pumpTask() {
if(!processor.freeScheduling.isEmpty()) {
tasks.add(processor.freeScheduling.removeFirst());
+ processor.queueLength.decrementAndGet();
return true;
}
return false;
threadStates[index] = ThreadState.SLEEP;
- synchronized (querySupportLock) {
- querySupportLock.wait(100);
-
- }
-
-// boolean woken = condition.await(10, TimeUnit.MILLISECONDS);
-// if(!woken) {
-// synchronized (querySupportLock) {
-// if(!processor.freeScheduling.isEmpty())
-// System.err.println("some tasks are available!");
-// }
-// }
+ requests.acquire();
sleepers.decrementAndGet();
CollectionSupport coll = graph.getService(CollectionSupport.class);
THashSet<Resource> visited = new THashSet<>();
- List<Resource> rec = findRec(graph, index, filter, visited);
+ List<Resource> rec_ = findRec(graph, index, filter, visited);
+ // We must not modify rec_!
+ List<Resource> rec = rec_;
for(Resource global : Layer0Utils.listGlobalOntologies(graph)) {
if(!visited.add(global)) continue;
List<Resource> rs = graph.syncRequest(new QueryIndex(global, type, filter), TransientCacheListener.<List<Resource>>instance());
- if(rec.isEmpty() && !rs.isEmpty()) {
- // TODO: rec could be an immutable empty list
- rec = new ArrayList<Resource>();
+ if(!rs.isEmpty()) {
+ if(rec == rec_)
+ rec = new ArrayList<>(rec);
+ rec.addAll(rs);
}
- rec.addAll(rs);
}
Collection<Resource> result = coll.asSortedList(rec);
return result;
public synchronized void startRead(int thread, final SessionRead task) {
- session.queryProvider2.schedule(new SessionTask(null) {
+ session.queryProvider2.scheduleNow(new SessionTask(null) {
@Override
public void run0(int thread) {
public synchronized void startReadUpdate(int thread) {
- session.queryProvider2.schedule(new SessionTask(null) {
+ session.queryProvider2.scheduleNow(new SessionTask(null) {
@Override
public void run0(int thread) {
public synchronized void startWrite(int thread, final SessionTask task) {
- session.queryProvider2.schedule(new SessionTask(null) {
+ session.queryProvider2.scheduleNow(new SessionTask(null) {
@Override
public void run0(int thread) {
public synchronized void startWriteUpdate(int thread) {
- session.queryProvider2.schedule(new SessionTask(null) {
+ session.queryProvider2.scheduleNow(new SessionTask(null) {
@Override
public void run0(int thread) {
if (!reads.isEmpty()) {
final SessionRead read = reads.poll();
- session.queryProvider2.schedule(new SessionTask(null) {
+ session.queryProvider2.scheduleNow(new SessionTask(null) {
@Override
public void run0(int thread) {
assert(State.INIT != state);
if(State.READ == state) {
- session.queryProvider2.schedule(new SessionTask(null) {
+ session.queryProvider2.scheduleNow(new SessionTask(null) {
@Override
public void run0(int thread) {
Code Review / simantics / platform.git / commitdiff