From: Tuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Date: Fri, 5 Mar 2021 10:51:19 +0000 (+0200)
Subject: Always close written file explicitly in StringIO.{writeLines,appendLine}
X-Git-Url: https://gerrit.simantics.org/r/gitweb?a=commitdiff_plain;ds=sidebyside;h=e596119a728be94c77e43d54be2b9402c596db2f;hp=7654cd8a5a5676eccb5cc9e0e3daadd5beea8537;p=simantics%2Fplatform.git

Always close written file explicitly in StringIO.{writeLines,appendLine}

gitlab #675

(cherry picked from commit 3969cd4b3fbbe35583656c3f48d6ba4902baa9e5)
---

diff --git a/bundles/org.simantics.scl.runtime/src/org/simantics/scl/runtime/procedure/StringIO.java b/bundles/org.simantics.scl.runtime/src/org/simantics/scl/runtime/procedure/StringIO.java
index 82d3a9f32..1e1f5ef69 100644
--- a/bundles/org.simantics.scl.runtime/src/org/simantics/scl/runtime/procedure/StringIO.java
+++ b/bundles/org.simantics.scl.runtime/src/org/simantics/scl/runtime/procedure/StringIO.java
@@ -38,20 +38,20 @@ public class StringIO {
     }
 
     public static void writeLines(String fileName, List<String> lines) throws IOException {
-        BufferedWriter writer = Files.newBufferedWriter(Paths.get(fileName), UTF8);
-        for(String line : lines) {
-            writer.write(line);
-            writer.write("\n");
+        try (BufferedWriter writer = Files.newBufferedWriter(Paths.get(fileName), UTF8)) {
+            for(String line : lines) {
+                writer.write(line);
+                writer.write("\n");
+            }
         }
-        writer.close();
     }
     
     public static void appendLine(String fileName, String line) throws IOException {
-        BufferedWriter writer = Files.newBufferedWriter(Paths.get(fileName), UTF8,
-                StandardOpenOption.CREATE, StandardOpenOption.APPEND);
-        writer.write(line);
-        writer.write("\n");
-        writer.close();
+        try (BufferedWriter writer = Files.newBufferedWriter(Paths.get(fileName), UTF8,
+                StandardOpenOption.CREATE, StandardOpenOption.APPEND)) {
+            writer.write(line);
+            writer.write("\n");
+        }
     }
 
 }