From: Tuukka Lehtonen Date: Tue, 28 Aug 2018 04:55:12 +0000 (+0000) Subject: Merge changes I2aa561cb,I9eb9be8a X-Git-Tag: v1.43.0~136^2~399 X-Git-Url: https://gerrit.simantics.org/r/gitweb?a=commitdiff_plain;h=e0334c5555088193846c692743067db8e43548d6;hp=25f90625263911a40f785edbeb8ca44b3db23911;p=simantics%2Fplatform.git Merge changes I2aa561cb,I9eb9be8a * changes: Avoid unnecessary ElementClass validation work Switch MapList to use Java HashMap --- diff --git a/bundles/org.simantics.diagram/src/org/simantics/diagram/adapter/GraphToDiagramSynchronizer.java b/bundles/org.simantics.diagram/src/org/simantics/diagram/adapter/GraphToDiagramSynchronizer.java index 9be80c34e..2b72b3e0f 100644 --- a/bundles/org.simantics.diagram/src/org/simantics/diagram/adapter/GraphToDiagramSynchronizer.java +++ b/bundles/org.simantics.diagram/src/org/simantics/diagram/adapter/GraphToDiagramSynchronizer.java @@ -762,7 +762,7 @@ public class GraphToDiagramSynchronizer extends AbstractDisposable implements ID else result.add(eh); } - return ElementClass.compile(result).setId(ec.getId()); + return ElementClass.compile(result, false).setId(ec.getId()); } } diff --git a/bundles/org.simantics.g2d/src/org/simantics/g2d/element/ElementClass.java b/bundles/org.simantics.g2d/src/org/simantics/g2d/element/ElementClass.java index aaea7654d..5d6897601 100644 --- a/bundles/org.simantics.g2d/src/org/simantics/g2d/element/ElementClass.java +++ b/bundles/org.simantics.g2d/src/org/simantics/g2d/element/ElementClass.java @@ -93,13 +93,11 @@ public final class ElementClass extends AbstractHandlerClass { */ public static ElementClass compile(Collection contributions) { - assertClassValid(contributions); return new ElementClass(contributions); } public static ElementClass compile(Collection contributions, boolean check) { - if(check) assertClassValid(contributions); return new ElementClass(contributions, check); } diff --git a/bundles/org.simantics.utils.datastructures/src/org/simantics/utils/datastructures/MapList.java b/bundles/org.simantics.utils.datastructures/src/org/simantics/utils/datastructures/MapList.java index 900c4b701..cdfa9f782 100644 --- a/bundles/org.simantics.utils.datastructures/src/org/simantics/utils/datastructures/MapList.java +++ b/bundles/org.simantics.utils.datastructures/src/org/simantics/utils/datastructures/MapList.java @@ -14,11 +14,10 @@ */ package org.simantics.utils.datastructures; -import gnu.trove.map.hash.THashMap; - import java.util.ArrayList; import java.util.Collection; import java.util.Collections; +import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Map.Entry; @@ -73,7 +72,7 @@ public class MapList { protected Map> lists; public MapList() { - lists = new THashMap>(); + lists = new HashMap>(); } @SuppressWarnings("unchecked")