From: jsimomaa <jani.simomaa@gmail.com>
Date: Thu, 15 Jun 2017 06:32:53 +0000 (+0300)
Subject: TransferableGraphUtils.getObjects2 for fixing not-found handling
X-Git-Tag: v1.31.0~315
X-Git-Url: https://gerrit.simantics.org/r/gitweb?a=commitdiff_plain;h=e623710df8c9c090b01df901d3e807c6d26cfbf7;p=simantics%2Fplatform.git

TransferableGraphUtils.getObjects2 for fixing not-found handling

refs #7306

Change-Id: I1d8dfefb51d579b1cb5ca9e15df82c0a8e347619
---

diff --git a/bundles/org.simantics.graph/src/org/simantics/graph/representation/TransferableGraphUtils.java b/bundles/org.simantics.graph/src/org/simantics/graph/representation/TransferableGraphUtils.java
index 5b40113ae..b210d8dd7 100644
--- a/bundles/org.simantics.graph/src/org/simantics/graph/representation/TransferableGraphUtils.java
+++ b/bundles/org.simantics.graph/src/org/simantics/graph/representation/TransferableGraphUtils.java
@@ -146,22 +146,53 @@ public class TransferableGraphUtils {
 		return result;
 	}
 	
+    /**
+     * This implementation is no longer advised to use because it returns 0 as
+     * NOT_FOUND which is in fact a valid ID for resource in graph
+     */
+	@Deprecated
 	public static int getPossibleObject(TransferableGraph1 tg, int subject, Identity predicate) {
 		int result = 0;
 		for(int i=0;i<tg.statements.length;i+=4) {
 			if(tg.statements[i] == subject && tg.statements[i+1] == predicate.resource) {
-				if(result != 0) return 0;
+				if(result != 0 && tg.statements[i+3] != result) return 0;
 				result = tg.statements[i+3];
 			}
 		}
 		return result;
 	}
+
+	public static final int NOT_FOUND = -2;
+
+	public static int getPossibleObject2(TransferableGraph1 tg, int subject, Identity predicate) {
+	    int result = NOT_FOUND;
+        for(int i=0;i<tg.statements.length;i+=4) {
+            if(tg.statements[i] == subject && tg.statements[i+1] == predicate.resource) {
+                if(result != NOT_FOUND && tg.statements[i+3] != result)
+                    return NOT_FOUND;
+                result = tg.statements[i+3];
+            }
+        }
+        return result;
+	}
 	
+	/**
+	 * @return 0 for presenting not found which is BAD
+	 * @see getPossibleObject2
+	 */
+	@Deprecated
 	public static int getPossibleObject(TransferableGraph1 tg, Identity subject, String predicate) {
 		Identity p = findExternal(tg, predicate);
 		if(p == null) return 0;
 		return getPossibleObject(tg, subject.resource, p);
 	}
+	
+    public static int getPossibleObject2(TransferableGraph1 tg, Identity subject, String predicate) {
+        Identity p = findExternal(tg, predicate);
+        if (p == null)
+            return NOT_FOUND;
+        return getPossibleObject2(tg, subject.resource, p);
+    }
 
 	public static Map<Identity, String> getNames(TransferableGraph1 tg, Collection<Identity> ids) {
 		Map<Identity, String> result = new HashMap<Identity, String>();