From: Reino Ruusu <reino.ruusu@semantum.fi>
Date: Wed, 6 May 2020 08:44:41 +0000 (+0300)
Subject: No insertion of straight pipe in straight pipe
X-Git-Tag: v1.43.0~13
X-Git-Url: https://gerrit.simantics.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F17%2F4217%2F1;p=simantics%2F3d.git

No insertion of straight pipe in straight pipe

gitlab #127

Change-Id: I2e16805bb406fb940eb327453e746edb324e261d
---

diff --git a/org.simantics.plant3d/src/org/simantics/plant3d/dialog/ComponentSelectionDialog.java b/org.simantics.plant3d/src/org/simantics/plant3d/dialog/ComponentSelectionDialog.java
index 2911be36..dc00915f 100644
--- a/org.simantics.plant3d/src/org/simantics/plant3d/dialog/ComponentSelectionDialog.java
+++ b/org.simantics.plant3d/src/org/simantics/plant3d/dialog/ComponentSelectionDialog.java
@@ -3,6 +3,7 @@ package org.simantics.plant3d.dialog;
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.List;
+import java.util.ListIterator;
 import java.util.Set;
 
 import org.eclipse.jface.dialogs.Dialog;
@@ -233,12 +234,22 @@ public class ComponentSelectionDialog extends Dialog implements ISelectionChange
 
 		ExpandBar expandBar = new ExpandBar(composite, SWT.V_SCROLL);
 
+		boolean isOpen = component.getNext() == null || component.getPrevious() == null;
 		if (!inlines.isEmpty()) {
+			if (!isOpen) {
+				// Remove variable length pipe from options
+				ListIterator<Item> it = inlines.listIterator();
+				while (it.hasNext()) {
+					Item item = it.next();
+					if (item.isVariable())
+						it.remove();
+				}
+			}
+			
 			inlineViewer = createItemList(expandBar, inlines, "Inline");
 		}
 
 		// Only allow elbows and ends to be added to open ends of the pipelines
-		boolean isOpen = component.getNext() == null || component.getPrevious() == null;
 		if (isOpen) {
 			if (!turns.isEmpty()) {
 				turnViewer = createItemList(expandBar, turns, "Elbow");