]> gerrit.simantics Code Review - simantics/3d.git/log
simantics/3d.git
4 years agoFix direction calculations in addComponent() 93/3993/1
Reino Ruusu [Fri, 13 Mar 2020 09:48:45 +0000 (11:48 +0200)]
Fix direction calculations in addComponent()

Change direction returned by getDirection(PREVIOUS) so that it matches
the expectations of calling routines and is consistent with other
direction vector getters.

gitlab #110

Change-Id: I003d7c720f7643aedb5d545648bda1148cb96315

4 years agoFix interpretation of turn angle in InsertInstruction 92/3992/1
Reino Ruusu [Thu, 12 Mar 2020 13:52:46 +0000 (15:52 +0200)]
Fix interpretation of turn angle in InsertInstruction

gitlab #109

Change-Id: Ibf7085e95281f1049c493a7f3d5e65344cc52a8e

4 years agoFix error in assigment of component name for new components 91/3991/1
Reino Ruusu [Thu, 12 Mar 2020 13:50:07 +0000 (15:50 +0200)]
Fix error in assigment of component name for new components

gitlab #74

Change-Id: Ie7b4b9b7459763031176039de9b448f54f9f490f

4 years agoFix bug in adding a component before a nozzle 90/3990/1
Reino Ruusu [Thu, 12 Mar 2020 13:45:54 +0000 (15:45 +0200)]
Fix bug in adding a component before a nozzle

gitlab #108

Change-Id: Ie5a95734baf5ba573d3ee0a0b345a6583abee924

4 years agoIntroduce orientToDirection() method to pipe control point 89/3989/1
Reino Ruusu [Thu, 12 Mar 2020 13:39:46 +0000 (15:39 +0200)]
Introduce orientToDirection() method to pipe control point

gitlab #107

Change-Id: I5aacab0b0a25e5dcd695bfb92beeda24ddb37adc

4 years agoRefactoring of PipeControlPoint.getPathLegDirection() 88/3988/1
Reino Ruusu [Thu, 12 Mar 2020 13:15:52 +0000 (15:15 +0200)]
Refactoring of PipeControlPoint.getPathLegDirection()

gitlab #107

Change-Id: Ic6f04155c1552597aa80ebdacbc58dcab6ad56c2

4 years agoFix error in checking of changes in rotation angle 87/3987/1
Reino Ruusu [Thu, 12 Mar 2020 13:10:10 +0000 (15:10 +0200)]
Fix error in checking of changes in rotation angle

gitlab #90

Change-Id: Id0c6c071382d62a01aaaaeacb2b2ff220c118f91

4 years agoFix validation message for turn angle values in component selection 86/3986/1
Reino Ruusu [Thu, 12 Mar 2020 13:07:05 +0000 (15:07 +0200)]
Fix validation message for turn angle values in component selection

gitlab #105

Change-Id: Iaca69cf570f1d47e4b7df26fdfe4b03f09149fe8

4 years agoAllow insertion of components at the ends of straight segments 84/3984/1
Reino Ruusu [Tue, 10 Mar 2020 14:29:15 +0000 (16:29 +0200)]
Allow insertion of components at the ends of straight segments

gitlab #106

Change-Id: I20b12339d82ca6da52d9b69ec0f34656c5cb3555

4 years agoFix regression in synchronization of updates 83/3983/1
Reino Ruusu [Tue, 10 Mar 2020 14:25:39 +0000 (16:25 +0200)]
Fix regression in synchronization of updates

gitlab #92

* Too much locking of syncMutex in AbstractVTKNodeMap::update()

Change-Id: Iccfe4063076eb8e205511581d6b7d252142d7014

4 years agoAdd checks for invalid numerical values in ComponentSelectionDialog 78/3978/1
Reino Ruusu [Mon, 9 Mar 2020 11:51:55 +0000 (13:51 +0200)]
Add checks for invalid numerical values in ComponentSelectionDialog

gitlab #105

Also add a validation message to the user

Change-Id: I93a6843faf2c76fbed1ef3c32dc06c24a7a28358

4 years agoUse inside diameter for eccentric reducer offset calculation 77/3977/1
Reino Ruusu [Mon, 9 Mar 2020 09:20:27 +0000 (11:20 +0200)]
Use inside diameter for eccentric reducer offset calculation

gitlab #104

Change-Id: I60b7056ac1bc30ecb85e46fd2b3cff4e3fcaf71d

4 years agoAdd a wall thickness property to pipe runs. 76/3976/1
Reino Ruusu [Mon, 9 Mar 2020 09:03:21 +0000 (11:03 +0200)]
Add a wall thickness property to pipe runs.

gitlab #104

Change-Id: Ib21da6f7aee8c2bb1aa74b9a43cdf72264e9f689

4 years agoEat all keyboard events by default in vtkSwtAction 74/3974/1
Reino Ruusu [Fri, 6 Mar 2020 16:41:29 +0000 (18:41 +0200)]
Eat all keyboard events by default in vtkSwtAction

gitlab #103

Change-Id: I709b93ffcf83f37e3253a224874ab10b710f913f

4 years agoMerge "Move global UI bindings to the product plugin"
Tuukka Lehtonen [Fri, 6 Mar 2020 15:44:37 +0000 (15:44 +0000)]
Merge "Move global UI bindings to the product plugin"

4 years agoMove global UI bindings to the product plugin 73/3973/2
Reino Ruusu [Fri, 6 Mar 2020 15:16:42 +0000 (17:16 +0200)]
Move global UI bindings to the product plugin

gitlab #101

Change-Id: I83c0e42c400579cd3709b78146a5b07cdeac82d1

4 years agoClose Plant3DEditor automatically when its input disappears from DB 71/3971/1
Tuukka Lehtonen [Thu, 5 Mar 2020 21:32:32 +0000 (23:32 +0200)]
Close Plant3DEditor automatically when its input disappears from DB

gitlab #102

Change-Id: Ifeaf13c1c9f8e000dbcd7a5ef4e6351ae1cff1a2

4 years agoTools for fitting contents to view in Plant3D editor 69/3969/1
Reino Ruusu [Thu, 5 Mar 2020 13:58:25 +0000 (15:58 +0200)]
Tools for fitting contents to view in Plant3D editor

gitlab #100

Also fixes clipping in parallel projection mode by keeping scale and
camera distance at values that match the camera view angle.

Change-Id: I82ad77bdc339fa0ad7814c31fcac97512c440972

4 years agoFix camera focus method to handle special case of vertical direction. 67/3967/1
Reino Ruusu [Thu, 5 Mar 2020 10:49:50 +0000 (12:49 +0200)]
Fix camera focus method to handle special case of vertical direction.

gitlab #99

Change-Id: I61deefb45e8e4be993a6e4699042a550dda89707

4 years agoButton for default viewing direction 66/3966/1
Reino Ruusu [Thu, 5 Mar 2020 09:18:44 +0000 (11:18 +0200)]
Button for default viewing direction

gitlab #98

Change-Id: I896a1a0a2d5647cbd0563d7a7c4e47180f00cda1

4 years agoShow an error dialog when attempting to insert a too long component 60/3960/1
Reino Ruusu [Mon, 2 Mar 2020 12:24:19 +0000 (14:24 +0200)]
Show an error dialog when attempting to insert a too long component

gitlab #97

Change-Id: I9f6b6b0fb7c0a9fc0a9f1b93b081d4041f5499c9

4 years agoUpdates elbows when turn radius is changed in pipe run 59/3959/1
Reino Ruusu [Mon, 2 Mar 2020 11:48:00 +0000 (13:48 +0200)]
Updates elbows when turn radius is changed in pipe run

gitlab #95

Change-Id: I9174814d63382f0035cd4705b3d8eb28982de573

4 years agoCamera rotation with stable rotation speed 54/3954/1
Reino Ruusu [Mon, 2 Mar 2020 09:24:54 +0000 (11:24 +0200)]
Camera rotation with stable rotation speed

gitlab #96

Change-Id: Iaf9a1a42f04dcf83f168e2fe0aa691c26876b024

4 years agoPerform node map updates in a procedure instead of a request 50/3950/1
Reino Ruusu [Mon, 2 Mar 2020 08:09:50 +0000 (10:09 +0200)]
Perform node map updates in a procedure instead of a request

gitlab #92

Change-Id: I5aa6238360d84ca9c9df0c8ee1c3671ff118485c

4 years agoFix list indexing error in updateFixedLengths. 41/3941/1
Reino Ruusu [Fri, 28 Feb 2020 07:57:06 +0000 (09:57 +0200)]
Fix list indexing error in updateFixedLengths.

gitlab #94

Change-Id: I70402e5ca920b44bfc0fa0647429c12595cca08b

4 years agoRemove edge visualization from solid objects when not highlighted 35/3935/1
Reino Ruusu [Wed, 26 Feb 2020 13:37:10 +0000 (15:37 +0200)]
Remove edge visualization from solid objects when not highlighted

gitlab #93

Change-Id: If76196f017db4ddd416541a0c57bf7b9018d2df6

4 years agoRestore SCL-compatible API to P3DUtil 34/3934/2
Reino Ruusu [Wed, 26 Feb 2020 12:28:50 +0000 (14:28 +0200)]
Restore SCL-compatible API to P3DUtil

P3DUtil.scl was broken by d207cfa3235339e7d7b894494be400160b121bd5

gitlab #88

Change-Id: I047f0e94ca8f3320097be2b64cbbc3dbbf62b6bd

4 years agoBlock parallel execution of position updates and validation. 10/3910/2
Reino Ruusu [Tue, 25 Feb 2020 14:09:27 +0000 (16:09 +0200)]
Block parallel execution of position updates and validation.

gitlab #92

Change-Id: I591afd4ee115a322e4edd6ad87aa3da89c453f9a

4 years agoFix issue with multiple degenerate legs in front of a nozzle 09/3909/2
Reino Ruusu [Tue, 25 Feb 2020 14:00:18 +0000 (16:00 +0200)]
Fix issue with multiple degenerate legs in front of a nozzle

gitlab #91

Change-Id: I458db0787a0b2be4282df4619bcfdaab674e3ef1

4 years agoRemove listener calls when property values not updated. 08/3908/2
Reino Ruusu [Mon, 24 Feb 2020 18:40:36 +0000 (20:40 +0200)]
Remove listener calls when property values not updated.

gitlab #90

Change-Id: Ic3e4097cc19fb9ebd295052f9a5f0c57ad39328a

4 years agoShow busy cursor and block UI input while committing changes 07/3907/1
Reino Ruusu [Mon, 24 Feb 2020 17:23:53 +0000 (19:23 +0200)]
Show busy cursor and block UI input while committing changes

gitlab #89

Change-Id: I7caab1ef604c0024ab24dd34e2c52385e84dc10e

4 years agoEnable model loading using an existing transaction. 03/3903/1
Reino Ruusu [Mon, 24 Feb 2020 14:56:00 +0000 (16:56 +0200)]
Enable model loading using an existing transaction.

gitlab #88

Change-Id: I1c594b284d716a9e428c04f0f3076afcd0001806

4 years agoProper description for plant3d.modeling feature 00/3900/1
Tuukka Lehtonen [Sun, 23 Feb 2020 10:54:54 +0000 (12:54 +0200)]
Proper description for plant3d.modeling feature

gitlab #70

Change-Id: I55812591e2aab607e6bb5b78fe0d45f589684263

4 years agoDisabled includePackedArtifacts to prevent pack200 artifacts
Tuukka Lehtonen [Sun, 23 Feb 2020 01:01:00 +0000 (03:01 +0200)]
Disabled includePackedArtifacts to prevent pack200 artifacts

gitlab simantics/platform#468

4 years agoStop using pack200 because it has been deprecated and removed
Tuukka Lehtonen [Sun, 23 Feb 2020 00:26:39 +0000 (02:26 +0200)]
Stop using pack200 because it has been deprecated and removed

Deprecated in Java 11 https://openjdk.java.net/jeps/336 and removed
in Java 14 https://openjdk.java.net/jeps/367.

The main problem for us now is that the packed JARs don't get
signed when using maven-jarsigner-plugin, while the unpacked
ones do. Simplest solution is to let go of pack200 already.

gitlab simantics/platform#468

4 years agoRotation angle fully in context of the path leg delta 95/3895/1
Reino Ruusu [Thu, 20 Feb 2020 16:31:32 +0000 (18:31 +0200)]
Rotation angle fully in context of the path leg delta

gitlab #81

Change-Id: I4f03b62450af42e5680f9e689e6f2fd699184007

4 years agoFix cause of endless loop in overlap resolution 94/3894/1
Reino Ruusu [Thu, 20 Feb 2020 16:27:26 +0000 (18:27 +0200)]
Fix cause of endless loop in overlap resolution

gitlab #86

Change-Id: I256a7c12e168410ef2ff3be4c08a77208448734b

4 years agoFix error in PipingRules.updateFixedLengths 93/3893/1
Reino Ruusu [Thu, 20 Feb 2020 15:44:02 +0000 (17:44 +0200)]
Fix error in PipingRules.updateFixedLengths

gitlab #86

Change-Id: I21e90ec653096797aa0f011f687baafabb6621d3

4 years agoPerform view direction switching via vtkCameraAndSelectorAction 92/3892/1
Reino Ruusu [Thu, 20 Feb 2020 14:30:43 +0000 (16:30 +0200)]
Perform view direction switching via vtkCameraAndSelectorAction

gitlab #85

Change-Id: Ie15464b9eaed7060ac6bacca534b4ff2c39da896

4 years agoLet root node determine up direction for rotation angle calculations 91/3891/1
Reino Ruusu [Thu, 20 Feb 2020 14:28:50 +0000 (16:28 +0200)]
Let root node determine up direction for rotation angle calculations

gitlab #85

Change-Id: I549af4f0b93cbf3867e334165db8c2dacee12968

4 years agoFix interpretation of rotation angle to path leg end point vector 89/3889/1
Reino Ruusu [Thu, 20 Feb 2020 13:32:42 +0000 (15:32 +0200)]
Fix interpretation of rotation angle to path leg end point vector

gitlab #81

Change-Id: I64745f3b4f99215d77ac2bf44c7b038eb0282a78

4 years agoAllow selection of vertical direction in Plant3DEditor 83/3883/1
Reino Ruusu [Wed, 19 Feb 2020 15:04:06 +0000 (17:04 +0200)]
Allow selection of vertical direction in Plant3DEditor

gitlab #85

Change-Id: Ib5491a4ec233a9516a4087f270343194f28f7d96

4 years agoUse maven jarsigner to sign the produced P2 repository contents
Tuukka Lehtonen [Tue, 18 Feb 2020 13:32:51 +0000 (15:32 +0200)]
Use maven jarsigner to sign the produced P2 repository contents

gitlab #84

4 years agoAllow unsplitting removal of reducers by joining pipe runs 72/3872/1
Reino Ruusu [Fri, 14 Feb 2020 14:56:16 +0000 (16:56 +0200)]
Allow unsplitting removal of reducers by joining pipe runs

gitlab #83

Change-Id: Ia47d7234caae13eee3c23ffa72d8d4950c38070e

4 years agoFix update of inline components with offsets 71/3871/1
Reino Ruusu [Fri, 14 Feb 2020 12:20:42 +0000 (14:20 +0200)]
Fix update of inline components with offsets

gitlab #82

Change-Id: I735a8756886f16c7a7d6b877fc240039ff8322c8

4 years agoFix handling of offsets in directed path leg updates 70/3870/1
Reino Ruusu [Fri, 14 Feb 2020 12:19:52 +0000 (14:19 +0200)]
Fix handling of offsets in directed path leg updates

gitlab #79

Change-Id: Ib2c15821a3a147249c0465469973cb81c454fa18

4 years agoFix handling offset in dual directed path leg updates 68/3868/1
Reino Ruusu [Thu, 13 Feb 2020 10:13:30 +0000 (12:13 +0200)]
Fix handling offset in dual directed path leg updates

gitlab #79

Change-Id: I1e42037ec8832751e4a92eaca84f47479c35aaa7

4 years agoAdded a length scaling factor for adding components 67/3867/1
Reino Ruusu [Wed, 12 Feb 2020 14:12:57 +0000 (16:12 +0200)]
Added a length scaling factor for adding components

gitlab #78

Change-Id: Ied89a7f8289aad1e0ca952c4fb51e40df93fc811

4 years agoFix orientation of new straight components in insertStraight 62/3862/1
Reino Ruusu [Tue, 11 Feb 2020 11:55:37 +0000 (13:55 +0200)]
Fix orientation of new straight components in insertStraight

gitlab #77

Change-Id: Ic04f7ac4e12297ee6cfa830b428dd4fe2dd70951

4 years agoFix synchronization of PipingRules.currentUpdates. 60/3860/1
Reino Ruusu [Tue, 11 Feb 2020 07:33:41 +0000 (09:33 +0200)]
Fix synchronization of PipingRules.currentUpdates.

gitlab #76

Change-Id: I2a9a7566f5775d5f71552e39da65f2429be91e69

4 years agoRename Vector3d.length to vectorLength 58/3858/1
Reino Ruusu [Fri, 7 Feb 2020 11:06:23 +0000 (13:06 +0200)]
Rename Vector3d.length to vectorLength

gitlab #75

Change-Id: I5e189d234f2f810415cd233731c1aa11674e1f67

4 years agoMake component addition dialog resizable and remember last dimensions 54/3854/2
Tuukka Lehtonen [Thu, 6 Feb 2020 20:36:22 +0000 (22:36 +0200)]
Make component addition dialog resizable and remember last dimensions

gitlab #73

Change-Id: I95f9e61cd930f5fc8dca46d45839e89510768b55

4 years agoMerge "Allow user to specify component name in ComponentSelectionDialog"
Tuukka Lehtonen [Thu, 6 Feb 2020 15:41:34 +0000 (15:41 +0000)]
Merge "Allow user to specify component name in ComponentSelectionDialog"

4 years agoAllow user to specify component name in ComponentSelectionDialog 55/3855/1
Reino Ruusu [Thu, 6 Feb 2020 14:48:03 +0000 (16:48 +0200)]
Allow user to specify component name in ComponentSelectionDialog

gitlab #74

Change-Id: I3a9ea061ceadeb48a92ecee1644015de51457abd

4 years agoFixed loading order problem that caused parameters to never get updated 53/3853/1
Tuukka Lehtonen [Thu, 6 Feb 2020 13:57:09 +0000 (15:57 +0200)]
Fixed loading order problem that caused parameters to never get updated

gitlab #72

Change-Id: I9dc5673e41de56d25f550c72d86f15791c8d1851

4 years agoAdded labels to piping component types 19/3819/1
Reino Ruusu [Wed, 29 Jan 2020 13:10:04 +0000 (15:10 +0200)]
Added labels to piping component types

gitlab #71

Change-Id: I956bb0ce2d9c449d805ee476f688bc9117926e7d

4 years agoAdded bundle metadata 85/3785/1 release/1.42.0
Tuukka Lehtonen [Tue, 14 Jan 2020 23:50:53 +0000 (01:50 +0200)]
Added bundle metadata

gitlab #70

Change-Id: Ie2a62b6d6253083258a57a2ecb94ddf47496cbb6

5 years agoFix getRealPosition() for control points 09/3709/1
Reino Ruusu [Thu, 12 Dec 2019 13:55:39 +0000 (15:55 +0200)]
Fix getRealPosition() for control points

gitlab #69

Change-Id: Iade27e651baddff4d0a3138d2f7fc85391f2dcbb

5 years agoFix createRotation() and avoid unnecessary trigonometrics roundtrip 95/3695/1
Reino Ruusu [Tue, 10 Dec 2019 18:30:55 +0000 (20:30 +0200)]
Fix createRotation() and avoid unnecessary trigonometrics roundtrip

gitlab #68

Change-Id: Ib5acbb46055fe52f75059092ef47ce0d37d69891

5 years agoExpose offset calculation as API in PipingRules. 94/3694/1
Reino Ruusu [Tue, 10 Dec 2019 17:28:27 +0000 (19:28 +0200)]
Expose offset calculation as API in PipingRules.

Change-Id: I60f154afe0ed87e6fa2e853c3daf1701f33a3bd9

5 years agoFix issue in directed path updates with offsets 93/3693/3
Reino Ruusu [Tue, 10 Dec 2019 16:09:22 +0000 (18:09 +0200)]
Fix issue in directed path updates with offsets

gitlab #67

Change-Id: I9547e20b1364b16c7a3e83eaba2e968a1a6d73e7

5 years agoGet inline component direction irrespectively of connectivity 92/3692/2
Reino Ruusu [Tue, 10 Dec 2019 12:59:27 +0000 (14:59 +0200)]
Get inline component direction irrespectively of connectivity

gitlab #35

Change-Id: Iea337594e8220c91deff469b4f80d7df12a82266

5 years agoAllow insertion of reducers in the middle of pipe runs 91/3691/1
Reino Ruusu [Tue, 10 Dec 2019 12:37:50 +0000 (14:37 +0200)]
Allow insertion of reducers in the middle of pipe runs

gitlab #66

Change-Id: Iccf79d8178718cb6dd64033e30ed52729f6c88eb

5 years agoEliminate rounding errors in property tabs. 88/3688/2
Reino Ruusu [Thu, 5 Dec 2019 14:21:33 +0000 (16:21 +0200)]
Eliminate rounding errors in property tabs.

gitlab #64

Change-Id: I8bb9978c99a612d841c41645c0a89ab381557b79

5 years agoForce zero offset for concentric reducers 87/3687/1
Marko Luukkainen [Thu, 5 Dec 2019 13:39:54 +0000 (15:39 +0200)]
Force zero offset for concentric reducers

gitlab #65

Change-Id: I7a38605d1bb089286b48bccf4d00fdfcd32d78c3
(cherry picked from commit 8b4cdc730d95283475ba5c4639a534215118b94a)

5 years agoMerge "Allow property editing with just a single mouse click" release/1.41.0
Marko Luukkainen [Thu, 5 Dec 2019 13:32:14 +0000 (13:32 +0000)]
Merge "Allow property editing with just a single mouse click"

5 years agoMerge "Fix issue with cell editor type mismatch and disable user-entered values"
Marko Luukkainen [Thu, 5 Dec 2019 13:23:47 +0000 (13:23 +0000)]
Merge "Fix issue with cell editor type mismatch and disable user-entered values"

5 years agoMerge "Refuse attempts to set turn radius index to a negative value."
Marko Luukkainen [Thu, 5 Dec 2019 13:09:58 +0000 (13:09 +0000)]
Merge "Refuse attempts to set turn radius index to a negative value."

5 years agoFix directed path leg update failing to update inline lengths 80/3680/1
Marko Luukkainen [Thu, 5 Dec 2019 12:31:00 +0000 (14:31 +0200)]
Fix directed path leg update failing to update inline lengths

Changed PipeControlPoint.getPathLegDirection to return normalized
vectors, or null.

Also, now Plant3D editor reports PipingRule errors happening during
model load.

gitlab #35

Change-Id: I159db0a8f04ed69df0b98fd859a4bf0fd58427de
(cherry picked from commit 61ce1ae33f46cf6d73a8d0ec151dcf1cd27db49f)

5 years agoAllow property editing with just a single mouse click 78/3678/1
Reino Ruusu [Thu, 5 Dec 2019 11:56:16 +0000 (13:56 +0200)]
Allow property editing with just a single mouse click

gitlab #62

Change-Id: Idcbc1644787316cced9d90481d44759fd754325a

5 years agoFix issue with cell editor type mismatch and disable user-entered values 77/3677/1
Reino Ruusu [Thu, 5 Dec 2019 11:55:38 +0000 (13:55 +0200)]
Fix issue with cell editor type mismatch and disable user-entered values

gitlab #62

Change-Id: I57d6f6c69fed6c8b840cc0a5011f802e29a96fb3

5 years agoRefuse attempts to set turn radius index to a negative value. 76/3676/1
Reino Ruusu [Thu, 5 Dec 2019 11:52:38 +0000 (13:52 +0200)]
Refuse attempts to set turn radius index to a negative value.

gitlab #63

Change-Id: I98564e31efb7ba483c7b5dd4a3988098889bb134

5 years agoMerge "Fix removed nodes leaving visible graphical elements."
Marko Luukkainen [Thu, 5 Dec 2019 10:23:11 +0000 (10:23 +0000)]
Merge "Fix removed nodes leaving visible graphical elements."

5 years agoFix removed nodes leaving visible graphical elements. 75/3675/1
Marko Luukkainen [Thu, 5 Dec 2019 09:16:58 +0000 (11:16 +0200)]
Fix removed nodes leaving visible graphical elements.

When a node was removed and updated at the same cycle, it:
1. Was removed
2. Graphics were updated, which added graphics back to the visualization

gitlab #35

Change-Id: Ic512d450ea015f6969dd901558b36caaa88754bd
(cherry picked from commit cf6b9ba427c210e1074d51bbc5712486f80930ec)

5 years agoYesterdays change introduced infinite loop for directed path leg updates 74/3674/1
Marko Luukkainen [Thu, 5 Dec 2019 09:07:58 +0000 (11:07 +0200)]
Yesterdays change introduced infinite loop for directed path leg updates

Fine tuned elbow space calculation.

gitlab #14

Change-Id: Ic0505c5e55d0f90f41bcdd7f8b26d11d189d6582
(cherry picked from commit a899aac9dd52296206f302a20a8e7bae2501cf2c)

5 years agoDirected path leg update handled offset wrong way. 70/3670/1
Marko Luukkainen [Wed, 4 Dec 2019 14:29:48 +0000 (16:29 +0200)]
Directed path leg update handled offset wrong way.

Additionally, removed debug messages.

gitlab #12

Change-Id: I8abab7e87115a1ce9439fed4d70a9e0973ed5ca8
(cherry picked from commit a53efc63bed07331a3a2f9879f266e41cbe738cb)

5 years agoPrevent elbows overlapping nozzles 67/3667/1
Marko Luukkainen [Wed, 4 Dec 2019 11:54:06 +0000 (13:54 +0200)]
Prevent elbows overlapping nozzles

gitlab #14

Change-Id: I9ecfa4dced7a48d2e7312986dd10be7b9a88bfae
(cherry picked from commit cc43aabf1f80291c17ece22060fbb0e690fb4864)

5 years agoFix path leg updates when reducer is the first or the last component. 65/3665/1
Marko Luukkainen [Tue, 3 Dec 2019 13:59:37 +0000 (15:59 +0200)]
Fix path leg updates when reducer is the first or the last component.

Additionally fixed control removal on reducer boundary.

gitlab #61

Change-Id: Iadcb1b410acde45e23e4cd9a4a592fb6b8e6d294
(cherry picked from commit dc44eb5c7d3c8f35faf9bab80b9432d60ea203ea)

5 years agoDisable DB level undo, when model modifying actions are active 63/3663/1
Marko Luukkainen [Tue, 3 Dec 2019 12:37:32 +0000 (14:37 +0200)]
Disable DB level undo, when model modifying actions are active

gitlab #60

Change-Id: Idf996ffa7ee87eac42ecd1118c4a4bd99aa0cc2c
(cherry picked from commit 0a4af0014e06aa2f295bed0b4ab94c3a2bab37f3)

5 years agoRevised update logic for inline components 61/3661/1
Marko Luukkainen [Tue, 3 Dec 2019 11:49:36 +0000 (13:49 +0200)]
Revised update logic for inline components

* PipingRules no longer have separate code for path legs with offsets
* Overlapping fixed length components are forced to be separate, as long
as there is available space
* Using more stable calculation for turn component orientations (reusing
path leg direction vector)
* Error messages of overlapping inline components

gitlab #14
gitlab #59

Change-Id: I85e754ffb6dab37ca7b7ae8e5f28842fbf095a11
(cherry picked from commit aca223a1616159645710d7c9ee67ed1a6bd47b99)

5 years agoShowing error messages when components overlap each other 59/3659/1
Marko Luukkainen [Mon, 2 Dec 2019 12:53:07 +0000 (14:53 +0200)]
Showing error messages when components overlap each other

* Removed code that forced PipingRules to iterate whole connected
segment.
* Adjusted PipingRule excecution on editor load.
* Fixed inline coomponent updated, when the component was also path leg
end.
* Fixed variable length adjusting / removal code.

gitlab #59

Change-Id: I4e1152f2a37b9a7cc7f93f18a9cf54616c62bbfd
(cherry picked from commit 3c9eba53de061b8c5c5863dc05855dc0e71781b1)

5 years agoConverting variable angle turn turn to fixed angle could fail. 48/3648/1
Marko Luukkainen [Fri, 29 Nov 2019 12:34:50 +0000 (14:34 +0200)]
Converting variable angle turn turn to fixed angle could fail.

Calculating rotating angle from input and output directions was using 0
- PI restricted angle calculation, where expected result was -PI - PI

gitlab #46

Change-Id: I08956dc40009c4fea17883b7a6caf8468db8bf7f
(cherry picked from commit b9efd234b46a0c15a9ee034592b90d72f18480fe)

5 years agoProcessing DB changes could leave control points unsynchronized 46/3646/1
Marko Luukkainen [Fri, 29 Nov 2019 11:44:12 +0000 (13:44 +0200)]
Processing DB changes could leave control points unsynchronized

When processing DB changes, component connections could be created
before control points (especially Nozzle). This could cause a situation,
where components were connected, but control points were not.

gitlab #35

Change-Id: Ida35c3222dbc706c7cb0e481af41feeca0949809
(cherry picked from commit 944164586441e68cd62073de3995a2455be9680a)

5 years agoHandle PipeRun removals with detaching Components. 44/3644/1
Marko Luukkainen [Fri, 29 Nov 2019 10:44:52 +0000 (12:44 +0200)]
Handle PipeRun removals with detaching Components.

Some operations can move Components between PipeRuns. If we create a
PipeRun within such operation, and the undo the modification, removal of
the created PipeRun may remove Components before they are attached to
their original PipeRuns.

1. Now PipeRun removal detaches Components, so that Component structure
remains intact.
2. PipeCOntrolPoint removal work without PipeRun.
3. AbstractVTKNodeMap calls INode.remove() all removed nodes.

gitlab #35

Change-Id: I37ec56302581ab176fe630c91b3cddb301ad1210
(cherry picked from commit f346390a5a8cd4262a9aa68951e55d504d412549)

5 years agoRemove/Split could go over PipeRun boundary and break reducers. 40/3640/1
Marko Luukkainen [Thu, 28 Nov 2019 15:49:56 +0000 (17:49 +0200)]
Remove/Split could go over PipeRun boundary and break reducers.

gitlab #33

Change-Id: Ieb76bf130b1baaed040ffff38aa950bc0461d7c9
(cherry picked from commit 81c2595de58576c1d0f8220633557a1c77c623de)

5 years agoAllow adding adjustable length components in the middle of a pipe 39/3639/1
Marko Luukkainen [Thu, 28 Nov 2019 15:39:13 +0000 (17:39 +0200)]
Allow adding adjustable length components in the middle of a pipe

gitlab #26

Change-Id: Iafc06d7553984033a1e085866bf3f21536dd7e3c
(cherry picked from commit f8e541f1d66cda57802da11aaa715b9f9c1c79a9)

5 years agoAllow repeated single clicks to activate property editing 16/3616/1
Reino Ruusu [Mon, 25 Nov 2019 11:51:50 +0000 (13:51 +0200)]
Allow repeated single clicks to activate property editing

gitlab #58

Change-Id: I34c98ec258b08e25cd2aa6305644437804a1cf94

5 years agoReflection-based handling of Enum property editing. 15/3615/1
Reino Ruusu [Mon, 25 Nov 2019 11:50:14 +0000 (13:50 +0200)]
Reflection-based handling of Enum property editing.

gitlab #57

Change-Id: Ifab41fbf38d1e56b36fc561763ce9200cd18c358

5 years agoAllow property tab contribution from all INodes. 01/3601/1
Reino Ruusu [Fri, 22 Nov 2019 10:40:17 +0000 (12:40 +0200)]
Allow property tab contribution from all INodes.

gitlab #56

Change-Id: If6e7bc5138f22378c700c4fb9b4104990a622023

5 years agoUp-to-date ontology class for Plant3D ontology 00/3600/1
Reino Ruusu [Fri, 22 Nov 2019 10:03:58 +0000 (12:03 +0200)]
Up-to-date ontology class for Plant3D ontology

Change-Id: I846a32fa0dadde3b6847dce280217dc5a29289ca

5 years agoMerge "Ask component rotation angle when adding components"
Marko Luukkainen [Mon, 18 Nov 2019 14:30:57 +0000 (14:30 +0000)]
Merge "Ask component rotation angle when adding components"

5 years agoAsk component rotation angle when adding components 59/3559/1
Marko Luukkainen [Mon, 18 Nov 2019 13:24:56 +0000 (15:24 +0200)]
Ask component rotation angle when adding components

gitlab #13

Change-Id: I13cbd9905fe6a0fa123375b44a88b15fe84067e7
(cherry picked from commit 15e688c6d6148fdbda457e5f55bdea4259c97aa8)

5 years agoAdding specified equipment with nozzles did not work 58/3558/1
Marko Luukkainen [Mon, 18 Nov 2019 13:21:40 +0000 (15:21 +0200)]
Adding specified equipment with nozzles did not work

Constructor nozzle parameter was not stored...

gitlab #27

Change-Id: I4f353edaf1c6a33a6c2c6ce8b377c8b11d55b483
(cherry picked from commit ec0ebd74b66427ce92c64eda89d58a0117137eb6)

5 years agoMissing library URI from Equipment selection dialog parameters. 55/3555/1
Marko Luukkainen [Mon, 18 Nov 2019 11:40:11 +0000 (13:40 +0200)]
Missing library URI from Equipment selection dialog parameters.

gitlab #27

Change-Id: I306467532238c87293d1a9def905e475ec7d3c0a
(cherry picked from commit 0493ab7d61ff3049d9e22fba9c062c3983028143)

5 years agoCreating equipment with predefined nozzles. 53/3553/1
Marko Luukkainen [Mon, 18 Nov 2019 11:27:16 +0000 (13:27 +0200)]
Creating equipment with predefined nozzles.

gitlab #27

Change-Id: I67d32b141c5c526d0215f5af3fd309d64962f49a
(cherry picked from commit 9817ec2aa0d2afada7024d2aba0cd7562de317ed)

5 years agoPrevious change caused ClassCastExceptions. 41/3541/1
Marko Luukkainen [Fri, 15 Nov 2019 15:32:41 +0000 (17:32 +0200)]
Previous change caused ClassCastExceptions.

gitlab #26

Change-Id: I018a488b099be724828f636fe91e6d1e2903f3dc
(cherry picked from commit c451ced35ae144dbe52d7f09d8eed128c9e644ee)

5 years agoAdjust turn component radius with combo box (instead of index value) 32/3532/1
Marko Luukkainen [Fri, 15 Nov 2019 13:48:22 +0000 (15:48 +0200)]
Adjust turn component radius with combo box (instead of index value)

gitlab #43

Change-Id: I5e5c5193c73bbad93c3eaa12fc58f1bc3a0598b8
(cherry picked from commit eb221ba65b20ba9e8477c653e1c10ae1c2a0a4d0)

5 years agoCombo property support for annotated property tabs 30/3530/1
Marko Luukkainen [Fri, 15 Nov 2019 13:44:00 +0000 (15:44 +0200)]
Combo property support for annotated property tabs

gitlab #55

Change-Id: I4fde018ed47ccdc9f82e59bac51272ffebd8244b
(cherry picked from commit 79528578707a2103753d895b520fdc6439f52d3e)

5 years agoTag user modifiable length 28/3528/1
Marko Luukkainen [Fri, 15 Nov 2019 11:49:33 +0000 (13:49 +0200)]
Tag user modifiable length

With modifiable tag, we can ask for length parameter when we insert new
components

gitlab #26

Change-Id: Ic98a1b491bb8223d28bdca570af5fc792df3fe6c
(cherry picked from commit daa07327bd3222487742965d433ea2f041e5ae73)

5 years agoLoading VTK dlls with plug-in activator. 22/3522/1
Marko Luukkainen [Thu, 14 Nov 2019 15:38:15 +0000 (17:38 +0200)]
Loading VTK dlls with plug-in activator.

gitlab #50

Change-Id: Iae39a7d1e38e48156a532b5002b7c88edfa1d709
(cherry picked from commit 3523a218827de60e1aa4ce7be126342418ddb054)