]>
gerrit.simantics Code Review - simantics/3d.git/log
Reino Ruusu [Tue, 21 Apr 2020 15:29:01 +0000 (18:29 +0300)]
Avoid extra write transactions when opening Plant3D editor
gitlab #122
Change-Id: I2e20e8e460a3d7e8d4b0fb786d77166fb8c9dbd5
(cherry picked from commit
d7128a534435161910ce5865db60c7874091df74 )
Reino Ruusu [Mon, 20 Apr 2020 09:53:18 +0000 (12:53 +0300)]
Take values from pipe run as defaults for reducers
gitlab #121
Change-Id: I641b4a0acb69bf3e381afdb6bb1aa22873ea4a79
(cherry picked from commit
5c5214c358806f286aa53f32de57e18568b5f166 )
Reino Ruusu [Mon, 20 Apr 2020 08:20:45 +0000 (11:20 +0300)]
Only show elbows and ends when adding to an open pipe end.
gitlab #120
Change-Id: I947fdfa5939ce110cfa82310e9437f6e281e4599
(cherry picked from commit
f5438b7d35bfb66014369bae22dc3daddbff6498 )
Reino Ruusu [Wed, 15 Apr 2020 10:21:31 +0000 (13:21 +0300)]
Replace "turn" with "elbow" in component creation UI
gitlab #119
Change-Id: I7603e65b9be2fa3fa437160ddc4ea1663328a8b5
(cherry picked from commit
2cbc32fe5cdad29f250d8de32d6cc7f4648a16aa )
Tuukka Lehtonen [Wed, 8 Apr 2020 20:28:11 +0000 (23:28 +0300)]
Added vtkCameraAndSelectorAction.setViewDir(Vector3d)
Allows setting the camera view direction without changing the focal
point.
gitlab #118
Change-Id: I33421fb46e05c62892a396203681838131b0b382
(cherry picked from commit
6325452591b2a854f82ac913fe4f61e3df2f922d )
Tuukka Lehtonen [Wed, 8 Apr 2020 06:29:39 +0000 (09:29 +0300)]
Minor improvement for Plant3DEditor extensibility
* AbstractVTKNodeMap needs an overridable postCommit() method which is
executed after doCommit() finishes successfully. This is needed in an
extending editor to know the first moment in time when the editor has
been initialized properly.
* Allow customization of FitToWindow action created by Plant3DEditor
gitlab #117
Change-Id: I50a36740e579664ddab83b659b79220b5d33c135
(cherry picked from commit
370a955304d3aeacfdd59aa42d875c6142499dfd )
Reino Ruusu [Tue, 7 Apr 2020 10:17:21 +0000 (13:17 +0300)]
Hide insertion position controls when adding to a connected pipe
gitlab #112
Change-Id: Ifebee86babe1a869e9dec1bffe4efaa47aa454d5
(cherry picked from commit
6bdca885df3dd6e0ff4d0baccffd98f7b94833aa )
Reino Ruusu [Tue, 7 Apr 2020 09:46:30 +0000 (12:46 +0300)]
Fix division by zero in ComponentUtls.addComponent()
gitlab #116
Change-Id: Ia0be7bf31ec74f04262a3cc2cdf86cea119ee02f
(cherry picked from commit
f6ac6d85a7207ba0c60ed17bfbd0c2dac8fc735c )
Reino Ruusu [Tue, 7 Apr 2020 07:27:39 +0000 (10:27 +0300)]
Fix getControlPointEnds() for end components
gitlab #115
Change-Id: I55806b0b8545351a3162b5455102c31a49f4d59a
(cherry picked from commit
1cd59e8997dc9cc0a31c876ecc2bed92cf3a81f2 )
Reino Ruusu [Mon, 6 Apr 2020 12:10:44 +0000 (15:10 +0300)]
Fix error in inserting dual inline components
gitlab #114
Change-Id: I454b7bb51c5b1cbdde8169e2556bb1049387349d
(cherry picked from commit
a745e75910247c95f7a9a5f4cc0598e2ca0cf95e )
Reino Ruusu [Mon, 6 Apr 2020 07:58:15 +0000 (10:58 +0300)]
Add check for presence of pipe runs when updating offset
gitlab #113
Change-Id: I300758575e0fac2181090fdc6afc276f1ab630a1
Reino Ruusu [Wed, 1 Apr 2020 13:07:07 +0000 (16:07 +0300)]
Update offset values to reflect changes in pipe run parameters
gitlab #113
Change-Id: Iea589d15afd9fada0d73f9ecd5cea15f4531c7bd
Reino Ruusu [Wed, 1 Apr 2020 11:46:20 +0000 (14:46 +0300)]
Disable insertion position buttons when inserting to a connected pipe
gitlab #112
Change-Id: I7629729cd22768a4995e4bf18288e2a4f41ecae0
Reino Ruusu [Fri, 13 Mar 2020 16:25:30 +0000 (18:25 +0200)]
Fix issues in offset calculations in directed path legs
gitlab #111
Change-Id: Ia430f5c602c8dca0522493ab42a8f925f159ccf6
Reino Ruusu [Fri, 13 Mar 2020 09:48:45 +0000 (11:48 +0200)]
Fix direction calculations in addComponent()
Change direction returned by getDirection(PREVIOUS) so that it matches
the expectations of calling routines and is consistent with other
direction vector getters.
gitlab #110
Change-Id: I003d7c720f7643aedb5d545648bda1148cb96315
Reino Ruusu [Thu, 12 Mar 2020 13:52:46 +0000 (15:52 +0200)]
Fix interpretation of turn angle in InsertInstruction
gitlab #109
Change-Id: Ibf7085e95281f1049c493a7f3d5e65344cc52a8e
Reino Ruusu [Thu, 12 Mar 2020 13:50:07 +0000 (15:50 +0200)]
Fix error in assigment of component name for new components
gitlab #74
Change-Id: Ie7b4b9b7459763031176039de9b448f54f9f490f
Reino Ruusu [Thu, 12 Mar 2020 13:45:54 +0000 (15:45 +0200)]
Fix bug in adding a component before a nozzle
gitlab #108
Change-Id: Ie5a95734baf5ba573d3ee0a0b345a6583abee924
Reino Ruusu [Thu, 12 Mar 2020 13:39:46 +0000 (15:39 +0200)]
Introduce orientToDirection() method to pipe control point
gitlab #107
Change-Id: I5aacab0b0a25e5dcd695bfb92beeda24ddb37adc
Reino Ruusu [Thu, 12 Mar 2020 13:15:52 +0000 (15:15 +0200)]
Refactoring of PipeControlPoint.getPathLegDirection()
gitlab #107
Change-Id: Ic6f04155c1552597aa80ebdacbc58dcab6ad56c2
Reino Ruusu [Thu, 12 Mar 2020 13:10:10 +0000 (15:10 +0200)]
Fix error in checking of changes in rotation angle
gitlab #90
Change-Id: Id0c6c071382d62a01aaaaeacb2b2ff220c118f91
Reino Ruusu [Thu, 12 Mar 2020 13:07:05 +0000 (15:07 +0200)]
Fix validation message for turn angle values in component selection
gitlab #105
Change-Id: Iaca69cf570f1d47e4b7df26fdfe4b03f09149fe8
Reino Ruusu [Tue, 10 Mar 2020 14:29:15 +0000 (16:29 +0200)]
Allow insertion of components at the ends of straight segments
gitlab #106
Change-Id: I20b12339d82ca6da52d9b69ec0f34656c5cb3555
Reino Ruusu [Tue, 10 Mar 2020 14:25:39 +0000 (16:25 +0200)]
Fix regression in synchronization of updates
gitlab #92
* Too much locking of syncMutex in AbstractVTKNodeMap::update()
Change-Id: Iccfe4063076eb8e205511581d6b7d252142d7014
Reino Ruusu [Mon, 9 Mar 2020 11:51:55 +0000 (13:51 +0200)]
Add checks for invalid numerical values in ComponentSelectionDialog
gitlab #105
Also add a validation message to the user
Change-Id: I93a6843faf2c76fbed1ef3c32dc06c24a7a28358
Reino Ruusu [Mon, 9 Mar 2020 09:20:27 +0000 (11:20 +0200)]
Use inside diameter for eccentric reducer offset calculation
gitlab #104
Change-Id: I60b7056ac1bc30ecb85e46fd2b3cff4e3fcaf71d
Reino Ruusu [Mon, 9 Mar 2020 09:03:21 +0000 (11:03 +0200)]
Add a wall thickness property to pipe runs.
gitlab #104
Change-Id: Ib21da6f7aee8c2bb1aa74b9a43cdf72264e9f689
Reino Ruusu [Fri, 6 Mar 2020 16:41:29 +0000 (18:41 +0200)]
Eat all keyboard events by default in vtkSwtAction
gitlab #103
Change-Id: I709b93ffcf83f37e3253a224874ab10b710f913f
Tuukka Lehtonen [Fri, 6 Mar 2020 15:44:37 +0000 (15:44 +0000)]
Merge "Move global UI bindings to the product plugin"
Reino Ruusu [Fri, 6 Mar 2020 15:16:42 +0000 (17:16 +0200)]
Move global UI bindings to the product plugin
gitlab #101
Change-Id: I83c0e42c400579cd3709b78146a5b07cdeac82d1
Tuukka Lehtonen [Thu, 5 Mar 2020 21:32:32 +0000 (23:32 +0200)]
Close Plant3DEditor automatically when its input disappears from DB
gitlab #102
Change-Id: Ifeaf13c1c9f8e000dbcd7a5ef4e6351ae1cff1a2
Reino Ruusu [Thu, 5 Mar 2020 13:58:25 +0000 (15:58 +0200)]
Tools for fitting contents to view in Plant3D editor
gitlab #100
Also fixes clipping in parallel projection mode by keeping scale and
camera distance at values that match the camera view angle.
Change-Id: I82ad77bdc339fa0ad7814c31fcac97512c440972
Reino Ruusu [Thu, 5 Mar 2020 10:49:50 +0000 (12:49 +0200)]
Fix camera focus method to handle special case of vertical direction.
gitlab #99
Change-Id: I61deefb45e8e4be993a6e4699042a550dda89707
Reino Ruusu [Thu, 5 Mar 2020 09:18:44 +0000 (11:18 +0200)]
Button for default viewing direction
gitlab #98
Change-Id: I896a1a0a2d5647cbd0563d7a7c4e47180f00cda1
Reino Ruusu [Mon, 2 Mar 2020 12:24:19 +0000 (14:24 +0200)]
Show an error dialog when attempting to insert a too long component
gitlab #97
Change-Id: I9f6b6b0fb7c0a9fc0a9f1b93b081d4041f5499c9
Reino Ruusu [Mon, 2 Mar 2020 11:48:00 +0000 (13:48 +0200)]
Updates elbows when turn radius is changed in pipe run
gitlab #95
Change-Id: I9174814d63382f0035cd4705b3d8eb28982de573
Reino Ruusu [Mon, 2 Mar 2020 09:24:54 +0000 (11:24 +0200)]
Camera rotation with stable rotation speed
gitlab #96
Change-Id: Iaf9a1a42f04dcf83f168e2fe0aa691c26876b024
Reino Ruusu [Mon, 2 Mar 2020 08:09:50 +0000 (10:09 +0200)]
Perform node map updates in a procedure instead of a request
gitlab #92
Change-Id: I5aa6238360d84ca9c9df0c8ee1c3671ff118485c
Reino Ruusu [Fri, 28 Feb 2020 07:57:06 +0000 (09:57 +0200)]
Fix list indexing error in updateFixedLengths.
gitlab #94
Change-Id: I70402e5ca920b44bfc0fa0647429c12595cca08b
Reino Ruusu [Wed, 26 Feb 2020 13:37:10 +0000 (15:37 +0200)]
Remove edge visualization from solid objects when not highlighted
gitlab #93
Change-Id: If76196f017db4ddd416541a0c57bf7b9018d2df6
Reino Ruusu [Wed, 26 Feb 2020 12:28:50 +0000 (14:28 +0200)]
Restore SCL-compatible API to P3DUtil
P3DUtil.scl was broken by
d207cfa3235339e7d7b894494be400160b121bd5
gitlab #88
Change-Id: I047f0e94ca8f3320097be2b64cbbc3dbbf62b6bd
Reino Ruusu [Tue, 25 Feb 2020 14:09:27 +0000 (16:09 +0200)]
Block parallel execution of position updates and validation.
gitlab #92
Change-Id: I591afd4ee115a322e4edd6ad87aa3da89c453f9a
Reino Ruusu [Tue, 25 Feb 2020 14:00:18 +0000 (16:00 +0200)]
Fix issue with multiple degenerate legs in front of a nozzle
gitlab #91
Change-Id: I458db0787a0b2be4282df4619bcfdaab674e3ef1
Reino Ruusu [Mon, 24 Feb 2020 18:40:36 +0000 (20:40 +0200)]
Remove listener calls when property values not updated.
gitlab #90
Change-Id: Ic3e4097cc19fb9ebd295052f9a5f0c57ad39328a
Reino Ruusu [Mon, 24 Feb 2020 17:23:53 +0000 (19:23 +0200)]
Show busy cursor and block UI input while committing changes
gitlab #89
Change-Id: I7caab1ef604c0024ab24dd34e2c52385e84dc10e
Reino Ruusu [Mon, 24 Feb 2020 14:56:00 +0000 (16:56 +0200)]
Enable model loading using an existing transaction.
gitlab #88
Change-Id: I1c594b284d716a9e428c04f0f3076afcd0001806
Tuukka Lehtonen [Sun, 23 Feb 2020 10:54:54 +0000 (12:54 +0200)]
Proper description for plant3d.modeling feature
gitlab #70
Change-Id: I55812591e2aab607e6bb5b78fe0d45f589684263
Tuukka Lehtonen [Sun, 23 Feb 2020 01:01:00 +0000 (03:01 +0200)]
Disabled includePackedArtifacts to prevent pack200 artifacts
gitlab simantics/platform#468
Tuukka Lehtonen [Sun, 23 Feb 2020 00:26:39 +0000 (02:26 +0200)]
Stop using pack200 because it has been deprecated and removed
Deprecated in Java 11 https://openjdk.java.net/jeps/336 and removed
in Java 14 https://openjdk.java.net/jeps/367.
The main problem for us now is that the packed JARs don't get
signed when using maven-jarsigner-plugin, while the unpacked
ones do. Simplest solution is to let go of pack200 already.
gitlab simantics/platform#468
Reino Ruusu [Thu, 20 Feb 2020 16:31:32 +0000 (18:31 +0200)]
Rotation angle fully in context of the path leg delta
gitlab #81
Change-Id: I4f03b62450af42e5680f9e689e6f2fd699184007
Reino Ruusu [Thu, 20 Feb 2020 16:27:26 +0000 (18:27 +0200)]
Fix cause of endless loop in overlap resolution
gitlab #86
Change-Id: I256a7c12e168410ef2ff3be4c08a77208448734b
Reino Ruusu [Thu, 20 Feb 2020 15:44:02 +0000 (17:44 +0200)]
Fix error in PipingRules.updateFixedLengths
gitlab #86
Change-Id: I21e90ec653096797aa0f011f687baafabb6621d3
Reino Ruusu [Thu, 20 Feb 2020 14:30:43 +0000 (16:30 +0200)]
Perform view direction switching via vtkCameraAndSelectorAction
gitlab #85
Change-Id: Ie15464b9eaed7060ac6bacca534b4ff2c39da896
Reino Ruusu [Thu, 20 Feb 2020 14:28:50 +0000 (16:28 +0200)]
Let root node determine up direction for rotation angle calculations
gitlab #85
Change-Id: I549af4f0b93cbf3867e334165db8c2dacee12968
Reino Ruusu [Thu, 20 Feb 2020 13:32:42 +0000 (15:32 +0200)]
Fix interpretation of rotation angle to path leg end point vector
gitlab #81
Change-Id: I64745f3b4f99215d77ac2bf44c7b038eb0282a78
Reino Ruusu [Wed, 19 Feb 2020 15:04:06 +0000 (17:04 +0200)]
Allow selection of vertical direction in Plant3DEditor
gitlab #85
Change-Id: Ib5491a4ec233a9516a4087f270343194f28f7d96
Tuukka Lehtonen [Tue, 18 Feb 2020 13:32:51 +0000 (15:32 +0200)]
Use maven jarsigner to sign the produced P2 repository contents
gitlab #84
Reino Ruusu [Fri, 14 Feb 2020 14:56:16 +0000 (16:56 +0200)]
Allow unsplitting removal of reducers by joining pipe runs
gitlab #83
Change-Id: Ia47d7234caae13eee3c23ffa72d8d4950c38070e
Reino Ruusu [Fri, 14 Feb 2020 12:20:42 +0000 (14:20 +0200)]
Fix update of inline components with offsets
gitlab #82
Change-Id: I735a8756886f16c7a7d6b877fc240039ff8322c8
Reino Ruusu [Fri, 14 Feb 2020 12:19:52 +0000 (14:19 +0200)]
Fix handling of offsets in directed path leg updates
gitlab #79
Change-Id: Ib2c15821a3a147249c0465469973cb81c454fa18
Reino Ruusu [Thu, 13 Feb 2020 10:13:30 +0000 (12:13 +0200)]
Fix handling offset in dual directed path leg updates
gitlab #79
Change-Id: I1e42037ec8832751e4a92eaca84f47479c35aaa7
Reino Ruusu [Wed, 12 Feb 2020 14:12:57 +0000 (16:12 +0200)]
Added a length scaling factor for adding components
gitlab #78
Change-Id: Ied89a7f8289aad1e0ca952c4fb51e40df93fc811
Reino Ruusu [Tue, 11 Feb 2020 11:55:37 +0000 (13:55 +0200)]
Fix orientation of new straight components in insertStraight
gitlab #77
Change-Id: Ic04f7ac4e12297ee6cfa830b428dd4fe2dd70951
Reino Ruusu [Tue, 11 Feb 2020 07:33:41 +0000 (09:33 +0200)]
Fix synchronization of PipingRules.currentUpdates.
gitlab #76
Change-Id: I2a9a7566f5775d5f71552e39da65f2429be91e69
Reino Ruusu [Fri, 7 Feb 2020 11:06:23 +0000 (13:06 +0200)]
Rename Vector3d.length to vectorLength
gitlab #75
Change-Id: I5e189d234f2f810415cd233731c1aa11674e1f67
Tuukka Lehtonen [Thu, 6 Feb 2020 20:36:22 +0000 (22:36 +0200)]
Make component addition dialog resizable and remember last dimensions
gitlab #73
Change-Id: I95f9e61cd930f5fc8dca46d45839e89510768b55
Tuukka Lehtonen [Thu, 6 Feb 2020 15:41:34 +0000 (15:41 +0000)]
Merge "Allow user to specify component name in ComponentSelectionDialog"
Reino Ruusu [Thu, 6 Feb 2020 14:48:03 +0000 (16:48 +0200)]
Allow user to specify component name in ComponentSelectionDialog
gitlab #74
Change-Id: I3a9ea061ceadeb48a92ecee1644015de51457abd
Tuukka Lehtonen [Thu, 6 Feb 2020 13:57:09 +0000 (15:57 +0200)]
Fixed loading order problem that caused parameters to never get updated
gitlab #72
Change-Id: I9dc5673e41de56d25f550c72d86f15791c8d1851
Reino Ruusu [Wed, 29 Jan 2020 13:10:04 +0000 (15:10 +0200)]
Added labels to piping component types
gitlab #71
Change-Id: I956bb0ce2d9c449d805ee476f688bc9117926e7d
Tuukka Lehtonen [Tue, 14 Jan 2020 23:50:53 +0000 (01:50 +0200)]
Added bundle metadata
gitlab #70
Change-Id: Ie2a62b6d6253083258a57a2ecb94ddf47496cbb6
Reino Ruusu [Thu, 12 Dec 2019 13:55:39 +0000 (15:55 +0200)]
Fix getRealPosition() for control points
gitlab #69
Change-Id: Iade27e651baddff4d0a3138d2f7fc85391f2dcbb
Reino Ruusu [Tue, 10 Dec 2019 18:30:55 +0000 (20:30 +0200)]
Fix createRotation() and avoid unnecessary trigonometrics roundtrip
gitlab #68
Change-Id: Ib5acbb46055fe52f75059092ef47ce0d37d69891
Reino Ruusu [Tue, 10 Dec 2019 17:28:27 +0000 (19:28 +0200)]
Expose offset calculation as API in PipingRules.
Change-Id: I60f154afe0ed87e6fa2e853c3daf1701f33a3bd9
Reino Ruusu [Tue, 10 Dec 2019 16:09:22 +0000 (18:09 +0200)]
Fix issue in directed path updates with offsets
gitlab #67
Change-Id: I9547e20b1364b16c7a3e83eaba2e968a1a6d73e7
Reino Ruusu [Tue, 10 Dec 2019 12:59:27 +0000 (14:59 +0200)]
Get inline component direction irrespectively of connectivity
gitlab #35
Change-Id: Iea337594e8220c91deff469b4f80d7df12a82266
Reino Ruusu [Tue, 10 Dec 2019 12:37:50 +0000 (14:37 +0200)]
Allow insertion of reducers in the middle of pipe runs
gitlab #66
Change-Id: Iccf79d8178718cb6dd64033e30ed52729f6c88eb
Reino Ruusu [Thu, 5 Dec 2019 14:21:33 +0000 (16:21 +0200)]
Eliminate rounding errors in property tabs.
gitlab #64
Change-Id: I8bb9978c99a612d841c41645c0a89ab381557b79
Marko Luukkainen [Thu, 5 Dec 2019 13:39:54 +0000 (15:39 +0200)]
Force zero offset for concentric reducers
gitlab #65
Change-Id: I7a38605d1bb089286b48bccf4d00fdfcd32d78c3
(cherry picked from commit
8b4cdc730d95283475ba5c4639a534215118b94a )
Marko Luukkainen [Thu, 5 Dec 2019 13:32:14 +0000 (13:32 +0000)]
Merge "Allow property editing with just a single mouse click"
Marko Luukkainen [Thu, 5 Dec 2019 13:23:47 +0000 (13:23 +0000)]
Merge "Fix issue with cell editor type mismatch and disable user-entered values"
Marko Luukkainen [Thu, 5 Dec 2019 13:09:58 +0000 (13:09 +0000)]
Merge "Refuse attempts to set turn radius index to a negative value."
Marko Luukkainen [Thu, 5 Dec 2019 12:31:00 +0000 (14:31 +0200)]
Fix directed path leg update failing to update inline lengths
Changed PipeControlPoint.getPathLegDirection to return normalized
vectors, or null.
Also, now Plant3D editor reports PipingRule errors happening during
model load.
gitlab #35
Change-Id: I159db0a8f04ed69df0b98fd859a4bf0fd58427de
(cherry picked from commit
61ce1ae33f46cf6d73a8d0ec151dcf1cd27db49f )
Reino Ruusu [Thu, 5 Dec 2019 11:56:16 +0000 (13:56 +0200)]
Allow property editing with just a single mouse click
gitlab #62
Change-Id: Idcbc1644787316cced9d90481d44759fd754325a
Reino Ruusu [Thu, 5 Dec 2019 11:55:38 +0000 (13:55 +0200)]
Fix issue with cell editor type mismatch and disable user-entered values
gitlab #62
Change-Id: I57d6f6c69fed6c8b840cc0a5011f802e29a96fb3
Reino Ruusu [Thu, 5 Dec 2019 11:52:38 +0000 (13:52 +0200)]
Refuse attempts to set turn radius index to a negative value.
gitlab #63
Change-Id: I98564e31efb7ba483c7b5dd4a3988098889bb134
Marko Luukkainen [Thu, 5 Dec 2019 10:23:11 +0000 (10:23 +0000)]
Merge "Fix removed nodes leaving visible graphical elements."
Marko Luukkainen [Thu, 5 Dec 2019 09:16:58 +0000 (11:16 +0200)]
Fix removed nodes leaving visible graphical elements.
When a node was removed and updated at the same cycle, it:
1. Was removed
2. Graphics were updated, which added graphics back to the visualization
gitlab #35
Change-Id: Ic512d450ea015f6969dd901558b36caaa88754bd
(cherry picked from commit
cf6b9ba427c210e1074d51bbc5712486f80930ec )
Marko Luukkainen [Thu, 5 Dec 2019 09:07:58 +0000 (11:07 +0200)]
Yesterdays change introduced infinite loop for directed path leg updates
Fine tuned elbow space calculation.
gitlab #14
Change-Id: Ic0505c5e55d0f90f41bcdd7f8b26d11d189d6582
(cherry picked from commit
a899aac9dd52296206f302a20a8e7bae2501cf2c )
Marko Luukkainen [Wed, 4 Dec 2019 14:29:48 +0000 (16:29 +0200)]
Directed path leg update handled offset wrong way.
Additionally, removed debug messages.
gitlab #12
Change-Id: I8abab7e87115a1ce9439fed4d70a9e0973ed5ca8
(cherry picked from commit
a53efc63bed07331a3a2f9879f266e41cbe738cb )
Marko Luukkainen [Wed, 4 Dec 2019 11:54:06 +0000 (13:54 +0200)]
Prevent elbows overlapping nozzles
gitlab #14
Change-Id: I9ecfa4dced7a48d2e7312986dd10be7b9a88bfae
(cherry picked from commit
cc43aabf1f80291c17ece22060fbb0e690fb4864 )
Marko Luukkainen [Tue, 3 Dec 2019 13:59:37 +0000 (15:59 +0200)]
Fix path leg updates when reducer is the first or the last component.
Additionally fixed control removal on reducer boundary.
gitlab #61
Change-Id: Iadcb1b410acde45e23e4cd9a4a592fb6b8e6d294
(cherry picked from commit
dc44eb5c7d3c8f35faf9bab80b9432d60ea203ea )
Marko Luukkainen [Tue, 3 Dec 2019 12:37:32 +0000 (14:37 +0200)]
Disable DB level undo, when model modifying actions are active
gitlab #60
Change-Id: Idf996ffa7ee87eac42ecd1118c4a4bd99aa0cc2c
(cherry picked from commit
0a4af0014e06aa2f295bed0b4ab94c3a2bab37f3 )
Marko Luukkainen [Tue, 3 Dec 2019 11:49:36 +0000 (13:49 +0200)]
Revised update logic for inline components
* PipingRules no longer have separate code for path legs with offsets
* Overlapping fixed length components are forced to be separate, as long
as there is available space
* Using more stable calculation for turn component orientations (reusing
path leg direction vector)
* Error messages of overlapping inline components
gitlab #14
gitlab #59
Change-Id: I85e754ffb6dab37ca7b7ae8e5f28842fbf095a11
(cherry picked from commit
aca223a1616159645710d7c9ee67ed1a6bd47b99 )
Marko Luukkainen [Mon, 2 Dec 2019 12:53:07 +0000 (14:53 +0200)]
Showing error messages when components overlap each other
* Removed code that forced PipingRules to iterate whole connected
segment.
* Adjusted PipingRule excecution on editor load.
* Fixed inline coomponent updated, when the component was also path leg
end.
* Fixed variable length adjusting / removal code.
gitlab #59
Change-Id: I4e1152f2a37b9a7cc7f93f18a9cf54616c62bbfd
(cherry picked from commit
3c9eba53de061b8c5c5863dc05855dc0e71781b1 )
Marko Luukkainen [Fri, 29 Nov 2019 12:34:50 +0000 (14:34 +0200)]
Converting variable angle turn turn to fixed angle could fail.
Calculating rotating angle from input and output directions was using 0
- PI restricted angle calculation, where expected result was -PI - PI
gitlab #46
Change-Id: I08956dc40009c4fea17883b7a6caf8468db8bf7f
(cherry picked from commit
b9efd234b46a0c15a9ee034592b90d72f18480fe )
Marko Luukkainen [Fri, 29 Nov 2019 11:44:12 +0000 (13:44 +0200)]
Processing DB changes could leave control points unsynchronized
When processing DB changes, component connections could be created
before control points (especially Nozzle). This could cause a situation,
where components were connected, but control points were not.
gitlab #35
Change-Id: Ida35c3222dbc706c7cb0e481af41feeca0949809
(cherry picked from commit
944164586441e68cd62073de3995a2455be9680a )
Marko Luukkainen [Fri, 29 Nov 2019 10:44:52 +0000 (12:44 +0200)]
Handle PipeRun removals with detaching Components.
Some operations can move Components between PipeRuns. If we create a
PipeRun within such operation, and the undo the modification, removal of
the created PipeRun may remove Components before they are attached to
their original PipeRuns.
1. Now PipeRun removal detaches Components, so that Component structure
remains intact.
2. PipeCOntrolPoint removal work without PipeRun.
3. AbstractVTKNodeMap calls INode.remove() all removed nodes.
gitlab #35
Change-Id: I37ec56302581ab176fe630c91b3cddb301ad1210
(cherry picked from commit
f346390a5a8cd4262a9aa68951e55d504d412549 )
Marko Luukkainen [Thu, 28 Nov 2019 15:49:56 +0000 (17:49 +0200)]
Remove/Split could go over PipeRun boundary and break reducers.
gitlab #33
Change-Id: Ieb76bf130b1baaed040ffff38aa950bc0461d7c9
(cherry picked from commit
81c2595de58576c1d0f8220633557a1c77c623de )
Marko Luukkainen [Thu, 28 Nov 2019 15:39:13 +0000 (17:39 +0200)]
Allow adding adjustable length components in the middle of a pipe
gitlab #26
Change-Id: Iafc06d7553984033a1e085866bf3f21536dd7e3c
(cherry picked from commit
f8e541f1d66cda57802da11aaa715b9f9c1c79a9 )