From ed5759e22d06d82af4bc67e27239aa4e66310b8b Mon Sep 17 00:00:00 2001 From: Timo Korvola Date: Mon, 30 Jan 2017 16:27:13 +0200 Subject: [PATCH] All getters now use GIL as well. More macro madness. Hopefully locking is now OK. Change-Id: I3f487cc74154574032492b9dd5c4f46b27ee7a4e --- .../jnipython.dll | Bin 63488 -> 63488 bytes .../src/sclpy.c | 362 +++++------------- 2 files changed, 101 insertions(+), 261 deletions(-) diff --git a/org.simantics.pythonlink.win32.x86_64/jnipython.dll b/org.simantics.pythonlink.win32.x86_64/jnipython.dll index a605b4e9da45bd49bbe4119bef0885bb37f6b1c7..261bac38ed2f79d35f1a626e8e57ccc00aa9a418 100644 GIT binary patch delta 5542 zcmai24OCRs7C!ef7Y1Zx5UwGD4LB(D)KvTd6GIo^Rq=^tGWq<$KlGWUJsBfK2N_WD zhG9or_Li$KE&uapDu3R~#xOu7O~9};b7?)t&_bW@iKgE7oij6lXzQ`o{`NlS?0wEY z`|P{V8S)!_@*90h8>3Q3y=5VuzeW;mY9|H|@*X-SxjQX1SePng(AR{{!X#QEyew4E zyFzziF^v+ti`%=`LwsjY}gc-4w8}9|o?Tp_KuBMaLQXdq9ym_>7~VU3@^7I~7cCjzCCi z{PA?vsi@=48EU#&fyMa>S}Q*<_MYkp?RX?Q`sdAvd(Lo0O))1Zs^KJ>iaNrmBr5ux zE>J(b*>O8zog|vybF3b6(odZI4$VwkCSF}n>%nHPr zy)$aJ5a#$W-B%DgId+Zi>|;w%DpSlRmMTzmso18xV<#c$aNojr$>vISy~-4DUa^Wj z&m2pvVnZt1VXUGi>(%^i7)6p0W05nbBeOz3v+DkdrZFp1LohrWROt3B+4ZSI)8d^) zPV0san%ob|vAIk*z=ZPZYHDfsbdrUc^=4CLxi`}nCT<5Xb8k)7aVx%3l_sCs?sm__ zouW~F2Gb0Gzo*!$W9{x$GhEmAV+ytq?KLj$(T(S>W*Z;0-%xH<7K-yx)Hpc=!8f^z;30(&Vq1t7?j$XTM0;5V|)b%vQmU0cTK+^V8%t&|+sW zr&S2XJ?6@IzFipoxD}Hk!>oTohTVc=N+J%&8i2FyjieL_4E^35 zdhpTzjZ4!C=FMR!w)JM&?``Aa_2&MT$Gi!9#G8<2Z%%#O;?3wMdJ|^L4$5@i3JPXv zq#A~EfBc`|&)4_b`ZK|s*2CZsFP!0uD)(m%Bm-)TqSxduZf8S0XIGD=dof;X=GaKI zC!u`2uCCPN0>t}PkkOsl3FR~{&D8n`R~50Kjf7I$ptXO@NpH~JM1gOU+Us|MK5UhlaKIQ(R&QlEq^pm@~4+910OBV8&JbFc_NJ3ZnR6& zqZ<_)`o%l#O~NDB(AgcW&%?gddmfA68vmrWYw~}vUH)0SZz0+(ExL7P+(n_(MFJhQnnru(2lt%lzG})sp$| zpoxs*mOjkV1$e^r>^9~~I;K?KqGXs?1_STxQ(2>B_5?KDhBnk)7+u5N=v8R#y$M?E zf-(7GykU+#sb)EZoFSgM3n_G$-pv zsba4{b{8+jL(KCo!ZOdZWz=uH)4BdjOD9EihWdC`EZu8pr3)~9!v;2oLMtbYH)`^` z+|IrA+;V!+%G(>Nw@e1>BL$My_uF@!g6q0(qEKXLq)V-?5498=u=>@tWs$MJiP7dT$z z=;C;f<9&_~ITCKWn6IMavM)zH$AJNy1#)c9(a5m_$54(PIfiiz=NLiba#ji{bYD(% z&#~DkxWUTNqsHtzM>WkV{<~Z`dfa&JC44~DTFgCENiF6&$BTt;TO%V_0any1MLnm< zwWv|}u@d+SXE)~2L~Hh#A21`T-kPogOsi7V--@LZ=$fUdx)}BxQ&fw-!Kge}o)dn^ zg>PAtJ7b!7XQL9dFESZFYOGfpe20DxYy1K-&7;3sJ4N+JwhjPJ}=yF}&N0kV@$^bl5&!(=m*Trw|JBdvXO!4|J!ZyHeT?EmkdyZdd~p zwNhCr?L?1~m{dJC4#g)5)0Lyc^(~GJC?3!Th4@df>s}=DzBh+eFHpZG8*YT)JS0mTc zRk?$NiL^X7TFjhIujVcYI*XY#d5jHysgiRh&3+?I%%4F&e&ZQi`b@T=LNjt0zgL}l zg!DUTL$5CzDV8=*XDx5tlD1&5Qd*2oe;sjFN;!~NkYFH8V+Q;eg7hHEEicgI)wqd^ zrJta8h)1)R4-VzHCNE|;w5`N&62aDFD_ZuXBhVt&0Jowq6g7D!1`e~ekk*c3>Pb!h41EpD4(Va< zIs&U%rBI*F)kB-rRYL;r5j{Q0-1I)brK{3QSnVzuZ%%OKVgjTmE7S>^e1VM@OEOG7 zrTv7vry-j@w`7ohKF_VB1$60>-u{_=p;eM(iKok!MC*gq)F zjfg*w--xZ`T*yp2!8|$ zg`Ue8N?BKYOV|$o6rcJI0rp~vX z6Nip+Jb3F$sF3C8^I=y}+!R75Y>f`Mei@Vxxe>f%8X>D7mw_kY zITW(+=YHX#QgXMx|G17*nMuY`03 zRYA_nC*(&^;1`5k0)GGsg=|_*$nzi*}Ut}X> z9U2?ZxV(apEsz_*%T^Nd31r3(fa)M01aAagU^?KjtB@Fw_k!O9-G|H`OeaARPIqqh lM~Y>jKN)-?NP*0_6|@U-zCVNyK)1heEHC>=_~3HK{{dvhXFdP` delta 5700 zcmb_geN>cH8o%!gFN~uTV>${d3OJw^8i*djM5*|A)j?;?O;S=cKS<4wBV(B2AOphm ziV{~{`*8gTll;~xH!F1v6iwV*K*iclt#0QGi*2mAM{BcpfA`KiBT$|8kL8@__dNIB z=j%TA>m3T)0t(v#D%v7%h?}yA_SZ(DBD#utLjH)3Y;UKIb{A#|DRjBeSFqA@VUe(s zelH9X7Sc#@kmwvhCx|hE$F*F1T@ZHBZh=w4PxP_C*ddXbgtTnv3aE<)6eR(+PXgRC z0eS=gh8X}(S{xV^ls*NbKo10_32)HbfrEs%XdfxcNSKq>fq)<@V4ce%{a!S>nh22- zYGr4tIZJjVx6-4*J#s+p&#;azeZRale-WiEnA|Z$Nj&wjhMQr(ZDw19c6wPCs0v4fH?y60u){tEg*&zW=p4rk5)al9q76 zqPS&cs@bYo%rY!KtfP&lapG4qT|Il9ii$d0g}Ucu$V#d?QC1B5(Ug_(Mmb5=<@Ja9 z>s78hiJK)caEI%au@{5Ij6cw6>1)Nht@IjL##TBl1FbFe8d$~_I!#7vGrb0uv6)UA zj~1oZz%nSEHUX_ldTm0%fTt=E)z(8UH;r|&fEKgW<2<3Nt&@?%qm^{U#3FI;tMu-~ zgTg)69!roQeD6At**CzB8KjzX*iyu?N#%M?zi_E4>l@6PajNO?e&%#4YoAw5tM;LV z(FobG#vDOxCWK8c_JwVRZGyWsojHz>l@y&)SdHYciHNbp&6VT)$}#)B+F{H)v{~M_ zwcscptD&P-=F3ViPYJdEVz!1(*?!6L^Jn|cJ3r6%pu?A~&Kp0Og^o~7KO$8v$#?uZ ze?P`&gdBVOldM7?tARI3`p}dizf#IfP0?4%0UeTSLA=hT9O@4&!*;m4)uNTsFp+7q zjl?P*<5!F1YLB)?V|$HfvrR(fZTdQ7haF2=bxeXlLXK+%rI8ck?Clr4;AqDMpUm9& zOBnVGS#B?48f?AtVT%R#m2mN1e+ggn>rD0Pv|r|jUeIFxW(iLo>6qLmmX1HUXA!S+ z3B&z?--j)dd-4}{qo6Ic(XSk(c(qO1ZWyPzZod-;PaM*ra`z8+Ozu-=<4^9jw|}18 z_H|5yRqh^a+g0w?o(Gll>oj?FI#lj6E#_}lF1b^3Asv#tj(9(-oIh}4$K+xkBp2q_ z>FG-@6f=(SPAcJlO|IZj$I4A+wenXktW$EmvE{cH`YM+X+xa2W+^y4nXJaeOYgVZM*f}@RonQzxV6pd38Fhci{nV%m?dDGbS4BH6=LHwopv!kl(xu zH*aai2+K;l&p*-};K=i9ZX>VHRCed%KF>lPEa}1QJ|FD$nCJKSC)g&qTh?=r{7Ep3 zLtt64Yp)u6PlxdytC6h+ZaNg*v|_h^cCz2uBJRw4R}A*Z@aeeMjbCS}ew_@j4zB>e zHLafN{p}0DpM?5)+K`oI&tegmvF!PEmd_@b<0;qleV6VmHbeg+4MAp|7wNsVOoQ2$ z!4``&&NCVt*>O+JV;5TKngW3!W{Ojiib(`_8{xIwy024~SvB=E=BdbzN%9BP zMqv{6HytK_8M<6?kAY}iDc`Qh%MS~K*t8yOPQkLk1a5^85WTL(dje#Sd?OO1(dXs za|dU4dfR-T4OUGD;gF4|umCBlX^Ymz-Yhm35|$ZZPxl&nbw-R3NAJ(*jn4)IjldXb zHLz(#$g11BJJE>aZ+QW};d{ph-cGh-5EQoJS<=$W^`*hWc zWvF)RHWnv^1<8^r&7P!ZZ5i{;uW|i5`%{x$jXsXgNHuyV$4ZXH99MG8N(yiV?9?nx;Y->SjBNG$1;vDb6m`ECPRC)l{cQ`ID%sg$54)Xj+;wafEbR0 zIX=QMmg6vvi5w?zv~Zln(aP}??q@2OpW&Frany9qvN_J=n8R@n$GIHmbIj$qkmF*y zDz8-7Oa)ui&~*!NHFuZKoH5S7dq!1l;&(OjnG432XK_sG)#wQ&EcY=Shm}yPExcba z8n}*SrCBu%EN1&i8ncA6@Fmn~n?Ko*%g#*5#(_Ak>iJaVTc`8`qRf+(!00$^1X;<_ zwHoEeYx4S>@Zfl=rbP}y65MTa$kFg+FCw3ttwB$mgf)InSzn}MSB6E-L$_)g1wD)M zl??C2Te&C02tLr?LGxGkOFoZrIVp|geJv}Q&~M{s40#@A1I{#}Hsbmbxk(crGkn2* zk+G@N(!Z?i6T1tF-h42v18mGGodk0xmjcsDz6mM0$pV+6O?$sI!u|x@XsM?|1F1_| z=7Z40t?OuoPavHRQen}a#He-i-zEmiG;iF(BZj?HABSinM&;kOnH5zStI;w+MGXH*hhP;iV{nor=wOa3z6or!tJmlFGXsbM~|;c7mv)PKdpMiz6L{b zd9fLr7(ag9I+U~v>r$jSj5(#o=UK~lYe`K=vQFBE&Mtw(T_;sRVnu>M{2XSG%03sQ zp_;r*HGPIh(JA$W-3eaJVF6f_3##c8_E_4>4SgSD$(=>Zk^E11BR0KPF$jvP>0Jzb zz+&;Qj6=+5T`kKNw<>D81^c<>1`3+;wCuPQAuHFhiQMQ^O_fX+`QX>zJ=NA#RxYZh zAk?6B?Fk+1J*QwbuLA0oTz#%zT`}bHo+(;S3OBW|mU7-w&ThT(spdpaJ{(|sYVSZS z*Ot;?s$JZDyghw$sj_;s?lg{j%^uskt z3Hb#`KYAg@Y>tySrf?h%#MGVH=Fn;0DNFWQbWlO~lex1nxs`G`|2TMh4a*~&{qVlL zn*Fzs;R!6d>%5>PV^0)rt1r0?YC!QciwHZIK$f@F(2#|iu|bKJ~vJ;!{G3pr+UoWwDO<8Y2L6~AYoDBck1Gkc@-?iNzWwpq?UTt$1w3WCmcrutJ! zsBpb{s9t!s2%9xjAff*+zFYIRo1QvyDC&bU?^STuLC6=ygt*`E@_(Uy6YaJ)=*FYN zx-&JF;x&8?C*#i7(@RH3nS8wqF#0+u?oDu4*s%mL@^9LI=L&1QhW%j7DEDJRnn5zP zy}QD`5u^1WeJvrs1ML8LKqJo*QUJOL>U9qP(gW=Q-3E=WBV-+@4rDw}$V|{)&>hg2 z3xt$`u7V;zA!GsQ2aaDIZw{ald+ZYZW z6+CC@(#7*;FQJ)@qqV+BDm4vgr{mY9^PBqf{?ewA;F0uXlQnRuZOL5vMC|}q+!bA* zEB|`6aO|&5qJ8mmgk+r}q!2s-8#M=V3b=?Qlr{+z_f3K!GWNN54SG`;gLtx mUt_<@=x+npWBa8*W;_~H1(|KhDWF@BiK}VnVPW@;UjGF$+oawA diff --git a/org.simantics.pythonlink.win32.x86_64/src/sclpy.c b/org.simantics.pythonlink.win32.x86_64/src/sclpy.c index e767192..8de3c87 100644 --- a/org.simantics.pythonlink.win32.x86_64/src/sclpy.c +++ b/org.simantics.pythonlink.win32.x86_64/src/sclpy.c @@ -787,8 +787,8 @@ jobject pythonDictionaryAsMap(JNIEnv *env, PyObject *dict) { #define DEF_SETTER(typename, jtype, j2py) \ JNIEXPORT void JNICALL \ - Java_org_simantics_pythonlink_PythonContext_setPython \ - ##typename##VariableImpl( \ + Java_org_simantics_pythonlink_PythonContext_setPython##typename \ + ##VariableImpl( \ JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName, \ jtype value) { \ PyObject *module = (PyObject*)contextID; \ @@ -910,269 +910,101 @@ Java_org_simantics_pythonlink_PythonContext_executePythonStatementImpl( } } -JNIEXPORT jstring JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonStringVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return 0; - } - - if (!PyUnicode_Check(value)) { - throwPythonException(env, "Python variable not a string"); - return 0; - } - - { - jstring result = pythonStringAsJavaString(env, value); - return result; - } -} - -JNIEXPORT jobjectArray JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonStringArrayVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return 0; - } - - if (!PySequence_Check(value)) { - throwPythonException(env, "Python variable not a sequence"); - return 0; - } - - { - jobjectArray result = pythonSequenceAsStringArray(env, value); - return result; - } -} - -JNIEXPORT jboolean JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonBooleanVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return 0; - } - - if (!PyBool_Check(value)) { - throwPythonException(env, "Python variable not a boolean"); - return 0; - } - - return value == Py_True; -} - -JNIEXPORT jbooleanArray JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonBooleanArrayVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return 0; - } - - if (!PySequence_Check(value)) { - throwPythonException(env, "Python variable not a sequence"); - return 0; - } - - { - jbooleanArray result = pythonSequenceAsBooleanArray(env, value); - return result; - } -} - -JNIEXPORT jlong JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonLongVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return 0; - } - - if (!PyLong_Check(value)) { - throwPythonException(env, "Python variable not an integer"); - return 0; - } - - { - jlong result = PyLong_AsLongLong(value); - return result; - } -} - -JNIEXPORT jintArray JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonIntegerArrayVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return NULL; - } - - if (!PySequence_Check(value)) { - throwPythonException(env, "Python variable not a sequence"); - return NULL; - } - - { - jintArray result = pythonSequenceAsIntegerArray(env, value); - return result; - } -} - -JNIEXPORT jlongArray JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonLongArrayVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return NULL; - } - - if (!PySequence_Check(value)) { - throwPythonException(env, "Python variable not a sequence"); - return NULL; - } - { - jlongArray result = pythonSequenceAsLongArray(env, value); - return result; - } -} - -JNIEXPORT jdouble JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonDoubleVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return 0.0; - } - - if (!PyFloat_Check(value)) { - throwPythonException(env, "Python variable not a float"); - return 0.0; - } +// Returns a borrowed reference. +static PyObject *getPythonValue( + JNIEnv *env, jlong contextID, jstring variableName) { + PyObject *module = (PyObject*)contextID; + PyObject *pythonName = getPythonString(env, variableName); + PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - { - jdouble result = PyFloat_AsDouble(value); - return result; - } + Py_DECREF(pythonName); + if (value == NULL) { + throwPythonException(env, "Python variable not found"); + } + return value; } -JNIEXPORT jdoubleArray JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonDoubleArrayVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return NULL; - } - - if (!PySequence_Check(value)) { - throwPythonException(env, "Python variable not a sequence"); - return NULL; - } - - { - jdoubleArray result = pythonSequenceAsDoubleArray(env, value); - return result; - } -} +#define DEF_GETTER(typename, jtype, check, desc, py2j) \ + JNIEXPORT jtype JNICALL \ + Java_org_simantics_pythonlink_PythonContext_getPython##typename \ + ##VariableImpl( \ + JNIEnv *env, jobject thisObj, jlong contextID, \ + jstring variableName) { \ + jtype result = 0; \ + PyEval_RestoreThread(main_ts); \ + do { \ + PyObject *value = getPythonValue(env, contextID, variableName); \ + if (value == 0) break; \ + if (check(value)) { \ + result = py2j(env, value); \ + } else { \ + throwPythonException(env, "Python variable not " desc); \ + } \ + } while (0); \ + PyEval_SaveThread(); \ + return result; \ + } -JNIEXPORT jobject JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonNDArrayVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; +#define pythonBoolAsJboolean(env, value) ((value) == Py_True) +#define pythonLongAsJlong(env, value) PyLong_AsLongLong(value) +#define pythonFloatAsJdouble(env, value) PyFloat_AsDouble(value) + +DEF_GETTER(String, jstring, PyUnicode_Check, "a string", + pythonStringAsJavaString) +DEF_GETTER(StringArray, jobjectArray, PySequence_Check, "a sequence", + pythonSequenceAsStringArray) +DEF_GETTER(Boolean, jboolean, PyBool_Check, "a Boolean", pythonBoolAsJboolean) +DEF_GETTER(BooleanArray, jbooleanArray, PySequence_Check, "a sequence", + pythonSequenceAsBooleanArray) +DEF_GETTER(Long, jlong, PyLong_Check, "an integer", pythonLongAsJlong) +DEF_GETTER(IntegerArray, jintArray, PySequence_Check, "a sequence", + pythonSequenceAsIntegerArray) +DEF_GETTER(LongArray, jlongArray, PySequence_Check, "a sequence", + pythonSequenceAsLongArray) +DEF_GETTER(Double, jdouble, PyFloat_Check, "a float", pythonFloatAsJdouble) +DEF_GETTER(DoubleArray, jdoubleArray, PySequence_Check, "a sequence", + pythonSequenceAsDoubleArray) + +JNIEXPORT jobject JNICALL +Java_org_simantics_pythonlink_PythonContext_getPythonNDArrayVariableImpl( + JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { + jobject result = NULL; if (!hasNumpy) { throwPythonException(env, "Importing numpy failed"); return NULL; } - { - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return NULL; - } - + PyEval_RestoreThread(main_ts); + do { + PyObject *value = getPythonValue(env, contextID, variableName); + if (value == NULL) break; if (!PyArray_Check(value)) { throwPythonException(env, "Python variable not an ndarray"); - return NULL; - } - - if (PyArray_TYPE((PyArrayObject*)value) != NPY_DOUBLE) { - throwPythonException(env, "Only ndarrays of type double are supported"); - return NULL; + } else if (PyArray_TYPE((PyArrayObject*)value) != NPY_DOUBLE) { + throwPythonException( + env, "Only ndarrays of type double are supported"); + } else { + result = pythonArrayAsNDArray(env, (PyArrayObject *)value); } - - { - jobject result = pythonArrayAsNDArray(env, (PyArrayObject *)value); - return result; - } - } -} - -JNIEXPORT jobject JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonVariantVariableImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - - PyObject *pythonName = getPythonString(env, variableName); - - PyObject *value = PyDict_GetItem(PyModule_GetDict(module), pythonName); - if (value == NULL) { - throwPythonException(env, "Python variable not found"); - return NULL; - } - - hasNumpy = _import_array() != -1; - - { - jobject result = pythonObjectAsObject(env, value); - return result; - } + } while (0); + PyEval_SaveThread(); + return result; } -JNIEXPORT jint JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonVariableTypeImpl(JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { - PyObject *module = (PyObject*)contextID; - PyObject *dict = PyModule_GetDict(module); +#define python_anything_goes(value) 1 - PyObject *pythonName = getPythonString(env, variableName); - - if (!PyDict_Contains(dict, pythonName)) { - return 0; - } +DEF_GETTER(Variant, jobject, python_anything_goes, "frabjous", + pythonObjectAsObject) +JNIEXPORT jint JNICALL +Java_org_simantics_pythonlink_PythonContext_getPythonVariableTypeImpl( + JNIEnv *env, jobject thisObj, jlong contextID, jstring variableName) { + jint result = 0; + PyEval_RestoreThread(main_ts); { - PyObject *value = PyDict_GetItem(dict, pythonName); - - jint result; - + PyObject *value = getPythonValue(env, contextID, variableName); if (PyBool_Check(value)) result = 1; else if (PyLong_Check(value)) @@ -1191,28 +1023,36 @@ JNIEXPORT jint JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonVari result = 8; else result = -1; - - return result; } + PyEval_SaveThread(); + return result; } -JNIEXPORT jobjectArray JNICALL Java_org_simantics_pythonlink_PythonContext_getPythonVariableNamesImpl(JNIEnv *env, jobject thisObj, jlong contextID) { - PyObject *module = (PyObject*)contextID; - PyObject *dict = PyModule_GetDict(module); +JNIEXPORT jobjectArray JNICALL +Java_org_simantics_pythonlink_PythonContext_getPythonVariableNamesImpl( + JNIEnv *env, jobject thisObj, jlong contextID) { + jobjectArray result = NULL; + PyEval_RestoreThread(main_ts); + { + PyObject *module = (PyObject*)contextID; + PyObject *dict = PyModule_GetDict(module); - PyObject *keys = PyDict_Keys(dict); - Py_ssize_t size = PyList_Size(keys); + PyObject *keys = PyDict_Keys(dict); + Py_ssize_t size = PyList_Size(keys); + Py_ssize_t i; - jobjectArray result = (*env)->NewObjectArray(env, (jsize)size, (*env)->FindClass(env, STRING_CLASS), NULL); + result = (*env)->NewObjectArray( + env, (jsize)size, (*env)->FindClass(env, STRING_CLASS), NULL); - Py_ssize_t i; - for (i = 0; i < size; i++) { - jstring javaName = pythonStringAsJavaString(env, PyList_GetItem(keys, i)); - (*env)->SetObjectArrayElement(env, result, (jint)i, javaName); - } - - Py_XDECREF(keys); + for (i = 0; i < size; i++) { + jstring javaName = pythonStringAsJavaString( + env, PyList_GetItem(keys, i)); + (*env)->SetObjectArrayElement(env, result, (jint)i, javaName); + } + Py_XDECREF(keys); + } + PyEval_SaveThread(); return result; } -- 2.45.1