From 8836b5fd99a3e97234153420870ea253a35eb593 Mon Sep 17 00:00:00 2001
From: Marko Luukkainen <marko.luukkainen@semantum.fi>
Date: Wed, 16 Sep 2020 18:44:10 +0300
Subject: [PATCH] Change G2D.Color specification to RGBA (was BGRA)

Pretty much all the implementation assumes RGBA.

Connection colors defined in ontologies must be fixed.

gitlab #606

Change-Id: I62fa43c62421db66e6e18b34202be0ced0be6a24
---
 .../simantics/diagram/connection/ConnectionVisuals.java   | 4 ++--
 .../graph/ConnectionPoints.pgraph                         | 8 ++++----
 bundles/org.simantics.g2d.ontology/graph/G2D.pgraph       | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/bundles/org.simantics.diagram/src/org/simantics/diagram/connection/ConnectionVisuals.java b/bundles/org.simantics.diagram/src/org/simantics/diagram/connection/ConnectionVisuals.java
index 802881e16..d89c07c4f 100644
--- a/bundles/org.simantics.diagram/src/org/simantics/diagram/connection/ConnectionVisuals.java
+++ b/bundles/org.simantics.diagram/src/org/simantics/diagram/connection/ConnectionVisuals.java
@@ -46,8 +46,8 @@ public class ConnectionVisuals {
         if (color == null)
             return null;
         if (color.length == 3)
-            return new Color(color[2], color[1], color[0]);
-        return new Color(color[2], color[1], color[0], color[3]);
+            return new Color(color[0], color[1], color[2]);
+        return new Color(color[0], color[1], color[2], color[3]);
     }
 
     @Override
diff --git a/bundles/org.simantics.document.base.ontology/graph/ConnectionPoints.pgraph b/bundles/org.simantics.document.base.ontology/graph/ConnectionPoints.pgraph
index 73b795343..01d730c0c 100644
--- a/bundles/org.simantics.document.base.ontology/graph/ConnectionPoints.pgraph
+++ b/bundles/org.simantics.document.base.ontology/graph/ConnectionPoints.pgraph
@@ -14,7 +14,7 @@ DOC.Document.ChildRelation <T STR.ConnectionRelation
 DOC.Document.IsConnectedToChild <R STR.IsConnectedTo : DOC.Document.ChildRelation
 
 DOC.ConnectionType : STR.ConnectionType
-    G2D.HasColor [0.8,0.64,0.0] : G2D.Color
+    G2D.HasColor [0.0,0.64,0.8,1.0] : G2D.Color
     G2D.HasStrokeType G2D.StrokeType.Scaling
     G2D.HasStroke _ : G2D.Stroke
         G2D.HasStrokeWidth 0.2 : L0.Float
@@ -166,7 +166,7 @@ DOC.Document.CommandRelation <T STR.ConnectionRelation
 DOC.Document.IsConnectedToCommand <R STR.IsConnectedTo : DOC.Document.CommandRelation
 
 DOC.CommandConnectionType : STR.ConnectionType
-    G2D.HasColor [1.0,0.0,1.0] : G2D.Color
+    G2D.HasColor [1.0,0.0,1.0,1.0] : G2D.Color
     G2D.HasStrokeType G2D.StrokeType.Scaling
     G2D.HasStroke _ : G2D.Stroke
         G2D.HasStrokeWidth 0.2 : L0.Float
@@ -683,7 +683,7 @@ DOC.DataStroke : G2D.Stroke
     G2D.HasLineJoin G2D.LineJoin.MiterJoin
 
 DOC.DataConnectionType : STR.ConnectionType
-    G2D.HasColor [0,0.65,1.0] : G2D.Color
+    G2D.HasColor [1,0.65,0.0,1.0] : G2D.Color
     G2D.HasStrokeType G2D.StrokeType.Scaling
     G2D.HasStroke DOC.DataStroke
     G2D.HasRounding 3.0
@@ -757,7 +757,7 @@ DOC.Document.DataDefinitionRelation <T STR.ConnectionRelation
 DOC.Document.IsConnectedToDataDefinition <R STR.IsConnectedTo : DOC.Document.DataDefinitionRelation
 
 DOC.DataDefinitionConnectionType : STR.ConnectionType
-    G2D.HasColor [0,0.65,1.0] : G2D.Color
+    G2D.HasColor [1.0,0.65,0.0,1.0] : G2D.Color
     G2D.HasStrokeType G2D.StrokeType.Scaling
     G2D.HasStroke DOC.DataStroke
     G2D.HasRounding 3.0
diff --git a/bundles/org.simantics.g2d.ontology/graph/G2D.pgraph b/bundles/org.simantics.g2d.ontology/graph/G2D.pgraph
index b08fbdaae..37deca7b3 100644
--- a/bundles/org.simantics.g2d.ontology/graph/G2D.pgraph
+++ b/bundles/org.simantics.g2d.ontology/graph/G2D.pgraph
@@ -211,7 +211,7 @@ G2D.HasVerticalAlignment <R L0.IsRelatedTo : L0.FunctionalRelation
 G2D.Color <T L0.Literal
     @L0.assert L0.HasDataType $(Float[4])
     @L0.assert L0.HasValueType "Vector Float"
-    L0.HasDescription "A 4-component BGRA color as floats."
+    L0.HasDescription "A 4-component RGBA color as floats."
     
 G2D.HasColor <R L0.HasProperty : L0.FunctionalRelation
     L0.HasLabel "Color"
-- 
2.47.1