Finish exception handling in AdapterRegistry2

[simantics/platform.git] / bundles / org.simantics.db.services / src / org / simantics / db / services / adaption / AdapterRegistry2.java

diff --git a/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/AdapterRegistry2.java b/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/AdapterRegistry2.java
index 578b42a61d885d13cfb06e20e7c31436d00a6af2..0db80b1b4f5cb48044709875cf3b821aabca4278 100644 (file)
--- a/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/AdapterRegistry2.java
+++ b/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/AdapterRegistry2.java
@@ -34,8 +34,8 @@ import org.simantics.db.Session;
 import org.simantics.db.adaption.Adapter;
 import org.simantics.db.adaption.AdapterInstaller;
 import org.simantics.db.adaption.AdaptionService;
-import org.simantics.db.common.request.ReadRequest;
 import org.simantics.db.exception.DatabaseException;
+import org.simantics.db.request.Read;
 import org.simantics.db.services.adaption.reflection.AdaptingDynamicAdapter2;
 import org.simantics.db.services.adaption.reflection.AtMostOneRelatedResource2;
 import org.simantics.db.services.adaption.reflection.ConstantAdapter;
@@ -95,15 +95,12 @@ public class AdapterRegistry2 {
     }
 
     private static void handleException(Exception e, String fileName) {
-        System.err.println("At " + fileName);
-        e.printStackTrace();
+        LOGGER.error("At {}", fileName, e);
     }
 
     private void handleException(Exception e, AdapterInstaller installer) {
         String desc = installerSources.get(installer);
-        if (desc != null)
-            System.err.println("At " + desc);
-        e.printStackTrace();
+        LOGGER.error("At {}, installer {}", desc, installer, e);
     }
 
     private void handleAdaptersDocument(Loader b, Document doc, String fileName) {
@@ -227,7 +224,6 @@ public class AdapterRegistry2 {
 
                     }, fileName);
         } catch (Exception e) {
-            e.printStackTrace();
             handleException(e, fileName);
         }
     }
@@ -337,9 +333,9 @@ public class AdapterRegistry2 {
     }
 
     public void updateAdaptionService(Session s, final AdaptionService service) throws DatabaseException {
-        s.syncRequest(new ReadRequest() {
+        s.syncRequest(new Read() {
             @Override
-            public void run(ReadGraph g) {
+            public Object perform(ReadGraph g) {
                 for(AdapterInstaller t : installerSources.keySet()) {
                     try {
                         t.install(g, service);
@@ -347,6 +343,7 @@ public class AdapterRegistry2 {
                         AdapterRegistry2.this.handleException(e, t);
                     }
                 }
+                return null;
             }
         });
     }