X-Git-Url: https://gerrit.simantics.org/r/gitweb?p=simantics%2Fplatform.git;a=blobdiff_plain;f=bundles%2Forg.simantics.selectionview%2Fsrc%2Forg%2Fsimantics%2Fselectionview%2Ffunction%2FAll.java;h=d26d86682874a15e61551de5cfcd66907ec975b4;hp=150bbb8252346f61bfe6b6aca6b8eef3ff8d9a11;hb=b000e272429e157638c0384878b07b8dcd758472;hpb=c4c152bf639475b85efad1e8bd6ea007c08a9e1f

diff --git a/bundles/org.simantics.selectionview/src/org/simantics/selectionview/function/All.java b/bundles/org.simantics.selectionview/src/org/simantics/selectionview/function/All.java
index 150bbb825..d26d86682 100644
--- a/bundles/org.simantics.selectionview/src/org/simantics/selectionview/function/All.java
+++ b/bundles/org.simantics.selectionview/src/org/simantics/selectionview/function/All.java
@@ -2,6 +2,7 @@ package org.simantics.selectionview.function;
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.Map;
 import java.util.function.Consumer;
 
@@ -13,6 +14,7 @@ import org.eclipse.swt.widgets.FontDialog;
 import org.simantics.Simantics;
 import org.simantics.browsing.ui.NodeContext;
 import org.simantics.browsing.ui.content.Labeler.DialogModifier;
+import org.simantics.browsing.ui.graph.impl.GetEnumerationValue;
 import org.simantics.common.format.Formatter;
 import org.simantics.databoard.Bindings;
 import org.simantics.databoard.Datatypes;
@@ -53,13 +55,16 @@ import org.simantics.scl.compiler.types.TVar;
 import org.simantics.scl.compiler.types.Type;
 import org.simantics.scl.compiler.types.Types;
 import org.simantics.scl.reflection.annotations.SCLValue;
+import org.simantics.scl.runtime.function.Function1;
 import org.simantics.selectionview.SelectionInput;
+import org.simantics.selectionview.SelectionViewResources;
 import org.simantics.selectionview.StandardSelectionInput;
 import org.simantics.ui.colors.Colors;
 import org.simantics.ui.fonts.Fonts;
 import org.simantics.ui.selection.WorkbenchSelectionElement;
 import org.simantics.ui.selection.WorkbenchSelectionUtils;
 import org.simantics.utils.datastructures.collections.CollectionUtils;
+import org.simantics.utils.strings.AlphanumComparator;
 import org.simantics.utils.ui.AdaptionUtils;
 import org.simantics.utils.ui.ErrorLogger;
 import org.simantics.utils.ui.ISelectionUtils;
@@ -196,7 +201,9 @@ public class All {
 			Resource parameterResource = parameter.getRepresents(graph);
 			if(graph.sync(new IsEnumeratedValue(parameterResource))) {
 				Map<String, Resource> map = graph.sync(new InstanceEnumerationMap(parameterResource));
-				return new ArrayList<String>(map.keySet());
+				ArrayList<String> values = new ArrayList<>(map.keySet());
+				Collections.sort(values, AlphanumComparator.COMPARATOR);
+				return values;
 			} else if(graph.isInstanceOf(parameterResource, L0.Boolean)) {
 				return CollectionUtils.toList("true", "false");
 			}
@@ -208,6 +215,9 @@ public class All {
 	public static Object getPropertyChildName(ReadGraph graph, Resource resource, Object context) throws DatabaseException {
 		if(context instanceof Variable) {
 			Variable variable = (Variable)context;
+			String label = variable.getParent(graph).getPossiblePropertyValue(graph, "HasLabel", Bindings.STRING);
+			if(label != null)
+				return label;
 			return variable.getParent(graph).getName(graph);
 		}
 		throw new DatabaseException("Unknown context " + context);
@@ -293,19 +303,6 @@ public class All {
 
 		}
 
-		if(!asserted) {
-			Resource assertedObject = Layer0Utils.getPossibleAssertedObject(graph, container, property);
-			if(assertedObject != null) {
-				if(graph.isInstanceOf(assertedObject, newType)) {
-					Object assertedValue = graph.getValue(assertedObject, (Binding)_binding);
-					if(assertedValue.equals(value)) {
-						graph.deny(container, property);
-						return null;
-					}
-				}
-			}
-		}
-		
 		Datatype datatype = variable.getDatatype(graph);
 		Binding binding = (Binding)_binding;
 		Layer0Utils.claimAdaptedValue(graph, objectResource, value, binding, datatype);
@@ -461,15 +458,28 @@ public class All {
 			Object value = null;
 			Resource formatter = property.getPossiblePropertyValue(graph, Variables.FORMATTER);
 			if(formatter != null) {
-				
 				Formatter fmt = graph.adaptContextual(formatter, property, Variable.class, Formatter.class);
 				value = fmt.format(property.getValue(graph));
-				
-			} else {
+			}
+			if(value == null) {
+				SelectionViewResources SEL = SelectionViewResources.getInstance(graph);
+				Function1<Object,String> formatterFunction = property.getPossiblePropertyValue(graph, SEL.formatter);
+				if(formatterFunction != null) {
+					value = formatterFunction.apply(property.getValue(graph));
+				}
+			}
+
+			Resource possibleValue = context.getParent(graph).getPossibleRepresents(graph);
+			if(possibleValue != null) {
+				if(graph.syncRequest(new IsEnumeratedValue(possibleValue))) {
+					return GetEnumerationValue.getEnumerationValueName(graph, possibleValue);
+				}
+			}
+
+			if(value == null) {
 
 				Variant variant = property.getVariantValue(graph);
 				value = variant.getValue();
-				
 				Binding binding = variant.getBinding();
 				if(binding != null) {
 					Datatype dt = binding.type();	
@@ -521,8 +531,14 @@ public class All {
 				String parsedLabel = (String)_value;
 				Object value = parsedLabel;
 
+				boolean isEnumeration = false;
+				Resource possibleValue = context.getParent(graph).getPossibleRepresents(graph);
+				if(possibleValue != null) {
+					isEnumeration = graph.syncRequest(new IsEnumeratedValue(possibleValue));
+				}
+
 				Datatype type = context.getParent(graph).getPossibleDatatype(graph);
-				if (type != null) {
+				if (type != null && !isEnumeration) {
 
 					Binding binding = Bindings.getBinding(type);