]> gerrit.simantics Code Review - simantics/platform.git/commit
Still fixes history collection value band endTime setting and rendering 40/2740/1
authorTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Fri, 9 Nov 2018 12:04:08 +0000 (14:04 +0200)
committerMarko Luukkainen <marko.luukkainen@semantum.fi>
Fri, 1 Mar 2019 08:17:44 +0000 (08:17 +0000)
commit05606cd41241cd473a102de76a5d0970d7c73af6
tree631d9c2dc8feaea3228d0df40d45936b059e90a1
parent8a98a0a6632e79aaf2e7b2496d279135b84a436c
Still fixes history collection value band endTime setting and rendering

Previous changes set value band end time to be the same as the next
value band's start time. However this caused the problem that there is
no way of telling during rendering where exactly within the previous
value band did the band's value go out of dead band and since t_end does
not tell us this. This means that line-rendering (not stepped sample
rendering) will get drawn invalidly if t_end > t_begin within a value
band.

The fix was to set t_end to the last timestamp where the value was still
within deadband, i.e:
```
|t0    t0_end  |               VALUE BAND #0 t0 < t0_end
|      |       |t1      |      VALUE BAND #1 t1 = t1_end
|      |       |t1_end  |
|      |       |        |t2... VALUE BAND #2
ts0----ts1---- ts2------ts3---
v=0    v=0     v=1      v=2
```

gitlab #35

Change-Id: I073d1aed0d3ce0ffe30081937fdd7ff1c22dc107
(cherry picked from commit b885083762a43ec97162a5f77df4fd5f85e28979)
bundles/org.simantics.history/src/org/simantics/history/impl/CollectorImpl.java
bundles/org.simantics.trend/src/org/simantics/trend/impl/ItemNode.java