]> gerrit.simantics Code Review - simantics/platform.git/commitdiff
Variable optimizations for documents (Simupedia) 58/2458/5
authorAntti Villberg <antti.villberg@semantum.fi>
Tue, 13 Nov 2018 10:42:49 +0000 (12:42 +0200)
committerTuukka Lehtonen <tuukka.lehtonen@semantum.fi>
Wed, 14 Nov 2018 06:58:53 +0000 (06:58 +0000)
* Documentation changes based on previous new features

gitlab #169

Change-Id: Ief514661ccc3dd16eb10c17ed660dd1976504b3d

bundles/org.simantics.document.base.ontology/graph/Components.pgraph
bundles/org.simantics.document.base.ontology/graph/Properties.pgraph
bundles/org.simantics.document.server/scl/Document/All.scl
bundles/org.simantics.document.server/src/org/simantics/document/server/DocumentProperties.java [new file with mode: 0644]
bundles/org.simantics.document.server/src/org/simantics/document/server/DocumentServerUtils.java
bundles/org.simantics.document.server/src/org/simantics/document/server/Functions.java
bundles/org.simantics.document.server/src/org/simantics/document/server/request/NodeRequest.java

index 099755380dc64c4ff874d8d1fe637ef97bc954f6..65a75d288777bc3556ef802cfa1d0219828aba9f 100644 (file)
@@ -67,9 +67,7 @@ COMPONENTS.Component <T STR.Component
     @sclAttribute PROPERTIES.commands "commandList self" "[Command]"
 
 COMPONENTS.PrimitiveComponent <T COMPONENTS.Component
-    @L0.assert PROPERTIES.primitiveProperties
-      _ : L0.Value
-        L0.domainProperties FUNCTIONS.primitiveProperties
+    @L0.sclAssertion PROPERTIES.primitiveProperties "primitiveProperties" "DocumentProperties"
 
 COMPONENTS.ParentlessComponent <T COMPONENTS.PrimitiveComponent /* Component without a parent, e.g. Root, DialogBox */
 
@@ -88,7 +86,7 @@ COMPONENTS.Event <T COMPONENTS.ParentlessComponent
  
 COMPONENTS.CommandEvent <T COMPONENTS.Event
    @connectionPoint RELATIONS.data1
-   @sclAttribute PROPERTIES.dataDefinitions "dataDefinitions self" "[DataDefinition]"
+   @sclAttribute PROPERTIES.dataDefinitions "computeDataDefinitions self" "[DataDefinition]"
    @sclAttribute PROPERTIES.SCLFunction "emptyOnClick ()" "String"
 
 DOC.commandEvent : L0.Template
index d502e3d2f2e860ed22dbdc56340c9e44954a643d..e1c71fe976a62df8b76c3a213c51418a8dbabd34 100644 (file)
@@ -52,7 +52,7 @@ PROPERTIES.model <R L0.HasProperty : L0.FunctionalRelation
     ==> "Variable"
 
 PROPERTIES.primitiveProperties <R L0.HasProperty : L0.FunctionalRelation
-    ==> "String"
+    ==> "DocumentProperties"
 
 PROPERTIES.exists
     @defAttribute L0.Value
index 4db639f5bf2696a389669d527bae19b035978064..6eaf328a32d64cd67ba13e64ded08f915cc31a02 100644 (file)
@@ -2,6 +2,9 @@ import "Simantics/DB"
 import "Simantics/Variables"
 import "JavaBuiltin" as Java
 
+importJava "org.simantics.document.server.DocumentProperties" where
+    data DocumentProperties
+
 importJava "org.simantics.document.server.io.IConsole" where
     data IConsole
     addMessage :: IConsole -> String -> <Proc> ()
@@ -110,6 +113,9 @@ importJava "org.simantics.document.server.Functions" where
 
     dataDefinitions :: Variable -> <ReadGraph> [DataDefinition]
 
+    @JavaName "dataDefinitions"
+    computeDataDefinitions :: Variable -> <ReadGraph> [DataDefinition]
+
     emptyOnClick :: () -> <ReadGraph> AbstractEventHandler
     
     writeEventHandler :: Variable -> (Variable -> (String -> Maybe String) -> <WriteGraph> String) -> <ReadGraph> AbstractEventHandler
@@ -138,6 +144,8 @@ importJava "org.simantics.document.server.Functions" where
     stateVariable :: Variable -> <ReadGraph> Variable
     
     compileDocumentSCLValueExpression :: Variable -> <ReadGraph> String
+
+    primitiveProperties :: <Proc> DocumentProperties
     
 propertyValueCached :: Serializable a => Typeable a => Variable -> String -> <ReadGraph> a
 propertyValueCached var prop = propertyValueCached_ var prop binding
diff --git a/bundles/org.simantics.document.server/src/org/simantics/document/server/DocumentProperties.java b/bundles/org.simantics.document.server/src/org/simantics/document/server/DocumentProperties.java
new file mode 100644 (file)
index 0000000..72d475a
--- /dev/null
@@ -0,0 +1,43 @@
+/*******************************************************************************
+ * Copyright (c) 2018 Association for Decentralized Information Management in
+ * Industry THTH ry.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     Semantum Oy - initial API and implementation
+ *******************************************************************************/
+package org.simantics.document.server;
+
+import java.util.Collection;
+
+import org.simantics.db.ReadGraph;
+import org.simantics.db.exception.DatabaseException;
+import org.simantics.db.layer0.variable.Variable;
+
+/**
+ * This interface abstracts the computation of document component properties.
+ * The key,value -pairs returned by this interface are used to build the
+ * org.simantics.document.server.JSONObject values used in the document
+ * scene graph.
+ *
+ * @author Antti Villberg
+ * @since 1.36.0
+ */
+public interface DocumentProperties {
+
+    /*
+     * Returns the set of attribute keys for the given document component.
+     * Does not return null.
+     */
+    Collection<String> getKeys(ReadGraph graph, Variable component) throws DatabaseException;
+    /*
+     * Returns a value for a key in the key set.
+     * Null values are allowed and normal DatabaseException
+     * are thrown when evaluating the value.
+     */
+    Object getValue(ReadGraph graph, Variable component, String key) throws DatabaseException;
+
+}
index 5e1f5cc30e798aff45343b8f8c5f4483b6d8a9cc..ec65027ec0ad50994fb1116eddaa1c02e731c906 100644 (file)
@@ -19,12 +19,10 @@ import org.simantics.db.layer0.variable.ProxyChildVariable;
 import org.simantics.db.layer0.variable.Variable;
 import org.simantics.db.layer0.variable.Variables;
 import org.simantics.document.base.ontology.DocumentationResource;
-import org.simantics.document.server.Functions.RootVariable;
 import org.simantics.document.server.request.NodeRequest;
 import org.simantics.document.server.request.NodeRequestUtils;
 import org.simantics.structural2.variables.Connection;
 import org.simantics.structural2.variables.VariableConnectionPointDescriptor;
-import org.simantics.utils.datastructures.Pair;
 import org.simantics.utils.strings.AlphanumComparator;
 
 public class DocumentServerUtils {
@@ -127,7 +125,7 @@ public class DocumentServerUtils {
 
        public static Variable getPossibleOtherConnectionPoint(ReadGraph graph, Variable connectionPoint, Connection conn) throws DatabaseException {
 
-               Collection<VariableConnectionPointDescriptor> descs = conn.getConnectionPointDescriptors(graph, null);
+               Collection<VariableConnectionPointDescriptor> descs = conn.getConnection2().getConnectionPointDescriptors(graph, connectionPoint.getParent(graph), null);
                if(descs.size() != 2) return null;
 
                for(VariableConnectionPointDescriptor desc : descs) {
@@ -141,7 +139,7 @@ public class DocumentServerUtils {
 
        public static Variable getPossibleChildConnectionPoint(ReadGraph graph, Variable connectionPoint, Connection conn) throws DatabaseException {
 
-               Collection<VariableConnectionPointDescriptor> descs = conn.getConnectionPointDescriptors(graph, null);
+               Collection<VariableConnectionPointDescriptor> descs = conn.getConnection2().getConnectionPointDescriptors(graph, connectionPoint.getParent(graph), null);
                if(descs.size() != 2) return null;
 
        DocumentationResource DOC = DocumentationResource.getInstance(graph);
@@ -174,7 +172,7 @@ public class DocumentServerUtils {
 
        public static Variable getPossibleCommandTriggerConnectionPoint(ReadGraph graph, Variable connectionPoint, Connection conn) throws DatabaseException {
 
-               Collection<Variable> cpts = conn.getConnectionPoints(graph, null);
+               Collection<Variable> cpts = conn.getConnection2().getConnectionPoints(graph, connectionPoint.getParent(graph), null);
 
                Variable result = null;
                
@@ -192,7 +190,7 @@ public class DocumentServerUtils {
 
        public static Collection<Variable> getPossibleOtherConnectionPoints(ReadGraph graph, Variable connectionPoint, Connection conn) throws DatabaseException {
 
-           Collection<Variable> cpts = conn.getConnectionPoints(graph, null);
+           Collection<Variable> cpts = conn.getConnection2().getConnectionPoints(graph, connectionPoint.getParent(graph), null);
            if(cpts.size() < 2) 
                return Collections.emptyList();
 
@@ -206,12 +204,17 @@ public class DocumentServerUtils {
 
        public static String getId(ReadGraph graph, Variable node) throws DatabaseException {
 
-               if(node == null) return "root";
-               else {
-                       String uri = node.getURI(graph); 
-                       int l = uri.lastIndexOf(ProxyChildVariable.CONTEXT_END);
-                       return uri.substring(l+4);
-               }
+        if(node == null) return "root";
+        else {
+            String name = node.getName(graph);
+            if(ProxyChildVariable.CONTEXT_END.equals(name)) return "";
+            else {
+                String parentId = getId(graph, node.getParent(graph));
+                if(parentId.isEmpty()) return name;
+                else return parentId + "/" + name; 
+            }
+            
+        }
 
        }
 
@@ -293,82 +296,67 @@ public class DocumentServerUtils {
        public static Collection<Variable> getAttributes(ReadGraph graph, DocumentationResource DOC, Variable variable) throws DatabaseException {
                return variable.getProperties(graph, DOC.Document_AttributeRelation);
        }
-       
-       public static class AttributesRequest extends VariableRead<Pair<JSONObject, Collection<Variable>>> {
+
+       public static class AttributesRequest extends VariableRead<JSONObject> {
 
                public AttributesRequest(Variable variable) {
                        super(variable);
                }
 
                @Override
-               public Pair<JSONObject,Collection<Variable>> perform(ReadGraph graph) throws DatabaseException {
-               ArrayList<Variable> statics = new ArrayList<Variable>();
-               DocumentationResource DOC = DocumentationResource.getInstance(graph);
-               
-               Variable primitives = variable.getProperty(graph, DOC.Properties_primitiveProperties);
-               for(Variable property : primitives.getProperties(graph)) {
-                       statics.add(property);
-                       // NO SUPPORT FOR DYNAMICS AT THIS STAGE
-               }
-               
-               JSONObject staticContent = computeStatic(graph, variable, statics);
-               
-               return new Pair<JSONObject, Collection<Variable>>(staticContent, Collections.emptyList());
-               
+               public JSONObject perform(ReadGraph graph) throws DatabaseException {
+                       DocumentationResource DOC = DocumentationResource.getInstance(graph);
+                       DocumentProperties properties = variable.getPropertyValue(graph, DOC.Properties_primitiveProperties);
+                       return computeStatic(graph, variable, properties);
                }
-               
-               JSONObject computeStatic(ReadGraph graph, Variable variable, ArrayList<Variable> statics) throws DatabaseException {
-                       
+
+               JSONObject computeStatic(ReadGraph graph, Variable variable, DocumentProperties statics) throws DatabaseException {
+
                        JSONObject base = graph.syncRequest(new org.simantics.document.server.request.DefaultFields(variable));
                        JSONObject object = base.clone();
-                       
-                       for(Variable attrib : statics) {
-                               String name = attrib.getName(graph);
+
+                       for(String name : statics.getKeys(graph, variable)) {
                                try {
                                        if (name.equals(NodeRequest.PROPERTY_VALUE_EXCEPTIONS)) {
-                                       @SuppressWarnings("unchecked")
-                                               Map<String, Exception> exceptions = (Map<String, Exception>)DocumentServerUtils.getValue(graph, attrib);
-                                       
-                                       List<String> errorList = object.getJSONField(NodeRequest.ERRORS);
-                                           if(errorList == null)
-                                               errorList = new ArrayList<String>();
-                                           
-                                   for (Map.Entry<String, Exception> entry : exceptions.entrySet()) {
-                                       String errorMessage = NodeRequestUtils.formatErrorMessage(entry.getKey(), entry.getValue());
-                                       errorList.add(errorMessage);
-                                   }
-                                       object.addJSONField(NodeRequest.ERRORS, errorList);
-                                       
-                                   } else {
-                                               Object value = DocumentServerUtils.getValue(graph, attrib);
-                                           object.addJSONField(name, value);
-                                   }
+                                               @SuppressWarnings("unchecked")
+                                               Map<String, Exception> exceptions = (Map<String, Exception>)statics.getValue(graph, variable, name);
+
+                                               List<String> errorList = object.getJSONField(NodeRequest.ERRORS);
+                                               if(errorList == null)
+                                                       errorList = new ArrayList<>();
+
+                                               for (Map.Entry<String, Exception> entry : exceptions.entrySet()) {
+                                                       String errorMessage = NodeRequestUtils.formatErrorMessage(entry.getKey(), entry.getValue());
+                                                       errorList.add(errorMessage);
+                                               }
+                                               object.addJSONField(NodeRequest.ERRORS, errorList);
+                                       } else {
+                                               object.addJSONField(name, statics.getValue(graph, variable, name));
+                                       }
                                } catch (Throwable t) {
-                                   List<String> errorList = object.getJSONField(NodeRequest.ERRORS);
-                                   if(errorList == null)
-                                       errorList = new ArrayList<String>();
-                                   
-                           String errorMessage = NodeRequestUtils.formatErrorMessage(name, t);
-                           
-                                   errorList.add(errorMessage);
-                                   object.addJSONField(NodeRequest.ERRORS, errorList);
+                                       List<String> errorList = object.getJSONField(NodeRequest.ERRORS);
+                                       if(errorList == null)
+                                               errorList = new ArrayList<>(1);
+
+                                       String errorMessage = NodeRequestUtils.formatErrorMessage(name, t);
+                                       errorList.add(errorMessage);
+                                       object.addJSONField(NodeRequest.ERRORS, errorList);
                                }
 
                        }
 
                        return object;
-                       
+
                }
-               
+
        }
 
        public static Collection<Variable> getDynamicAttributes(ReadGraph graph, final DocumentationResource DOC, Variable variable) throws DatabaseException {
-       Pair<JSONObject, Collection<Variable>> attribs = graph.syncRequest(new AttributesRequest(variable));
-       return attribs.second;
+               return Collections.emptyList();
        }
-       
+
        public static Variable getPossibleDocumentRootVariable(ReadGraph graph, Variable documentPart) throws DatabaseException {
-               if(documentPart instanceof RootVariable) return documentPart;
+               if(ProxyChildVariable.CONTEXT_END.equals(documentPart.getName(graph))) return documentPart;
                Variable parent = documentPart.getParent(graph);
                if(parent == null) return null;
                return getPossibleDocumentRootVariable(graph, parent);
index aabe7b29ffd04dbcdff684dc899f11f2bde8c19f..6ec2e6734a5a70808dcb02d6ef9e05c43a3a97ef 100644 (file)
@@ -15,7 +15,6 @@ import org.simantics.databoard.Bindings;
 import org.simantics.databoard.Datatypes;
 import org.simantics.databoard.binding.Binding;
 import org.simantics.databoard.type.Datatype;
-import org.simantics.db.AsyncReadGraph;
 import org.simantics.db.DirectStatements;
 import org.simantics.db.ReadGraph;
 import org.simantics.db.RequestProcessor;
@@ -25,7 +24,7 @@ import org.simantics.db.Statement;
 import org.simantics.db.WriteGraph;
 import org.simantics.db.common.primitiverequest.Adapter;
 import org.simantics.db.common.procedure.adapter.TransientCacheListener;
-import org.simantics.db.common.request.UnaryRead;
+import org.simantics.db.common.request.BinaryRead;
 import org.simantics.db.common.request.UniqueRead;
 import org.simantics.db.common.request.WriteResultRequest;
 import org.simantics.db.common.utils.Logger;
@@ -42,15 +41,14 @@ import org.simantics.db.layer0.scl.SCLDatabaseException;
 import org.simantics.db.layer0.variable.ConstantPropertyVariable;
 import org.simantics.db.layer0.variable.ProxyChildVariable;
 import org.simantics.db.layer0.variable.ProxySessionRequest;
+import org.simantics.db.layer0.variable.ProxyVariableSupport;
 import org.simantics.db.layer0.variable.ProxyVariables;
 import org.simantics.db.layer0.variable.StandardAssertedGraphPropertyVariable;
-import org.simantics.db.layer0.variable.StandardGraphChildVariable;
 import org.simantics.db.layer0.variable.StandardGraphPropertyVariable;
 import org.simantics.db.layer0.variable.Variable;
 import org.simantics.db.layer0.variable.VariableMap;
 import org.simantics.db.layer0.variable.VariableMapImpl;
 import org.simantics.db.layer0.variable.Variables;
-import org.simantics.db.procedure.AsyncProcedure;
 import org.simantics.db.service.DirectQuerySupport;
 import org.simantics.document.base.ontology.DocumentationResource;
 import org.simantics.document.server.bean.Command;
@@ -107,21 +105,6 @@ public class Functions {
 
     private static final org.slf4j.Logger LOGGER = LoggerFactory.getLogger(Functions.class);
     
-    private static class PrimitivePropertyStatementsProcedure implements AsyncProcedure<DirectStatements> {
-
-        public DirectStatements result;
-
-        @Override
-        public void execute(AsyncReadGraph graph, DirectStatements result) {
-            this.result = result;
-        }
-
-        @Override
-        public void exception(AsyncReadGraph graph, Throwable throwable) {
-        }
-
-    }
-
     @SCLValue(type = "VariableMap")
     public static VariableMap primitiveProperties = new VariableMapImpl() {
        private void storePropertyValueAndExceptions(ReadGraph graph, Variable parent, String name, Variable property, Map<String, Variable> map) {
@@ -229,6 +212,34 @@ public class Functions {
 
     };
 
+    static class StandardDocumentProperties implements DocumentProperties {
+
+        @Override
+        public Collection<String> getKeys(ReadGraph graph, Variable context) throws DatabaseException {
+            
+            DocumentationResource DOC = DocumentationResource.getInstance(graph);
+            StandardGraphPropertyVariable asd = new StandardGraphPropertyVariable(graph, context, DOC.Properties_primitiveProperties);
+            Map<String, Variable> ps = primitiveProperties.getVariables(graph, asd, null);
+            return ps.keySet();
+            
+        }
+
+        @Override
+        public Object getValue(ReadGraph graph, Variable context, String key) throws DatabaseException {
+            
+            DocumentationResource DOC = DocumentationResource.getInstance(graph);
+            StandardGraphPropertyVariable asd = new StandardGraphPropertyVariable(graph, context, DOC.Properties_primitiveProperties);
+            Map<String, Variable> ps = primitiveProperties.getVariables(graph, asd, null);
+            return ps.get(key).getValue(graph);
+            
+        }
+        
+    }
+    
+    public static DocumentProperties primitiveProperties() throws DatabaseException {
+        return new StandardDocumentProperties();
+    }
+    
     @SCLValue(type = "VariableMap")
     public static VariableMap inputSpaceChildren = new VariableMapImpl() {
 
@@ -257,7 +268,7 @@ public class Functions {
 
     };
 
-    static class DocumentProxyChildVariable extends ProxyChildVariable {
+    static class DocumentProxyChildVariable extends ProxyChildVariable implements ProxyVariableSupport {
 
         public DocumentProxyChildVariable(Variable base, Variable parent, Variable other, String name) {
             super(base, parent, other, name);
@@ -274,42 +285,26 @@ public class Functions {
                if(other instanceof ProxyChildVariable) {
                        // The context is also a proxy - let it do the job
                     return super.getPossibleChild(graph, name);
-               } else {
-                       return new RootVariable(this, base.getRepresents(graph));
-               }
-               }
-
-            return super.getPossibleChild(graph, name);
-
-        }
-
-        public Collection<Variable> getChildren(ReadGraph graph) throws DatabaseException {
-
-            Collection<Variable> result = super.getChildren(graph);
-            if(!(base instanceof ProxyChildVariable)) {
-               result.add(new RootVariable(this, base.getRepresents(graph)));
+                } else {
+                    return ProxyVariables.tryToOwnRenamed(graph, this, base, CONTEXT_END);
+                }
             }
-            return result;
-
-        }
 
-    }
-
-    static class RootVariable extends StandardGraphChildVariable {
+            return super.getPossibleChild(graph, name);
 
-        public RootVariable(DocumentProxyChildVariable parent, Resource resource) {
-            super(parent, null, resource);
         }
 
         @Override
-        public String getName(ReadGraph graph) throws DatabaseException {
-            return ProxyChildVariable.CONTEXT_END;
+        public Variable attachTo(ReadGraph graph, Variable parent) {
+            return attachToRenamed(graph, parent, name);
         }
-
-        @SuppressWarnings("deprecation")
+        
         @Override
-        public Variable getNameVariable(ReadGraph graph) throws DatabaseException {
-            return new ConstantPropertyVariable(this, Variables.NAME, ProxyChildVariable.CONTEXT_END, Bindings.STRING);
+        public Variable attachToRenamed(ReadGraph graph, Variable parent, String name) {
+            if(this.parent.equals(base))
+                return new DocumentProxyChildVariable(parent, parent, other, name);
+            else
+                return new DocumentProxyChildVariable(base, parent, other, name);
         }
 
     }
@@ -1252,11 +1247,11 @@ public class Functions {
                                                return true;
                                        }
                                } else {
-                                       Variable parentCp = graph.sync(new UnaryRead<Connection, Variable>(conn) {
+                                       Variable parentCp = graph.sync(new BinaryRead<Variable, Connection, Variable>(widget, conn) {
                                    @Override
                                    public Variable perform(ReadGraph graph) throws DatabaseException {
                                        DocumentationResource DOC = DocumentationResource.getInstance(graph);
-                                       Collection<VariableConnectionPointDescriptor> descs = parameter.getConnectionPointDescriptors(graph, null);
+                                       Collection<VariableConnectionPointDescriptor> descs = parameter2.getConnection2().getConnectionPointDescriptors(graph, parameter, null);
 
                                                for(VariableConnectionPointDescriptor desc : descs) {
                                                        if (DOC.Relations_partN.equals(desc.getConnectionPointResource(graph))) {
index d9418db9947d482fecd4daf547d85359363bea5c..8d96c4798cb59e0947bda57879f9019915afae39 100644 (file)
@@ -1,77 +1,35 @@
 package org.simantics.document.server.request;
 
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
-import java.util.Map;
-
 import org.simantics.db.ReadGraph;
 import org.simantics.db.exception.DatabaseException;
 import org.simantics.db.layer0.request.VariableRead;
 import org.simantics.db.layer0.variable.Variable;
 import org.simantics.document.server.DocumentServerUtils.AttributesRequest;
 import org.simantics.document.server.JSONObject;
-import org.simantics.utils.datastructures.Pair;
 
 public class NodeRequest extends VariableRead<JSONObject> {
 
     public static final String ERRORS = "Errors";
     public static final String PROPERTY_VALUE_EXCEPTIONS = "_PropertyValueExceptions";
-    
-       public NodeRequest(Variable node) {
-               super(node);
-       }
-
-       @SuppressWarnings("unchecked")
-    @Override
-       public JSONObject perform(ReadGraph graph) throws DatabaseException {
-
-               long s = System.nanoTime();
-
-               Pair<JSONObject, Collection<Variable>> attribs = graph.syncRequest(new AttributesRequest(variable));
-
-           JSONObject staticContent = attribs.first;
-           if(attribs.second.isEmpty()) {
-
-               if(DocumentRequest.PROFILE) {
-                       long dura = System.nanoTime()-s;
-                   if(dura > DocumentRequest.PROFILE_THRESHOLD_NODEREQUEST * 1e3) {
-                       System.err.println("NodeRequest " + System.identityHashCode(this) + " in " + 1e-6*dura + "ms. " + variable.getURI(graph));
-                   }
-               }
 
-               return staticContent;
-           }
-
-           Map<String,Object> dynamicContent = graph.syncRequest(new NodeRequestDynamic(variable));
-           if(dynamicContent.isEmpty()) {
-               return staticContent;
-           }
-
-        JSONObject result = staticContent.clone();
-        result.add(dynamicContent);
-
-        if(dynamicContent.containsKey(ERRORS) || staticContent.getJSONField(ERRORS) != null) {
-            ArrayList<String> errorList = new ArrayList<>();
-
-            if(dynamicContent.containsKey(ERRORS))
-                errorList.addAll((List<String>)dynamicContent.get(ERRORS));
+    public NodeRequest(Variable node) {
+        super(node);
+    }
 
-            if(staticContent.getJSONField(ERRORS) != null)
-                errorList.addAll((List<String>)staticContent.getJSONField(ERRORS));
+    @Override
+    public JSONObject perform(ReadGraph graph) throws DatabaseException {
+        long s = DocumentRequest.PROFILE ? System.nanoTime() : 0L;
 
-            result.addJSONField(ERRORS, errorList);
-        }
+        JSONObject staticContent = graph.syncRequest(new AttributesRequest(variable));
 
-        if(DocumentRequest.PROFILE) {
+        if (DocumentRequest.PROFILE) {
             long dura = System.nanoTime()-s;
-            if(dura > DocumentRequest.PROFILE_THRESHOLD_NODEREQUEST * 1e3) {
+            if (dura > DocumentRequest.PROFILE_THRESHOLD_NODEREQUEST * 1e3) {
                 System.err.println("NodeRequest " + System.identityHashCode(this) + " in " + 1e-6*dura + "ms. " + variable.getURI(graph));
             }
         }
-        
-        return result;
 
+        return staticContent;
     }
 
-}
\ No newline at end of file
+}