]> gerrit.simantics Code Review - simantics/platform.git/commitdiff
Merge "Removed stderr logging from CompileSCLMonitorRequest."
authorHannu Niemistö <hannu.niemisto@semantum.fi>
Thu, 2 Feb 2017 11:18:13 +0000 (13:18 +0200)
committerGerrit Code Review <gerrit2@www.simantics.org>
Thu, 2 Feb 2017 11:18:13 +0000 (13:18 +0200)
bundles/org.simantics.modeling/src/org/simantics/modeling/scl/CompileSCLMonitorRequest.java

index 10eeb6ac6aacce7255c510b848de59a4e55416b6..dfea839318d2c33415dd454c30a60980e9e55c5f 100644 (file)
@@ -29,10 +29,14 @@ import org.simantics.scl.compiler.types.Type;
 import org.simantics.scl.runtime.SCLContext;
 import org.simantics.scl.runtime.function.Function1;
 import org.simantics.utils.datastructures.Pair;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class CompileSCLMonitorRequest extends AbstractExpressionCompilationRequest<CompilationContext, Variable> {
-    
+
+    private static Logger LOGGER = LoggerFactory.getLogger(CompileSCLMonitorRequest.class);
+
     protected static Name BROWSE = Name.create("Simantics/Variables", "browse");
     protected static Name VALUE = Name.create("Simantics/Variables", "value");
     
@@ -72,10 +76,8 @@ public class CompileSCLMonitorRequest extends AbstractExpressionCompilationReque
             sclContext.put("graph", graph);
             return exp.apply(context.getParent(graph));
         } catch (DatabaseException e) {
-            e.printStackTrace();
             throw (DatabaseException)e;
         } catch (Throwable t) {
-            t.printStackTrace();
             throw new DatabaseException(t);
         } finally {
             sclContext.put("graph", oldGraph);
@@ -98,7 +100,7 @@ public class CompileSCLMonitorRequest extends AbstractExpressionCompilationReque
             try {
                 return Environments.getType(context.runtimeEnvironment.getEnvironment(), valueType);
             } catch (SCLExpressionCompilationException e) {
-                e.printStackTrace();
+                LOGGER.warn("getExpectedType failed for valueType: " + valueType, e);
             }
         }
         return super.getExpectedType(graph, context);