From: jsimomaa <jani.simomaa@gmail.com>
Date: Wed, 28 Dec 2016 14:05:48 +0000 (+0200)
Subject: ReflectionAdapter2 does not handle all Throwables
X-Git-Tag: v1.26.0~6
X-Git-Url: https://gerrit.simantics.org/r/gitweb?p=simantics%2Fplatform.git;a=commitdiff_plain;h=11161d156b6c6f5a9d37396b4ba1d2b69dfb8c1f;ds=sidebyside

ReflectionAdapter2 does not handle all Throwables

ReflectionAdapter2.adapt() does not catch all throwables (e.g.
NoClassDefFoundError) enabling the possibility that the throwable is not
shown to the developer in any manner (console or log)

refs #6898

Change-Id: I32388ebcb23233210c2e54f8530f7e8c626f28de
---

diff --git a/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/reflection/ReflectionAdapter2.java b/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/reflection/ReflectionAdapter2.java
index f8ec0f81a..ae76dac47 100644
--- a/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/reflection/ReflectionAdapter2.java
+++ b/bundles/org.simantics.db.services/src/org/simantics/db/services/adaption/reflection/ReflectionAdapter2.java
@@ -104,6 +104,9 @@ public class ReflectionAdapter2<T> implements Adapter<T, Resource> {
     				} catch (DatabaseException e) {
                         procedure.exception(graph, e);
     					e.printStackTrace();
+    				} catch (Throwable t) {
+    				    procedure.exception(graph, t);
+    				    t.printStackTrace();
     				}
                 }