In a product, the removed Files.exists(p) && !Files.isDirectory(p) code
threw an exception because the examined path was not guaranteed to be in
a coherent state at the time of examination but Files.createDirectories
would still take care of throwing any exceptions if there were any
problems in creating the directory.
The worst thing was that this exception was hidden and not even logged.
Luckily a problem case forced the find.
refs #7845
Change-Id: Ic3ae84afeb798772996057eee33f7467c448f3e7
import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
-import java.nio.file.Path;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
try {
mon.subTask("Start index write");
try {
mon.subTask("Start index write");
- createDirectory(indexPath);
+ Files.createDirectories(indexPath.toPath());
directory.set(FSDirectory.open(indexPath));
IndexWriterConfig conf = new IndexWriterConfig(Version.LUCENE_4_9, Queries.getAnalyzer()).setOpenMode(OpenMode.CREATE);
directory.set(FSDirectory.open(indexPath));
IndexWriterConfig conf = new IndexWriterConfig(Version.LUCENE_4_9, Queries.getAnalyzer()).setOpenMode(OpenMode.CREATE);
- private static void createDirectory(File path) throws IOException {
- Path p = path.toPath();
- if (Files.exists(p) && !Files.isDirectory(p))
- throw new IOException("Could not create index directory " + path + ", a file by that name already exists");
- Files.createDirectories(p);
- }
-
File getIndexPath() {
return indexPath;
}
File getIndexPath() {
return indexPath;
}